FAQ
SpellCheckComponent should build or load indices on startup and commits
-----------------------------------------------------------------------

Key: SOLR-622
URL: https://issues.apache.org/jira/browse/SOLR-622
Project: Solr
Issue Type: Improvement
Components: spellchecker
Affects Versions: 1.3
Reporter: Shalin Shekhar Mangar
Priority: Minor
Fix For: 1.3


SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.

* If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
* If index is built from a Solr field then re-build it on newSearcher event.

This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Shalin Shekhar Mangar (JIRA) at Jul 20, 2008 at 7:10 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar reassigned SOLR-622:
    ------------------------------------------

    Assignee: Shalin Shekhar Mangar
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 23, 2008 at 7:27 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Work on SOLR-622 started by Shalin Shekhar Mangar.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 23, 2008 at 7:51 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616239#action_12616239 ]

    Shalin Shekhar Mangar commented on SOLR-622:
    --------------------------------------------

    I suppose if a reload on firstSearcher fails due to some reason (missing/corrupted index), we should try to build it, right?
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 23, 2008 at 8:34 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616250#action_12616250 ]

    Shalin Shekhar Mangar commented on SOLR-622:
    --------------------------------------------

    Hmm. The reload OR build logic cannot work correctly with firstSearcher. We cannot rely on the spellCheckIndexDir existing on disk to be a sure sign that only a reload is necessary. It may just be an empty directory/index. In fact the AbstractLuceneSpellChecker creates a FSDirectory on init which means that doing a simple reload may not be enough on startup.

    I think we should always call reload on firstSearcher for all spell checkers and (only for Solr based spell checkers) call build on newSearcher event. The only case where this will be a problem is where an index exists, Solr is stopped, spell checker config is added/enabled and Solr is restarted. Now a reload is done but we do not have any data in the spell check index. If a commit is done or build is called manually, things will take care of themselves.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 23, 2008 at 8:36 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Description:
    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.

    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.

    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.

    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.

    was:
    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.

    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.

    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.


    Issue description edited to add note on enabling/disabling this feature per spell checker through configuration.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 26, 2008 at 3:23 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    Adds a firstSearcher and postCommit event listener using API calls. The firstSearcher listener is added for all spell checkers so that reload is called on startup but the postCommit call back is only added if the spellchecker specifies the following in it's configuration:
    {code:xml}
    <str name="buildOnCommit">true</str>
    {code}

    Adds tests for the same. However, they fail currently. See http://www.nabble.com/Question-on-newSearcher-and-commit-callbacks-tp18667573p18667573.html for details. If the second commit call in the tests is uncommented then the tests pass.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 31, 2008 at 10:56 am
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    This patch uses separate firstSearcher and newSearcher event listeners for each spell checker. All tests pass. I'll commit this shortly.

    We should still try to figure out why the searcher obtained in a postCommit listener does not get access to the latest searcher.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Yonik Seeley (JIRA) at Jul 31, 2008 at 6:16 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618787#action_12618787 ]

    Yonik Seeley commented on SOLR-622:
    -----------------------------------

    bq. We should still try to figure out why the searcher obtained in a postCommit listener does not get access to the latest searcher.

    I think the callback happens before the new searcher is opened.
    I think postCommit is also synchronous with the commit process - you don't want to rebuild your spell checking index here because it would freeze out any updates until it's done.

    We have warming mechanism that works for stuff like this... perhaps that is what should be used rather than postCommit callbacks?
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 31, 2008 at 7:05 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618811#action_12618811 ]

    Shalin Shekhar Mangar commented on SOLR-622:
    --------------------------------------------

    bq. I think the callback happens before the new searcher is opened.
    Yes, the searcher is being created after informing the listeners. IMO, that seems a bit counter-intuitive. The commit has happened so I would expect to see the new data.

    bq. We have warming mechanism that works for stuff like this... perhaps that is what should be used rather than postCommit callbacks?
    So the way used in the latest patch using a newSearcher event should be fine, right? It is done in a separate thread through ExecutorService in SolrCore.

    Not relevant to this issue but the newSearcher method is always called with a null currentSearcher, why is that? I mentioned it at http://www.nabble.com/Question-on-newSearcher-and-commit-callbacks-tp18667573p18667573.html


    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Yonik Seeley (JIRA) at Jul 31, 2008 at 7:27 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618822#action_12618822 ]

    Yonik Seeley commented on SOLR-622:
    -----------------------------------

    bq. Yes, the searcher is being created after informing the listeners. IMO, that seems a bit counter-intuitive. The commit has happened so I would expect to see the new data.

    That particular callback was made for index distribution. It needed to be synchronous with the commit process, not allowing anything else to proceed until finished to ensure a clean snapshot. The trigger is closing of the IndexWriter, not opening of a new IndexSearcher.

    We could create new callbacks, but I'm not sure I would want to do that for 1.3

    bq. So the way used in the latest patch using a newSearcher event should be fine, right? It is done in a separate thread through ExecutorService in SolrCore.

    I haven't looked at the patch, but this sounds potentially dangerous if you are using the searcher passed to you (async closes, etc). I've added a comment to the code about this.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 31, 2008 at 7:40 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618828#action_12618828 ]

    Shalin Shekhar Mangar commented on SOLR-622:
    --------------------------------------------

    bq. I haven't looked at the patch, but this sounds potentially dangerous if you are using the searcher passed to you (async closes, etc). I've added a comment to the code about this.

    The spell checker build is synchronous and completed inside the newSearcher call and the reference to searcher is not kept anywhere, we should be fine. In addition, I'll a note to the SolrSpellChecker#build method javadocs that no references to the searcher should be kept by implementations.

    Actually a reference to searcher is kept in the dictionary but the dictionary is used immediately and created everytime in the build method. We can get rid of it easily.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Yonik Seeley (JIRA) at Jul 31, 2008 at 7:43 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618829#action_12618829 ]

    Yonik Seeley commented on SOLR-622:
    -----------------------------------

    bq. It is done in a separate thread through ExecutorService in SolrCore.

    I may have mis-understood this part... I though you were using your own ExecutorService.
    So yes, using newSearcher and firstSearcher events should be fine. They will be synchronous though (block all other progress on warming and registering the new server). That may or may not be what you want.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Jul 31, 2008 at 7:55 pm
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618834#action_12618834 ]

    Shalin Shekhar Mangar commented on SOLR-622:
    --------------------------------------------

    Functionally, this patch aspires to eliminate the need to modify solrconfig.xml to add a reload call to firstSearcher and build call to newSearcher using the QuerySenderListener.

    bq. They will be synchronous though (block all other progress on warming and registering the new server). That may or may not be what you want.
    Until we can add a scheduler into Solr in the future (which is something a lot of components like replication and DataImportHandler may need), I really don't see any other way for now.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Aug 1, 2008 at 5:41 am
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    The last patch had some extra code which I was using for testing. This one removes all of those.

    I'll commit this shortly.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Aug 1, 2008 at 5:49 am
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: (was: SOLR-622.patch)
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Aug 1, 2008 at 5:52 am
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    The last patch was generated incorrectly. Uploading new one.

    We are introducing a configuration parameter for spell checker with this issue
    {code:xml}
    <str name="buildOnCommit">true</str>
    {code}
    Now there is no need to check if a spell checker is built from Solr field or not. If the configuration param is present, we can blindly build it on newSearcher event.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Sean Timm at Aug 1, 2008 at 2:17 pm
    Is there a recommended way to replicate the spell checker index from the
    master to the slaves?

    -Sean

    Shalin Shekhar Mangar (JIRA) wrote:
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    The last patch was generated incorrectly. Uploading new one.

    We are introducing a configuration parameter for spell checker with this issue
    {code:xml}
    <str name="buildOnCommit">true</str>
    {code}
    Now there is no need to check if a spell checker is built from Solr field or not. If the configuration param is present, we can blindly build it on newSearcher event.

    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
  • Shalin Shekhar Mangar at Aug 1, 2008 at 2:22 pm
    We have SOLR-433 open. Not sure what needs to be done there.
    On Fri, Aug 1, 2008 at 7:46 PM, Sean Timm wrote:

    Is there a recommended way to replicate the spell checker index from the
    master to the slaves?

    -Sean


    Shalin Shekhar Mangar (JIRA) wrote:
    [
    https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    The last patch was generated incorrectly. Uploading new one.

    We are introducing a configuration parameter for spell checker with this
    issue
    {code:xml}
    <str name="buildOnCommit">true</str>
    {code}
    Now there is no need to check if a spell checker is built from Solr field
    or not. If the configuration param is present, we can blindly build it on
    newSearcher event.


    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on
    startup and commits. With SOLR-605, SpellCheckComponent can register an
    event listener for firstSearcher and newSearcher events and rebuild/reload
    indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or
    else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher
    event.
    This will help avoid having to add QuerySenderListener in configuration
    and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild
    on commits should be able to turn this feature off per configured spell
    checker.

    --
    Regards,
    Shalin Shekhar Mangar.
  • Sean Timm at Aug 1, 2008 at 2:33 pm
    Thanks. I saw the "multicore" part of the issue title and disregarded
    it. :-)

    -Sean

    Shalin Shekhar Mangar wrote:
    We have SOLR-433 open. Not sure what needs to be done there.

    On Fri, Aug 1, 2008 at 7:46 PM, Sean Timm wrote:

    Is there a recommended way to replicate the spell checker index from the
    master to the slaves?

    -Sean


    Shalin Shekhar Mangar (JIRA) wrote:

    [
    https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]

    Shalin Shekhar Mangar updated SOLR-622:
    ---------------------------------------

    Attachment: SOLR-622.patch

    The last patch was generated incorrectly. Uploading new one.

    We are introducing a configuration parameter for spell checker with this
    issue
    {code:xml}
    <str name="buildOnCommit">true</str>
    {code}
    Now there is no need to check if a spell checker is built from Solr field
    or not. If the configuration param is present, we can blindly build it on
    newSearcher event.



    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on
    startup and commits. With SOLR-605, SpellCheckComponent can register an
    event listener for firstSearcher and newSearcher events and rebuild/reload
    indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or
    else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher
    event.
    This will help avoid having to add QuerySenderListener in configuration
    and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild
    on commits should be able to turn this feature off per configured spell
    checker.

  • Shalin Shekhar Mangar (JIRA) at Aug 1, 2008 at 6:13 am
    [ https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shalin Shekhar Mangar resolved SOLR-622.
    ----------------------------------------

    Resolution: Fixed

    Committed revision 681604.
    SpellCheckComponent should build or load indices on startup and commits
    -----------------------------------------------------------------------

    Key: SOLR-622
    URL: https://issues.apache.org/jira/browse/SOLR-622
    Project: Solr
    Issue Type: Improvement
    Components: spellchecker
    Affects Versions: 1.3
    Reporter: Shalin Shekhar Mangar
    Assignee: Shalin Shekhar Mangar
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-622.patch, SOLR-622.patch, SOLR-622.patch


    SpellCheckComponent must be able to build/load spell check index on startup and commits. With SOLR-605, SpellCheckComponent can register an event listener for firstSearcher and newSearcher events and rebuild/reload indices as appropriate.
    * If index uses a FSDirectory and exists on disk then just reload it or else build it on firstSearcher event.
    * If index is built from a Solr field then re-build it on newSearcher event.
    This will help avoid having to add QuerySenderListener in configuration and will not force people to issue build on first query.
    All this should be configurable so that people who don't want to rebuild on commits should be able to turn this feature off per configured spell checker.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupsolr-dev @
categorieslucene
postedJul 9, '08 at 6:22a
activeAug 1, '08 at 2:33p
posts21
users3
websitelucene.apache.org...

People

Translate

site design / logo © 2019 Grokbase