FAQ
[ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738027#action_12738027 ]

Uwe Schindler commented on LUCENE-1504:
---------------------------------------

I had no time to review the whole patch yet, but it seems to fit much better in the new DocIdSet API. I will look into this after my holiday (Thursday+).
SerialChainFilter should use DocSet API rather then deprecated BitSet API
-------------------------------------------------------------------------

Key: LUCENE-1504
URL: https://issues.apache.org/jira/browse/LUCENE-1504
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/spatial
Reporter: Ryan McKinley
Assignee: Uwe Schindler
Fix For: 2.9

Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


From erik's comments in LUCENE-1387
* Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Michael McCandless (JIRA) at Aug 3, 2009 at 9:55 am
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless updated LUCENE-1504:
    ---------------------------------------

    Attachment: LUCENE-1504.patch

    New patch:

    * Also switched over CartesianShapeFilter and BoundaryBoxFilter from BitSet -> DocIdSet

    * Added floor of 1 to "int miles" (this is to fix LUCENE-1777) in CartesianPolyFilterBuilder

    * Some small code cleanups
    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Assignee: Uwe Schindler
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Aug 3, 2009 at 10:29 am
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-1504:
    ----------------------------------

    Description: Contrib-Spatial should be rewritten to use the new DocIdSet Filter API with OpenBitSets instead of j.u.BitSets. FilteredDocIdSet can be used to replace (I)SerialChainFilter. (was: From erik's comments in LUCENE-1387

    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.


    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.)
    Summary: Contrib-Spatial should use DocSet API rather then deprecated BitSet API (was: SerialChainFilter should use DocSet API rather then deprecated BitSet API)

    I updated the issue's description.
    Mike, do you want to take this issue or should I commit later?
    Contrib-Spatial should use DocSet API rather then deprecated BitSet API
    -----------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Assignee: Uwe Schindler
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


    Contrib-Spatial should be rewritten to use the new DocIdSet Filter API with OpenBitSets instead of j.u.BitSets. FilteredDocIdSet can be used to replace (I)SerialChainFilter.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Aug 3, 2009 at 12:07 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless reassigned LUCENE-1504:
    ------------------------------------------

    Assignee: Michael McCandless (was: Uwe Schindler)
    Contrib-Spatial should use DocSet API rather then deprecated BitSet API
    -----------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Assignee: Michael McCandless
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


    Contrib-Spatial should be rewritten to use the new DocIdSet Filter API with OpenBitSets instead of j.u.BitSets. FilteredDocIdSet can be used to replace (I)SerialChainFilter.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Aug 3, 2009 at 12:07 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738302#action_12738302 ]

    Michael McCandless commented on LUCENE-1504:
    --------------------------------------------

    I'll take it.
    Contrib-Spatial should use DocSet API rather then deprecated BitSet API
    -----------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Assignee: Uwe Schindler
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


    Contrib-Spatial should be rewritten to use the new DocIdSet Filter API with OpenBitSets instead of j.u.BitSets. FilteredDocIdSet can be used to replace (I)SerialChainFilter.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Aug 3, 2009 at 12:13 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless updated LUCENE-1504:
    ---------------------------------------

    Attachment: LUCENE-1504.patch

    OK new patch:

    * Improved TestCartesian to test 6.0, 1.5, 0.001, and 0.0 miles

    * Implemented flooring logic as described in LUCENE-1777

    I think it's ready to commit... I'll wait a day or two!
    Contrib-Spatial should use DocSet API rather then deprecated BitSet API
    -----------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Assignee: Michael McCandless
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


    Contrib-Spatial should be rewritten to use the new DocIdSet Filter API with OpenBitSets instead of j.u.BitSets. FilteredDocIdSet can be used to replace (I)SerialChainFilter.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Aug 4, 2009 at 6:10 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless resolved LUCENE-1504.
    ----------------------------------------

    Resolution: Fixed

    And then, there were 8!
    Contrib-Spatial should use DocSet API rather then deprecated BitSet API
    -----------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Assignee: Michael McCandless
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch


    Contrib-Spatial should be rewritten to use the new DocIdSet Filter API with OpenBitSets instead of j.u.BitSets. FilteredDocIdSet can be used to replace (I)SerialChainFilter.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupjava-dev @
categorieslucene
postedAug 2, '09 at 9:32a
activeAug 4, '09 at 6:10p
posts7
users1
websitelucene.apache.org

1 user in discussion

Michael McCandless (JIRA): 7 posts

People

Translate

site design / logo © 2021 Grokbase