FAQ
[ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

patrick o'leary updated LUCENE-1504:
------------------------------------

Attachment: LUCENE-1504.patch

Moved both ISerialChainFilter and SerialChainFilter to package o.a.l.s
Added getDocIdSet to SerialChainFilter, still calls bits on the filters, should remain until bits is
removed from Filter.java?
SerialChainFilter should use DocSet API rather then deprecated BitSet API
-------------------------------------------------------------------------

Key: LUCENE-1504
URL: https://issues.apache.org/jira/browse/LUCENE-1504
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/spatial
Reporter: Ryan McKinley
Fix For: 2.9

Attachments: LUCENE-1504.patch


From erik's comments in LUCENE-1387
* Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Paul Elschot (JIRA) at Jan 5, 2009 at 6:30 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660839#action_12660839 ]

    Paul Elschot commented on LUCENE-1504:
    --------------------------------------

    In trunk, there is no more need to call Filter.bits().

    But the same functions are also present in contrib/queries/.../BooleanFilter.java and in contrib/misc*/.../ChainedFilter.java, and these were already adapted to use Filter.getDocIdSet().
    These also use o.a.l.util.OpenBitSet which is normally slightly faster than java's BitSet.

    In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.


    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Fix For: 2.9

    Attachments: LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Jan 5, 2009 at 7:22 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660864#action_12660864 ]

    Uwe Schindler commented on LUCENE-1504:
    ---------------------------------------

    Hi Patrick,

    as the search contrib was included into Lucene after 2.4 where the old API is already deprecated, there is no need to implement bits() at all. Just leave the default, that get removed on 3.0. As the code was not released before the deprecation, there would be nobody using it and it does not make sense to add APIs that are deprecated from the beginning.

    TrieRangeFilter was also included after the change and never implemented bits() [it implemented it in the past, but at this time it was in another package outside of lucene, so deprecation is out of responsibility for lucene].

    Paul:
    bq. In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.

    Very interesting, on thinking about how to include TrieRangeQuery with spatial contrib, I was thining about a dependency, but I was not sure, if it is possible. How can it be done in the build.xml of the contrib?
    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Fix For: 2.9

    Attachments: LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Jan 5, 2009 at 7:24 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660864#action_12660864 ]

    thetaphi edited comment on LUCENE-1504 at 1/5/09 11:22 AM:
    ----------------------------------------------------------------

    Hi Patrick,

    as the spatial contrib was included into Lucene after 2.4 where the old API is already deprecated, there is no need to implement bits() at all. Just leave the default, that get removed on 3.0. As the code was not released before the deprecation, there would be nobody using it and it does not make sense to add APIs that are deprecated from the beginning.

    TrieRangeFilter was also included after the change and never implemented bits() [it implemented it in the past, but at this time it was in another package outside of lucene, so deprecation is out of responsibility for lucene].

    Paul:
    bq. In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.

    Very interesting, on thinking about how to include TrieRangeQuery with spatial contrib, I was thining about a dependency, but I was not sure, if it is possible. How can it be done in the build.xml of the contrib?

    was (Author: thetaphi):
    Hi Patrick,

    as the search contrib was included into Lucene after 2.4 where the old API is already deprecated, there is no need to implement bits() at all. Just leave the default, that get removed on 3.0. As the code was not released before the deprecation, there would be nobody using it and it does not make sense to add APIs that are deprecated from the beginning.

    TrieRangeFilter was also included after the change and never implemented bits() [it implemented it in the past, but at this time it was in another package outside of lucene, so deprecation is out of responsibility for lucene].

    Paul:
    bq. In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.

    Very interesting, on thinking about how to include TrieRangeQuery with spatial contrib, I was thining about a dependency, but I was not sure, if it is possible. How can it be done in the build.xml of the contrib?
    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Fix For: 2.9

    Attachments: LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • patrick o'leary (JIRA) at Jan 5, 2009 at 8:14 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    patrick o'leary updated LUCENE-1504:
    ------------------------------------

    Attachment: LUCENE-1504.patch

    Changed filter calls from bits to getDocIdSet, the ISerialChainFilter will maintain
    a method called bits(IndexReader, BitSet)

    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Paul Elschot (JIRA) at Jan 5, 2009 at 10:02 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660947#action_12660947 ]

    Paul Elschot commented on LUCENE-1504:
    --------------------------------------

    On dependencies between contrib modules, I think I spoke a bit too soon.
    There is an addtional.dependencies path a.o. in contrib/regex/build.xml, and this is what I was thinking would do the trick, but that does not appear to refer to another contrib module.
    It is probably better to ask on java-dev how to do this.
    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Mark Miller (JIRA) at Jan 6, 2009 at 6:43 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661249#action_12661249 ]

    Mark Miller commented on LUCENE-1504:
    -------------------------------------

    I think there is contrib dependency examples in the xml query parser and in the highlighter (which depends on MemoryIndex).
    SerialChainFilter should use DocSet API rather then deprecated BitSet API
    -------------------------------------------------------------------------

    Key: LUCENE-1504
    URL: https://issues.apache.org/jira/browse/LUCENE-1504
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Reporter: Ryan McKinley
    Fix For: 2.9

    Attachments: LUCENE-1504.patch, LUCENE-1504.patch


    From erik's comments in LUCENE-1387
    * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
    We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupjava-dev @
categorieslucene
postedJan 5, '09 at 5:38p
activeJan 6, '09 at 6:43p
posts7
users1
websitelucene.apache.org

1 user in discussion

Mark Miller (JIRA): 7 posts

People

Translate

site design / logo © 2021 Grokbase