FAQ
[ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-1296:
---------------------------------------

Attachment: LUCENE-1296.patch

Paul, I reverted the changes to ChainedFilter & BooleanFilter, and instead deprecated the new finalResult method. It's dangerous to just remove protected methods since on upgrading there will be no errors but, silently, the finalResult method will no longer be called. I think in 3.0 when we remove these methods, rather than simply removing them we should actually mark them final such that any subclasses still using them will see hard compilation errors.

Can you look over the new patch?
Allow use of compact DocIdSet in CachingWrapperFilter
-----------------------------------------------------

Key: LUCENE-1296
URL: https://issues.apache.org/jira/browse/LUCENE-1296
Project: Lucene - Java
Issue Type: New Feature
Components: Search
Reporter: Paul Elschot
Assignee: Michael McCandless
Priority: Minor
Fix For: 2.9

Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch


Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Paul Elschot (JIRA) at Dec 1, 2008 at 6:18 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652081#action_12652081 ]

    Paul Elschot commented on LUCENE-1296:
    --------------------------------------

    Indeed it is better to be conservative about released things as in today's patch.
    Allow use of compact DocIdSet in CachingWrapperFilter
    -----------------------------------------------------

    Key: LUCENE-1296
    URL: https://issues.apache.org/jira/browse/LUCENE-1296
    Project: Lucene - Java
    Issue Type: New Feature
    Components: Search
    Reporter: Paul Elschot
    Assignee: Michael McCandless
    Priority: Minor
    Fix For: 2.9

    Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch


    Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Dec 1, 2008 at 6:54 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless resolved LUCENE-1296.
    ----------------------------------------

    Resolution: Fixed
    Lucene Fields: [New, Patch Available] (was: [Patch Available, New])

    Committed revision 722174.

    Thanks Paul!
    Allow use of compact DocIdSet in CachingWrapperFilter
    -----------------------------------------------------

    Key: LUCENE-1296
    URL: https://issues.apache.org/jira/browse/LUCENE-1296
    Project: Lucene - Java
    Issue Type: New Feature
    Components: Search
    Reporter: Paul Elschot
    Assignee: Michael McCandless
    Priority: Minor
    Fix For: 2.9

    Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch


    Extends CachingWrapperFilter with a protected method to determine the DocIdSet to be cached.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupjava-dev @
categorieslucene
postedDec 1, '08 at 12:26p
activeDec 1, '08 at 6:54p
posts3
users1
websitelucene.apache.org

1 user in discussion

Michael McCandless (JIRA): 3 posts

People

Translate

site design / logo © 2021 Grokbase