Grokbase Groups Lucene dev June 2016
FAQ
[ https://issues.apache.org/jira/browse/SOLR-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Rowe reopened SOLR-8866:
------------------------------

Reopening to backport to 6.0.2, 5.6 and 5.5.2.
UpdateLog should throw an exception when serializing unknown types
------------------------------------------------------------------

Key: SOLR-8866
URL: https://issues.apache.org/jira/browse/SOLR-8866
Project: Solr
Issue Type: Improvement
Reporter: David Smiley
Assignee: David Smiley
Fix For: 6.1

Attachments: SOLR_8866_UpdateLog_show_throw_for_unknown_types.patch


When JavaBinCodec encounters a class it doesn't have explicit knowledge of how to serialize, nor does it implement the {{ObjectResolver}} interface, it currently serializes the object as the classname, colon, then toString() of the object.
This may appear innocent but _not_ throwing an exception hides bugs. One example is that the UpdateLog, which uses JavaBinCodec, to save a document. The result is that this bad value winds up there, gets deserialized as a String in PeerSync (which uses /get) and then this value pretends to be a suitable value to the final document in the leader. But of course it isn't.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Search Discussions

  • ASF subversion and git services (JIRA) at Jun 18, 2016 at 12:01 am
    [ https://issues.apache.org/jira/browse/SOLR-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337258#comment-15337258 ]

    ASF subversion and git services commented on SOLR-8866:
    -------------------------------------------------------

    Commit e04c11f2af087eb2b321a34fa0dd5c4866c02fac in lucene-solr's branch refs/heads/branch_5x from [~dsmiley]
    [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e04c11f ]

    SOLR-8866: UpdateLog now throws an error if it can't serialize a field value
    (cherry picked from commit a22099a)

    UpdateLog should throw an exception when serializing unknown types
    ------------------------------------------------------------------

    Key: SOLR-8866
    URL: https://issues.apache.org/jira/browse/SOLR-8866
    Project: Solr
    Issue Type: Improvement
    Reporter: David Smiley
    Assignee: David Smiley
    Fix For: 6.1

    Attachments: SOLR_8866_UpdateLog_show_throw_for_unknown_types.patch


    When JavaBinCodec encounters a class it doesn't have explicit knowledge of how to serialize, nor does it implement the {{ObjectResolver}} interface, it currently serializes the object as the classname, colon, then toString() of the object.
    This may appear innocent but _not_ throwing an exception hides bugs. One example is that the UpdateLog, which uses JavaBinCodec, to save a document. The result is that this bad value winds up there, gets deserialized as a String in PeerSync (which uses /get) and then this value pretends to be a suitable value to the final document in the leader. But of course it isn't.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • ASF subversion and git services (JIRA) at Jun 18, 2016 at 12:01 am
    [ https://issues.apache.org/jira/browse/SOLR-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337257#comment-15337257 ]

    ASF subversion and git services commented on SOLR-8866:
    -------------------------------------------------------

    Commit 8f64b63a0a47ba6d28984555956465600d9cd416 in lucene-solr's branch refs/heads/branch_5_5 from [~dsmiley]
    [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f64b63 ]

    SOLR-8866: UpdateLog now throws an error if it can't serialize a field value
    (cherry picked from commit a22099a)

    UpdateLog should throw an exception when serializing unknown types
    ------------------------------------------------------------------

    Key: SOLR-8866
    URL: https://issues.apache.org/jira/browse/SOLR-8866
    Project: Solr
    Issue Type: Improvement
    Reporter: David Smiley
    Assignee: David Smiley
    Fix For: 6.1

    Attachments: SOLR_8866_UpdateLog_show_throw_for_unknown_types.patch


    When JavaBinCodec encounters a class it doesn't have explicit knowledge of how to serialize, nor does it implement the {{ObjectResolver}} interface, it currently serializes the object as the classname, colon, then toString() of the object.
    This may appear innocent but _not_ throwing an exception hides bugs. One example is that the UpdateLog, which uses JavaBinCodec, to save a document. The result is that this bad value winds up there, gets deserialized as a String in PeerSync (which uses /get) and then this value pretends to be a suitable value to the final document in the leader. But of course it isn't.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • ASF subversion and git services (JIRA) at Jun 18, 2016 at 12:01 am
    [ https://issues.apache.org/jira/browse/SOLR-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337259#comment-15337259 ]

    ASF subversion and git services commented on SOLR-8866:
    -------------------------------------------------------

    Commit d2597ecace3da64397c5417905d1b439dbb2f675 in lucene-solr's branch refs/heads/branch_6_0 from [~dsmiley]
    [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d2597ec ]

    SOLR-8866: UpdateLog now throws an error if it can't serialize a field value
    (cherry picked from commit a22099a)

    UpdateLog should throw an exception when serializing unknown types
    ------------------------------------------------------------------

    Key: SOLR-8866
    URL: https://issues.apache.org/jira/browse/SOLR-8866
    Project: Solr
    Issue Type: Improvement
    Reporter: David Smiley
    Assignee: David Smiley
    Fix For: 6.1

    Attachments: SOLR_8866_UpdateLog_show_throw_for_unknown_types.patch


    When JavaBinCodec encounters a class it doesn't have explicit knowledge of how to serialize, nor does it implement the {{ObjectResolver}} interface, it currently serializes the object as the classname, colon, then toString() of the object.
    This may appear innocent but _not_ throwing an exception hides bugs. One example is that the UpdateLog, which uses JavaBinCodec, to save a document. The result is that this bad value winds up there, gets deserialized as a String in PeerSync (which uses /get) and then this value pretends to be a suitable value to the final document in the leader. But of course it isn't.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedJun 17, '16 at 11:58p
activeJun 18, '16 at 12:01a
posts4
users1
websitelucene.apache.org

People

Translate

site design / logo © 2019 Grokbase