Grokbase Groups Lucene dev April 2013
FAQ
Mark Bennett created SOLR-4759:
----------------------------------

Summary: Cleanup Velocity Templates
Key: SOLR-4759
URL: https://issues.apache.org/jira/browse/SOLR-4759
Project: Solr
Issue Type: Bug
Affects Versions: 4.2
Reporter: Mark Bennett


Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity

* Add README.txt file with complete file list
* Add comments to all files
* Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
* Make file naming consistent. We had this_that, thisThat and this-that
Changed all to this_that, though also considered this-that.
* Modularize some files
* Included a hit_plain.vm example, though not active by default.
* Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
* CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)

As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Search Discussions

  • Mark Bennett (JIRA) at Apr 24, 2013 at 11:15 pm
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Bennett updated SOLR-4759:
    -------------------------------

    Attachment: SOLR-4759.patch

    Patch against TRUNK

    See also recent SOLR-4702
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Attachments: SOLR-4759.patch


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Mark Bennett (JIRA) at Apr 25, 2013 at 2:50 pm
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Bennett updated SOLR-4759:
    -------------------------------

    Attachment: velocity-SOLR-4759.zip

    Because the patch includes both file renaming and content changes the patch command gives errors. Per Erik H, this is a binary version of the changes. (includes .svn dirs). Meant to be extracted from solr/example/solr/collection1/conf/
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Attachments: SOLR-4759.patch, velocity-SOLR-4759.zip


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Commit Tag Bot (JIRA) at Apr 28, 2013 at 11:30 pm
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644170#comment-13644170 ]

    Commit Tag Bot commented on SOLR-4759:
    --------------------------------------

    [branch_4x commit] ehatcher
    http://svn.apache.org/viewvc?view=revision&revision=1476857

    SOLR-4759: Velocity template cleanup
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Attachments: SOLR-4759.patch, velocity-SOLR-4759.zip


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Commit Tag Bot (JIRA) at Apr 28, 2013 at 11:32 pm
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644171#comment-13644171 ]

    Commit Tag Bot commented on SOLR-4759:
    --------------------------------------

    [trunk commit] ehatcher
    http://svn.apache.org/viewvc?view=revision&revision=1476858

    SOLR-4759: Velocity template cleanup
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Attachments: SOLR-4759.patch, velocity-SOLR-4759.zip


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Erik Hatcher (JIRA) at Apr 28, 2013 at 11:34 pm
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Erik Hatcher resolved SOLR-4759.
    --------------------------------

    Resolution: Fixed
    Fix Version/s: 4.4
    5.0
    Assignee: Erik Hatcher

    Committed to both 4x and trunk. There were a couple of differences in Mark's patch and what I committed with a couple of typo/spelling corrections, updated README, and left the JQuery file names as-is rather than rename them to stay with the same names that of those 3rd party files.
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Assignee: Erik Hatcher
    Fix For: 5.0, 4.4

    Attachments: SOLR-4759.patch, velocity-SOLR-4759.zip


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Commit Tag Bot (JIRA) at Apr 29, 2013 at 7:08 am
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644315#comment-13644315 ]

    Commit Tag Bot commented on SOLR-4759:
    --------------------------------------

    [trunk commit] uschindler
    http://svn.apache.org/viewvc?view=revision&revision=1476907

    SOLR-4759: Add missing svn:eol-style properties
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Assignee: Erik Hatcher
    Fix For: 5.0, 4.4

    Attachments: SOLR-4759.patch, velocity-SOLR-4759.zip


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Commit Tag Bot (JIRA) at Apr 29, 2013 at 7:10 am
    [ https://issues.apache.org/jira/browse/SOLR-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644316#comment-13644316 ]

    Commit Tag Bot commented on SOLR-4759:
    --------------------------------------

    [branch_4x commit] uschindler
    http://svn.apache.org/viewvc?view=revision&revision=1476908

    Merged revision(s) 1476907 from lucene/dev/trunk:
    SOLR-4759: Add missing svn:eol-style properties
    Cleanup Velocity Templates
    --------------------------

    Key: SOLR-4759
    URL: https://issues.apache.org/jira/browse/SOLR-4759
    Project: Solr
    Issue Type: Bug
    Affects Versions: 4.2
    Reporter: Mark Bennett
    Assignee: Erik Hatcher
    Fix For: 5.0, 4.4

    Attachments: SOLR-4759.patch, velocity-SOLR-4759.zip


    Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity
    * Add README.txt file with complete file list
    * Add comments to all files
    * Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
    * Make file naming consistent. We had this_that, thisThat and this-that
    Changed all to this_that, though also considered this-that.
    * Modularize some files
    * Included a hit_plain.vm example, though not active by default.
    * Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
    * CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)
    As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators
    For more information on JIRA, see: http://www.atlassian.com/software/jira

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedApr 24, '13 at 11:09p
activeApr 29, '13 at 7:10a
posts8
users1
websitelucene.apache.org

1 user in discussion

Commit Tag Bot (JIRA): 8 posts

People

Translate

site design / logo © 2019 Grokbase