FAQ
Remove DocumentBuilder interface from facet module
--------------------------------------------------

Key: LUCENE-3549
URL: https://issues.apache.org/jira/browse/LUCENE-3549
Project: Lucene - Java
Issue Type: Improvement
Components: modules/facet
Reporter: Shai Erera
Assignee: Shai Erera
Priority: Trivial
Fix For: 3.5, 4.0


The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.

Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.

More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.

If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Search Discussions

  • Michael McCandless (Commented) (JIRA) at Nov 1, 2011 at 2:31 pm
    [ https://issues.apache.org/jira/browse/LUCENE-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141202#comment-13141202 ]

    Michael McCandless commented on LUCENE-3549:
    --------------------------------------------

    I think we should just remove it?

    This is really an app-level thing, and I think overkill for Lucene's one usage of it.
    Remove DocumentBuilder interface from facet module
    --------------------------------------------------

    Key: LUCENE-3549
    URL: https://issues.apache.org/jira/browse/LUCENE-3549
    Project: Lucene - Java
    Issue Type: Improvement
    Components: modules/facet
    Reporter: Shai Erera
    Assignee: Shai Erera
    Priority: Trivial
    Fix For: 3.5, 4.0


    The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.
    Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.
    More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.
    If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
    For more information on JIRA, see: http://www.atlassian.com/software/jira



    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Uwe Schindler (Commented) (JIRA) at Nov 1, 2011 at 2:37 pm
    [ https://issues.apache.org/jira/browse/LUCENE-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141207#comment-13141207 ]

    Uwe Schindler commented on LUCENE-3549:
    ---------------------------------------

    +1 to remove. Alltogether it looks too much XML DOM tree like :-) [it's only missing DocumentBuilderFactory]
    Remove DocumentBuilder interface from facet module
    --------------------------------------------------

    Key: LUCENE-3549
    URL: https://issues.apache.org/jira/browse/LUCENE-3549
    Project: Lucene - Java
    Issue Type: Improvement
    Components: modules/facet
    Reporter: Shai Erera
    Assignee: Shai Erera
    Priority: Trivial
    Fix For: 3.5, 4.0


    The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.
    Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.
    More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.
    If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
    For more information on JIRA, see: http://www.atlassian.com/software/jira



    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Shai Erera (Updated) (JIRA) at Nov 1, 2011 at 3:05 pm
    [ https://issues.apache.org/jira/browse/LUCENE-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shai Erera updated LUCENE-3549:
    -------------------------------

    Attachment: LUCENE-3549.patch

    Patch against 3x (but easy to apply on trunk as well).

    I will commit this soon.
    Remove DocumentBuilder interface from facet module
    --------------------------------------------------

    Key: LUCENE-3549
    URL: https://issues.apache.org/jira/browse/LUCENE-3549
    Project: Lucene - Java
    Issue Type: Improvement
    Components: modules/facet
    Reporter: Shai Erera
    Assignee: Shai Erera
    Priority: Trivial
    Fix For: 3.5, 4.0

    Attachments: LUCENE-3549.patch


    The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.
    Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.
    More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.
    If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
    For more information on JIRA, see: http://www.atlassian.com/software/jira



    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org
  • Shai Erera (Resolved) (JIRA) at Nov 2, 2011 at 7:08 am
    [ https://issues.apache.org/jira/browse/LUCENE-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shai Erera resolved LUCENE-3549.
    --------------------------------

    Resolution: Fixed

    Committed revision 1196471 (3x).
    Committed revision 1196474 (trunk).
    Remove DocumentBuilder interface from facet module
    --------------------------------------------------

    Key: LUCENE-3549
    URL: https://issues.apache.org/jira/browse/LUCENE-3549
    Project: Lucene - Java
    Issue Type: Improvement
    Components: modules/facet
    Reporter: Shai Erera
    Assignee: Shai Erera
    Priority: Trivial
    Fix For: 3.5, 4.0

    Attachments: LUCENE-3549.patch


    The facet module contains an interface called DocumentBuilder, which contains a single method, build(Document) (it's a builder API). We use it in my company to standardize how different modules populate a Document object. I've included it with the facet contribution so that things will compile with as few code changes as possible.
    Now it's time to do some cleanup and I'd like to start with this interface. If people think that this interface is useful to reside in 'core', then I don't mind moving it there. But otherwise, let's remove it from the code. It has only one impl in the facet module: CategoryDocumentBuilder, and we can certainly do without the interface.
    More so, it's under o.a.l package which is inappropriate IMO. If it's moved to 'core', it should be under o.a.l.document.
    If people see any problem with that, please speak up. I will do the changes and post a patch here shortly.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
    For more information on JIRA, see: http://www.atlassian.com/software/jira



    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedNov 1, '11 at 2:23p
activeNov 2, '11 at 7:08a
posts5
users1
websitelucene.apache.org

1 user in discussion

Shai Erera (Resolved) (JIRA): 5 posts

People

Translate

site design / logo © 2021 Grokbase