[ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932242#action_12932242 ]

Yonik Seeley commented on LUCENE-2649:

Prompted by Robert's pointer to non-thread-safety of parser changing in numeric classes, I did a quick review of IntValuesCreator. It isn't thread safe if you don't specify a parser yourself and let it auto-detect, but I'll leave that part for another time.

I was going to point out that using deletedDocs when enumerating docs is probably a waste, since all readers that only differ by deletedDocs (generated by reopen, etc) will share the same cache entry. But then I realized that this is perhaps a bug - not just in this issue, but in all FieldCache implementations since we went away from using "reader" as the key?

Other stuff we can do:
- use fastSet (as uwe said)
- use bulk API
- we instantiate vals.values lazily for some reason... and then at the end, if it still hasn't been instantiated, we do it anyway?
- I'm still trying to grok the logic of calling checkMatchAllBits only if vals.valid == null... seems like it will always return null in that case?
FieldCache should include a BitSet for matching docs

Key: LUCENE-2649
URL: https://issues.apache.org/jira/browse/LUCENE-2649
Project: Lucene - Java
Issue Type: Improvement
Components: Search
Reporter: Ryan McKinley
Assignee: Ryan McKinley
Fix For: 4.0

Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch

The FieldCache returns an array representing the values for each doc. However there is no way to know if the doc actually has a value.
This should be changed to return an object representing the values *and* a BitSet for all valid docs.
This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
postedNov 15, '10 at 10:44p
activeNov 15, '10 at 10:44p

1 user in discussion

Yonik Seeley (JIRA): 1 post



site design / logo © 2021 Grokbase