FAQ
Several final classes have non-overriding protected members
-----------------------------------------------------------

Key: LUCENE-2200
URL: https://issues.apache.org/jira/browse/LUCENE-2200
Project: Lucene - Java
Issue Type: Improvement
Affects Versions: 3.0
Reporter: Steven Rowe
Priority: Trivial


Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Steven Rowe (JIRA) at Jan 9, 2010 at 4:01 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Steven Rowe updated LUCENE-2200:
    --------------------------------

    Attachment: LUCENE-2200.patch
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Priority: Trivial
    Attachments: LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Steven Rowe (JIRA) at Jan 9, 2010 at 4:05 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798370#action_12798370 ]

    Steven Rowe commented on LUCENE-2200:
    -------------------------------------

    All tests pass with the attached patch applied.
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Priority: Trivial
    Attachments: LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Simon Willnauer (JIRA) at Jan 9, 2010 at 6:45 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798389#action_12798389 ]

    Simon Willnauer commented on LUCENE-2200:
    -----------------------------------------

    Steve, I briefly looked at your patch. Could we make some of the member vars final too?
    The reader in CharReader or the defaultAnalyzer in ShingleAnalyzerWrapper for instance.

    simon
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Priority: Trivial
    Attachments: LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Steven Rowe (JIRA) at Jan 9, 2010 at 6:59 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Steven Rowe updated LUCENE-2200:
    --------------------------------

    Attachment: LUCENE-2200.patch

    bq. Could we make some of the member vars final too?

    Done in the new version of the patch. Note that I didn't try to look in classes other than those already modified in the previous version of the patch for final class member access modification.
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Priority: Trivial
    Attachments: LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Steven Rowe (JIRA) at Jan 9, 2010 at 8:04 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798396#action_12798396 ]

    Steven Rowe commented on LUCENE-2200:
    -------------------------------------

    FYI, all tests pass for me with the new version of the patch applied.
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Priority: Trivial
    Attachments: LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Robert Muir (JIRA) at Jan 10, 2010 at 4:02 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798495#action_12798495 ]

    Robert Muir commented on LUCENE-2200:
    -------------------------------------

    all tests pass and patch looks good to me. will commit at the end of the day.
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Assignee: Robert Muir
    Priority: Trivial
    Attachments: LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Robert Muir (JIRA) at Jan 10, 2010 at 4:02 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Muir reassigned LUCENE-2200:
    -----------------------------------

    Assignee: Robert Muir
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Assignee: Robert Muir
    Priority: Trivial
    Attachments: LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Simon Willnauer (JIRA) at Jan 10, 2010 at 5:50 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798516#action_12798516 ]

    Simon Willnauer commented on LUCENE-2200:
    -----------------------------------------

    Robert, when you commit this make sure you mark the Attributes in EdgeNGramTokenFilter.java final thanks.
    Steve thanks for the patch, such work is always appreciated.

    simon
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Assignee: Robert Muir
    Priority: Trivial
    Attachments: LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Steven Rowe (JIRA) at Jan 10, 2010 at 7:35 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Steven Rowe updated LUCENE-2200:
    --------------------------------

    Attachment: LUCENE-2200.patch

    bq. Robert, when you commit this make sure you mark the Attributes in EdgeNGramTokenFilter.java final thanks.

    Whoops, I missed those - thanks for checking, Simon. (minGram and maxGram can also be final in EdgeNGramTokenFilter.java.)

    I've attached a new patch that includes these changes -- all tests pass.

    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Assignee: Robert Muir
    Priority: Trivial
    Attachments: LUCENE-2200.patch, LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Robert Muir (JIRA) at Jan 10, 2010 at 9:13 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Muir resolved LUCENE-2200.
    ---------------------------------

    Resolution: Fixed
    Fix Version/s: 3.1

    Thanks Steven!
    Several final classes have non-overriding protected members
    -----------------------------------------------------------

    Key: LUCENE-2200
    URL: https://issues.apache.org/jira/browse/LUCENE-2200
    Project: Lucene - Java
    Issue Type: Improvement
    Affects Versions: 3.0
    Reporter: Steven Rowe
    Assignee: Robert Muir
    Priority: Trivial
    Fix For: 3.1

    Attachments: LUCENE-2200.patch, LUCENE-2200.patch, LUCENE-2200.patch


    Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedJan 9, '10 at 3:59p
activeJan 10, '10 at 9:13p
posts11
users1
websitelucene.apache.org

1 user in discussion

Robert Muir (JIRA): 11 posts

People

Translate

site design / logo © 2021 Grokbase