FAQ
Simplify and tidy Cartesian Tier Code in Spatial
------------------------------------------------

Key: LUCENE-2173
URL: https://issues.apache.org/jira/browse/LUCENE-2173
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/spatial
Affects Versions: 3.1
Reporter: Chris Male


The Cartesian Tier filtering code in the spatial code can be simplified, tidied and generally improved. Improvements include removing default field name support which isn't the responsibility of the code, adding javadoc, making method names more intuitive and trying to make the complex code in CartesianPolyFilterBuilder more understandable.

Few deprecations have to occur as part of this work, but some public methods in CartesianPolyFilterBuilder will be made private where possible so future improvements of this class can occur.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Chris Male (JIRA) at Dec 20, 2009 at 7:50 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Male updated LUCENE-2173:
    -------------------------------

    Attachment: LUCENE-2173.patch

    Attaching first attempt at this work.
    Simplify and tidy Cartesian Tier Code in Spatial
    ------------------------------------------------

    Key: LUCENE-2173
    URL: https://issues.apache.org/jira/browse/LUCENE-2173
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Affects Versions: 3.1
    Reporter: Chris Male
    Attachments: LUCENE-2173.patch


    The Cartesian Tier filtering code in the spatial code can be simplified, tidied and generally improved. Improvements include removing default field name support which isn't the responsibility of the code, adding javadoc, making method names more intuitive and trying to make the complex code in CartesianPolyFilterBuilder more understandable.
    Few deprecations have to occur as part of this work, but some public methods in CartesianPolyFilterBuilder will be made private where possible so future improvements of this class can occur.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Chris Male (JIRA) at Dec 20, 2009 at 8:10 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Male updated LUCENE-2173:
    -------------------------------

    Attachment: LUCENE-2173.patch

    Attached new patch which deprecates getBoundingArea in CartesianPolyFilterBuilder and replaces it with a more intuitive buildFilter.
    Simplify and tidy Cartesian Tier Code in Spatial
    ------------------------------------------------

    Key: LUCENE-2173
    URL: https://issues.apache.org/jira/browse/LUCENE-2173
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Affects Versions: 3.1
    Reporter: Chris Male
    Attachments: LUCENE-2173.patch, LUCENE-2173.patch


    The Cartesian Tier filtering code in the spatial code can be simplified, tidied and generally improved. Improvements include removing default field name support which isn't the responsibility of the code, adding javadoc, making method names more intuitive and trying to make the complex code in CartesianPolyFilterBuilder more understandable.
    Few deprecations have to occur as part of this work, but some public methods in CartesianPolyFilterBuilder will be made private where possible so future improvements of this class can occur.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Chris Male (JIRA) at Dec 20, 2009 at 8:28 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Male updated LUCENE-2173:
    -------------------------------

    Attachment: LUCENE-2173.patch

    Updated patch to remove PolyCheck class which didn't seem to have a purpose and was broken by the changes to visibility in CartesianPolyFilterBuilder
    Simplify and tidy Cartesian Tier Code in Spatial
    ------------------------------------------------

    Key: LUCENE-2173
    URL: https://issues.apache.org/jira/browse/LUCENE-2173
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Affects Versions: 3.1
    Reporter: Chris Male
    Attachments: LUCENE-2173.patch, LUCENE-2173.patch, LUCENE-2173.patch


    The Cartesian Tier filtering code in the spatial code can be simplified, tidied and generally improved. Improvements include removing default field name support which isn't the responsibility of the code, adding javadoc, making method names more intuitive and trying to make the complex code in CartesianPolyFilterBuilder more understandable.
    Few deprecations have to occur as part of this work, but some public methods in CartesianPolyFilterBuilder will be made private where possible so future improvements of this class can occur.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Simon Willnauer (JIRA) at Dec 30, 2009 at 10:39 am
    [ https://issues.apache.org/jira/browse/LUCENE-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Simon Willnauer reassigned LUCENE-2173:
    ---------------------------------------

    Assignee: Simon Willnauer
    Simplify and tidy Cartesian Tier Code in Spatial
    ------------------------------------------------

    Key: LUCENE-2173
    URL: https://issues.apache.org/jira/browse/LUCENE-2173
    Project: Lucene - Java
    Issue Type: Improvement
    Components: contrib/spatial
    Affects Versions: 3.1
    Reporter: Chris Male
    Assignee: Simon Willnauer
    Attachments: LUCENE-2173.patch, LUCENE-2173.patch, LUCENE-2173.patch


    The Cartesian Tier filtering code in the spatial code can be simplified, tidied and generally improved. Improvements include removing default field name support which isn't the responsibility of the code, adding javadoc, making method names more intuitive and trying to make the complex code in CartesianPolyFilterBuilder more understandable.
    Few deprecations have to occur as part of this work, but some public methods in CartesianPolyFilterBuilder will be made private where possible so future improvements of this class can occur.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedDec 20, '09 at 7:44p
activeDec 30, '09 at 10:39a
posts5
users1
websitelucene.apache.org

1 user in discussion

Simon Willnauer (JIRA): 5 posts

People

Translate

site design / logo © 2021 Grokbase