FAQ
Highlighter fails to highlight FuzzyQuery
-----------------------------------------

Key: LUCENE-2123
URL: https://issues.apache.org/jira/browse/LUCENE-2123
Project: Lucene - Java
Issue Type: Bug
Components: contrib/highlighter
Affects Versions: 3.0, 2.9.1
Reporter: Uwe Schindler
Assignee: Uwe Schindler


As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE, because it changes the rewrite mode to Boolean query. There are two possibilities to fix it:
- Allow MTQ to change rewrite method and for this to work port the patch from LUCENE-2110 (flex branch) to trunk/2.9/3.0, that provides a FUZZY_REWRITE method, that would be the default fro Fuzzy but can be changed to any other method.
- if instanceof FuzzyQuery do not try to change rewritemode, as FuzzyQuery rewrites to BooleanQuery/TermQuery always.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Uwe Schindler (JIRA) at Dec 6, 2009 at 11:43 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Description:
    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.


    was:
    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE, because it changes the rewrite mode to Boolean query. There are two possibilities to fix it:
    - Allow MTQ to change rewrite method and for this to work port the patch from LUCENE-2110 (flex branch) to trunk/2.9/3.0, that provides a FUZZY_REWRITE method, that would be the default fro Fuzzy but can be changed to any other method.
    - if instanceof FuzzyQuery do not try to change rewritemode, as FuzzyQuery rewrites to BooleanQuery/TermQuery always.

    Affects Version/s: (was: 2.9.1)
    (was: 3.0)
    Flex Branch
    Fix Version/s: Flex Branch
    Highlighter fails to highlight FuzzyQuery
    -----------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Simon Willnauer (JIRA) at Dec 7, 2009 at 9:10 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786828#action_12786828 ]

    Simon Willnauer commented on LUCENE-2123:
    -----------------------------------------

    Could we make FuzzyRewrite a subclass of BooleanQueryRewriteMethod and add a simple check like
    {code}
    if(!mtq.getRewriteMethod() instanceof BooleanRewrite){
    mtq.setRewriteMethod(BooleanRewriteMethod)
    }
    {code}

    As it rewrites to booleanquery it seems to be ok to subclass though.

    Yet another thing, you throw unsupportedOperationException in FuzzyQuery#setRewriteMethod, we should at least document in MTQ that this is an optional operation. Something like
    {code}
    /**
    * ... (optional operation)
    * @throws UnsupportedOperationException if this method is not supported by the MultiTermQuery
    */
    {code}



    Highlighter fails to highlight FuzzyQuery
    -----------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 7, 2009 at 9:39 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786835#action_12786835 ]

    Uwe Schindler commented on LUCENE-2123:
    ---------------------------------------

    bq. Could we make FuzzyRewrite a subclass of BooleanQueryRewriteMethod and add a simple check like

    The problem is that also ConstantScoreBooleanRewrite subclasses BooleanQueryRewriteMethod.

    bq. Yet another thing, you throw unsupportedOperationException in FuzzyQuery#setRewriteMethod, we should at least document in MTQ that this is an optional operation. Something like

    This issue will remove this an make FUZZY_REWRITE public and maybe move to MTQ (because it is also useful for other boosting term lists to only put the highest ranking erms into the BQ). The name could be something like HIGHEST_SCORING_BOOLEAN_QUERY_REWRITE (brr).
    Highlighter fails to highlight FuzzyQuery
    -----------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 11:30 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-flex.patch

    Here a refactoring of the rewrite modes in Flex. I'll port to trunk, too.

    FuzzyQuery now uses per default TOP_TERMS_SCORING_BOOLEAN_REWRITE which is part of MTQ and can now also be used by e.g. MoreLikeThis.
    Highlighter fails to highlight FuzzyQuery
    -----------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 11:58 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-flex.patch

    More refactoring. No also AUTO_REWRITE uses the new TermCollector. It gets less and less code.
    Highlighter fails to highlight FuzzyQuery
    -----------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 12:08 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-flex.patch

    Now i also made the strange anonymous inner class a named inner class to get rid of the strange boolean holder, implemented by an array.
    Highlighter fails to highlight FuzzyQuery
    -----------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 4:31 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Description:
    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.

    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.

    was:
    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.


    Summary: Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery (was: Highlighter fails to highlight FuzzyQuery)

    Trunk patch comes soon.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 5:15 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123.patch
    LUCENE-2123-flex.patch

    Here the final patches with updated JavaDocs. I want to apply them in this form to trunk and flex. If nobody objects I will do this tomorrow.

    WIth this patch, FuzzyQuery will always highlight correctly, as it can be switched to boolean query rewrite mode.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 7:24 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123.patch
    LUCENE-2123-flex.patch

    Here is the code as discussed on IRC:
    It fixes the braindead LUCENE-504 code :-)
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 9, 2009 at 9:01 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123.patch
    LUCENE-2123-flex.patch

    So the last patch for today.

    I optimized the PQ to reuse the ScoreTerm instance when the PQ is full. I think for current FuzzyQuery the rewrite modes are now as best as possible. The tests pass that already test the overflow of the PQ by setting BQ.maxClauseCount to a very low value.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 10, 2009 at 7:14 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123.patch
    LUCENE-2123-flex.patch

    After sleeping one more night, I added code to not even put the termsinto the PQ, when they are not competitive. More support for automaton query will come only in flex with LUCENE-2140.

    I like to commit this during the day. Thanks for all the support and interesting discussions.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 10, 2009 at 7:28 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Lucene Fields: [New, Patch Available] (was: [New])
    Fix Version/s: 3.1
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Dec 10, 2009 at 10:22 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788646#action_12788646 ]

    Michael McCandless commented on LUCENE-2123:
    --------------------------------------------

    Latest patch looks great Uwe!
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 10, 2009 at 11:02 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Fix Version/s: 3.0.1
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.0.1, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 10, 2009 at 12:02 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler resolved LUCENE-2123.
    -----------------------------------

    Resolution: Fixed
    Fix Version/s: (was: 3.0.1)

    Committed in trunk and flex!

    WARNING: Please do not merge revision #889181 to flex!

    I'll will not merge this to 3.0 branch, as the ScoreTerm is protected and this change need to invert th PQ order, which would break BW compatibility.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 10, 2009 at 6:00 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788811#action_12788811 ]

    Uwe Schindler commented on LUCENE-2123:
    ---------------------------------------

    I already closed this issue, but still open is migration to 3.0, where the PQ is somehow broken (can consume too much RAM). There are two possibilities to merge:

    - Apply this patch to 3.0 -> new features, ok for 3.0 branch
    - Only fix PQ issue in FuzzyQuery -> Problem: ScoreDoc is protected and there is the need to change the comparator (inverse). In my opinion the ScoreTerm should be a private class at all (like it is in MTQ now). But we cannot change it (BW compatibility). A solution could be to ignore the comparator and give the inverse comparator in the PQ ctor as param. In trunk, the ScoreTerm class is deprecated and dead code, but has the original comparator.

    What to do?
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 10, 2009 at 6:38 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-lucene30.patch

    Solution 2 for 3.0 branch that inverts the ScoreTerm comparator with an additional Comparator.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 10:05 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-ScoreTermRemoval-trunk.patch
    LUCENE-2123-lucene30.patch

    Here the version with BW break. The inner class ScoreTerm in Fuzzy query was never intended to be public. If somebody used it, code will break, but that is not likely to be the case.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 10:09 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-lucene30.patch

    Removed unused include.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 10:49 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-lucene30.patch

    3.0 branch + scoring test. Committed revision: 889567
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 10:51 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Fix Version/s: 3.0.1
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.0.1, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 11:37 am
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-ScoreTermRemoval-trunk.patch

    Here the same change for trunk. It also contains a test that checks a term range (which has no boost) with the fuzzy rewrite mode and tests that the PQ correctly only returns the lower terms.
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.0.1, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 1:09 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: LUCENE-2123-ScoreTermRemoval-trunk.patch

    Better test for the PQ tie-break case.

    I'll commit soon and also merge to flex (in flex more changes in javadocs needed).
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.0.1, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 1:11 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Uwe Schindler updated LUCENE-2123:
    ----------------------------------

    Attachment: (was: LUCENE-2123-ScoreTermRemoval-trunk.patch)
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.0.1, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Uwe Schindler (JIRA) at Dec 11, 2009 at 1:25 pm
    [ https://issues.apache.org/jira/browse/LUCENE-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789303#action_12789303 ]

    Uwe Schindler commented on LUCENE-2123:
    ---------------------------------------

    To test the comparator and inject a bug:
    remove:
    {code}
    // ignore uncompetetive hits
    if (stQueue.size() >= maxSize && boost <= stQueue.peek().boost)
    return true;
    {code}

    and inverse the comparator's term order:
    {code}
    public int compareTo(ScoreTerm other) {
    if (this.boost == other.boost)
    return *-*other.term.compareTo(this.term);
    else
    return Float.compare(this.boost, other.boost);
    }
    {code}
    Move FuzzyQuery rewrite as separate RewriteMode into MTQ, was: Highlighter fails to highlight FuzzyQuery
    --------------------------------------------------------------------------------------------------------

    Key: LUCENE-2123
    URL: https://issues.apache.org/jira/browse/LUCENE-2123
    Project: Lucene - Java
    Issue Type: Bug
    Components: contrib/highlighter
    Affects Versions: Flex Branch
    Reporter: Uwe Schindler
    Assignee: Uwe Schindler
    Fix For: Flex Branch, 3.0.1, 3.1

    Attachments: LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-flex.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-lucene30.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123-ScoreTermRemoval-trunk.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch, LUCENE-2123.patch


    As FuzzyQuery does not allow to change the rewrite mode, highlighter fails with UOE in flex since LUCENE-2110, because it changes the rewrite mode to Boolean query. The fix is: Allow MTQ to change rewrite method and make FUZZY_REWRITE public for that.
    The rewrite mode will live in MTQ as TOP_TERMS_SCORING_BOOLEAN_REWRITE. Also the code will be refactored to make heavy reuse of term enumeration code and only plug in the PQ for filtering the top terms.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedDec 6, '09 at 11:31p
activeDec 11, '09 at 1:25p
posts26
users1
websitelucene.apache.org

1 user in discussion

Uwe Schindler (JIRA): 26 posts

People

Translate

site design / logo © 2021 Grokbase