FAQ
Minor refactoring to IndexFileNameFilter
----------------------------------------

Key: LUCENE-1499
URL: https://issues.apache.org/jira/browse/LUCENE-1499
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Reporter: Shai Erera
Priority: Minor
Fix For: 2.4.1, 2.9


IndexFileNameFilter looks like it's designed to be a singleton, however its constructor is public and its singleton member is package visible. The proposed patch changes the constructor and member to private. Since it already has a static getFilter() method, and no code in Lucene references those two, I don't think it creates any problems from an API perspective.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Shai Erera (JIRA) at Dec 22, 2008 at 12:51 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Shai Erera updated LUCENE-1499:
    -------------------------------

    Attachment: LUCENE-1499.patch
    Minor refactoring to IndexFileNameFilter
    ----------------------------------------

    Key: LUCENE-1499
    URL: https://issues.apache.org/jira/browse/LUCENE-1499
    Project: Lucene - Java
    Issue Type: Improvement
    Components: Index
    Reporter: Shai Erera
    Priority: Minor
    Fix For: 2.4.1, 2.9

    Attachments: LUCENE-1499.patch


    IndexFileNameFilter looks like it's designed to be a singleton, however its constructor is public and its singleton member is package visible. The proposed patch changes the constructor and member to private. Since it already has a static getFilter() method, and no code in Lucene references those two, I don't think it creates any problems from an API perspective.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Dec 22, 2008 at 2:43 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless reassigned LUCENE-1499:
    ------------------------------------------

    Assignee: Michael McCandless
    Minor refactoring to IndexFileNameFilter
    ----------------------------------------

    Key: LUCENE-1499
    URL: https://issues.apache.org/jira/browse/LUCENE-1499
    Project: Lucene - Java
    Issue Type: Improvement
    Components: Index
    Reporter: Shai Erera
    Assignee: Michael McCandless
    Priority: Minor
    Fix For: 2.4.1, 2.9

    Attachments: LUCENE-1499.patch


    IndexFileNameFilter looks like it's designed to be a singleton, however its constructor is public and its singleton member is package visible. The proposed patch changes the constructor and member to private. Since it already has a static getFilter() method, and no code in Lucene references those two, I don't think it creates any problems from an API perspective.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Michael McCandless (JIRA) at Dec 22, 2008 at 7:23 pm
    [ https://issues.apache.org/jira/browse/LUCENE-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Michael McCandless resolved LUCENE-1499.
    ----------------------------------------

    Resolution: Fixed
    Fix Version/s: (was: 2.4.1)
    Lucene Fields: [New, Patch Available] (was: [Patch Available, New])

    Committed revision 728746.

    Thanks Shai!
    Minor refactoring to IndexFileNameFilter
    ----------------------------------------

    Key: LUCENE-1499
    URL: https://issues.apache.org/jira/browse/LUCENE-1499
    Project: Lucene - Java
    Issue Type: Improvement
    Components: Index
    Reporter: Shai Erera
    Assignee: Michael McCandless
    Priority: Minor
    Fix For: 2.9

    Attachments: LUCENE-1499.patch


    IndexFileNameFilter looks like it's designed to be a singleton, however its constructor is public and its singleton member is package visible. The proposed patch changes the constructor and member to private. Since it already has a static getFilter() method, and no code in Lucene references those two, I don't think it creates any problems from an API perspective.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedDec 22, '08 at 12:43p
activeDec 22, '08 at 7:23p
posts4
users1
websitelucene.apache.org

1 user in discussion

Michael McCandless (JIRA): 4 posts

People

Translate

site design / logo © 2021 Grokbase