FAQ
I was in the middle of updating it.

-----Original Message-----
From: Chris Hostetter
Sent: Wednesday, October 25, 2006 11:10 AM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
final


what happend to the patch for this issue? ... there doesn't seem to be
anything attached to it in Jira.


: Date: Wed, 25 Oct 2006 11:02:28 -0700
: From: Andreas Neumann <neunand@gmail.com>
: Reply-To: java-dev@lucene.apache.org
: To: java-dev@lucene.apache.org
: Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
final
:
: Two comments:
:
: 1. In this particular case, all I need is the ability to override base
: class method
: getEnum(). No need to access or change member variables. As the
class already
: defines getters for the members, the members can remain private.
:
: 2. I noticed that many members have package (default Java) visibility.
: An example is
: analysis.Token. Its two members startOffset and endOffset only have
: getters, but no
: setters. If you want to set these after the Token was constructed,
: you need to define
: a subclass in the org.apache.lucene.analysis package. In cases like
: this, I don't think
: it would harm to make them protected, such that subclasses outside
: the package
: can access them. Or add setters to the base class.
:
: - Andreas.
:
: ---------------------------------------------------------------------
: To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
: For additional commands, e-mail: java-dev-help@lucene.apache.org
:



-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org

Search Discussions

  • Chris Hostetter at Oct 26, 2006 at 6:53 am
    : I was in the middle of updating it.

    Ah ..... i *really* don't think we should ever replace one patch with
    another ... it makes it impossible to compare the pros/cons of the two
    approaches.


    : -----Original Message-----
    : From: Chris Hostetter
    : Sent: Wednesday, October 25, 2006 11:10 AM
    : To: java-dev@lucene.apache.org
    : Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
    : final
    :
    :
    : what happend to the patch for this issue? ... there doesn't seem to be
    : anything attached to it in Jira.
    :
    :
    : : Date: Wed, 25 Oct 2006 11:02:28 -0700
    : : From: Andreas Neumann <neunand@gmail.com>
    : : Reply-To: java-dev@lucene.apache.org
    : : To: java-dev@lucene.apache.org
    : : Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
    : final
    : :
    : : Two comments:
    : :
    : : 1. In this particular case, all I need is the ability to override base
    : : class method
    : : getEnum(). No need to access or change member variables. As the
    : class already
    : : defines getters for the members, the members can remain private.
    : :
    : : 2. I noticed that many members have package (default Java) visibility.
    : : An example is
    : : analysis.Token. Its two members startOffset and endOffset only have
    : : getters, but no
    : : setters. If you want to set these after the Token was constructed,
    : : you need to define
    : : a subclass in the org.apache.lucene.analysis package. In cases like
    : : this, I don't think
    : : it would harm to make them protected, such that subclasses outside
    : : the package
    : : can access them. Or add setters to the base class.
    : :
    : : - Andreas.
    : :
    : : ---------------------------------------------------------------------
    : : To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    : : For additional commands, e-mail: java-dev-help@lucene.apache.org
    : :
    :
    :
    :
    : -Hoss
    :
    :
    : ---------------------------------------------------------------------
    : To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    : For additional commands, e-mail: java-dev-help@lucene.apache.org
    :
    :
    : ---------------------------------------------------------------------
    : To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    : For additional commands, e-mail: java-dev-help@lucene.apache.org
    :



    -Hoss


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org
  • Steven Parkes at Oct 26, 2006 at 7:00 am
    I was wondering about that. Oh, well, figures I'd get it wrong the first
    time ...

    -----Original Message-----
    From: Chris Hostetter
    Sent: Wednesday, October 25, 2006 11:17 AM
    To: java-dev@lucene.apache.org
    Subject: RE: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
    final


    : I was in the middle of updating it.

    Ah ..... i *really* don't think we should ever replace one patch with
    another ... it makes it impossible to compare the pros/cons of the two
    approaches.


    : -----Original Message-----
    : From: Chris Hostetter
    : Sent: Wednesday, October 25, 2006 11:10 AM
    : To: java-dev@lucene.apache.org
    : Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
    : final
    :
    :
    : what happend to the patch for this issue? ... there doesn't seem to be
    : anything attached to it in Jira.
    :
    :
    : : Date: Wed, 25 Oct 2006 11:02:28 -0700
    : : From: Andreas Neumann <neunand@gmail.com>
    : : Reply-To: java-dev@lucene.apache.org
    : : To: java-dev@lucene.apache.org
    : : Subject: Re: [jira] Commented: (LUCENE-657) FuzzyQuery should not be
    : final
    : :
    : : Two comments:
    : :
    : : 1. In this particular case, all I need is the ability to override
    base
    : : class method
    : : getEnum(). No need to access or change member variables. As the
    : class already
    : : defines getters for the members, the members can remain private.
    : :
    : : 2. I noticed that many members have package (default Java)
    visibility.
    : : An example is
    : : analysis.Token. Its two members startOffset and endOffset only
    have
    : : getters, but no
    : : setters. If you want to set these after the Token was
    constructed,
    : : you need to define
    : : a subclass in the org.apache.lucene.analysis package. In cases
    like
    : : this, I don't think
    : : it would harm to make them protected, such that subclasses
    outside
    : : the package
    : : can access them. Or add setters to the base class.
    : :
    : : - Andreas.
    : :
    : :
    ---------------------------------------------------------------------
    : : To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    : : For additional commands, e-mail: java-dev-help@lucene.apache.org
    : :
    :
    :
    :
    : -Hoss
    :
    :
    : ---------------------------------------------------------------------
    : To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    : For additional commands, e-mail: java-dev-help@lucene.apache.org
    :
    :
    : ---------------------------------------------------------------------
    : To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    : For additional commands, e-mail: java-dev-help@lucene.apache.org
    :



    -Hoss


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
    For additional commands, e-mail: java-dev-help@lucene.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieslucene
postedOct 26, '06 at 6:49a
activeOct 26, '06 at 7:00a
posts3
users2
websitelucene.apache.org

2 users in discussion

Steven Parkes: 2 posts Chris Hostetter: 1 post

People

Translate

site design / logo © 2021 Grokbase