FAQ
Mohit Sabharwal created HIVE-9193:
-------------------------------------

              Summary: Fix ordering differences due to Java 8 (Part 3)
                  Key: HIVE-9193
                  URL: https://issues.apache.org/jira/browse/HIVE-9193
              Project: Hive
           Issue Type: Sub-task
           Components: Tests
             Reporter: Mohit Sabharwal
             Assignee: Mohit Sabharwal


This patch fixes following q-test failures in Java 8:

(1) avro_* q-tests with map data type.

Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.

(2) plan_json.q, join0.q, input4.q, authorization_explain.q

{{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.

(3) explain_dependency.q

{{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.

(4) list_bucket_dml_6.q

{{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Search Discussions

  • Mohit Sabharwal (JIRA) at Dec 22, 2014 at 9:47 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mohit Sabharwal updated HIVE-9193:
    ----------------------------------
         Attachment: HIVE-9193.patch
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Mohit Sabharwal (JIRA) at Dec 22, 2014 at 9:47 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mohit Sabharwal updated HIVE-9193:
    ----------------------------------
         Status: Patch Available (was: Open)
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Brock Noland (JIRA) at Dec 23, 2014 at 12:03 am
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256339#comment-14256339 ]

    Brock Noland commented on HIVE-9193:
    ------------------------------------

    +1
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hive QA (JIRA) at Dec 23, 2014 at 8:49 am
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256745#comment-14256745 ]

    Hive QA commented on HIVE-9193:
    -------------------------------



    {color:red}Overall{color}: -1 at least one tests failed

    Here are the results of testing the latest attachment:
    https://issues.apache.org/jira/secure/attachment/12688725/HIVE-9193.patch

    {color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 6719 tests executed
    *Failed tests:*
    {noformat}
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_explain
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_date
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_deserialize_map_null
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_nullable_fields
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_timestamp
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_explain_dependency
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input4
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join0
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_6
    org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_plan_json
    org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_join0
    org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_lvj_mapjoin
    org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan
    org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority
    {noformat}

    Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2169/testReport
    Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2169/console
    Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2169/

    Messages:
    {noformat}
    Executing org.apache.hive.ptest.execution.PrepPhase
    Executing org.apache.hive.ptest.execution.ExecutionPhase
    Executing org.apache.hive.ptest.execution.ReportingPhase
    Tests exited with: TestsFailedException: 14 tests failed
    {noformat}

    This message is automatically generated.

    ATTACHMENT ID: 12688725 - PreCommit-HIVE-TRUNK-Build
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Brock Noland (JIRA) at Dec 23, 2014 at 4:17 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257153#comment-14257153 ]

    Brock Noland commented on HIVE-9193:
    ------------------------------------

    Looks like these failures are related.
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Mohit Sabharwal (JIRA) at Dec 23, 2014 at 7:25 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mohit Sabharwal updated HIVE-9193:
    ----------------------------------
         Attachment: HIVE-9193.1.patch
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.1.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Mohit Sabharwal (JIRA) at Dec 23, 2014 at 7:29 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257402#comment-14257402 ]

    Mohit Sabharwal commented on HIVE-9193:
    ---------------------------------------

    Oops, I only renamed the old out files to 1.7, but needed to regenerate -- to account for java_version_specific hint.

    Attaching patch with the fix.
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.1.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hive QA (JIRA) at Dec 24, 2014 at 4:48 am
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257957#comment-14257957 ]

    Hive QA commented on HIVE-9193:
    -------------------------------



    {color:red}Overall{color}: -1 at least one tests failed

    Here are the results of testing the latest attachment:
    https://issues.apache.org/jira/secure/attachment/12688901/HIVE-9193.1.patch

    {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6722 tests executed
    *Failed tests:*
    {noformat}
    org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_join0
    org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection
    {noformat}

    Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2181/testReport
    Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2181/console
    Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2181/

    Messages:
    {noformat}
    Executing org.apache.hive.ptest.execution.PrepPhase
    Executing org.apache.hive.ptest.execution.ExecutionPhase
    Executing org.apache.hive.ptest.execution.ReportingPhase
    Tests exited with: TestsFailedException: 2 tests failed
    {noformat}

    This message is automatically generated.

    ATTACHMENT ID: 12688901 - PreCommit-HIVE-TRUNK-Build
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.1.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Mohit Sabharwal (JIRA) at Dec 24, 2014 at 6:22 am
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mohit Sabharwal updated HIVE-9193:
    ----------------------------------
         Attachment: HIVE-9193.2.patch
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.1.patch, HIVE-9193.2.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hive QA (JIRA) at Dec 24, 2014 at 2:03 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258261#comment-14258261 ]

    Hive QA commented on HIVE-9193:
    -------------------------------



    {color:red}Overall{color}: -1 at least one tests failed

    Here are the results of testing the latest attachment:
    https://issues.apache.org/jira/secure/attachment/12689002/HIVE-9193.2.patch

    {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6722 tests executed
    *Failed tests:*
    {noformat}
    org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority
    {noformat}

    Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2189/testReport
    Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2189/console
    Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2189/

    Messages:
    {noformat}
    Executing org.apache.hive.ptest.execution.PrepPhase
    Executing org.apache.hive.ptest.execution.ExecutionPhase
    Executing org.apache.hive.ptest.execution.ReportingPhase
    Tests exited with: TestsFailedException: 1 tests failed
    {noformat}

    This message is automatically generated.

    ATTACHMENT ID: 12689002 - PreCommit-HIVE-TRUNK-Build
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.1.patch, HIVE-9193.2.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Brock Noland (JIRA) at Dec 24, 2014 at 2:32 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258284#comment-14258284 ]

    Brock Noland commented on HIVE-9193:
    ------------------------------------

    I've previously +1'ed this change and since the patch could easily get out of date, I will commit now.
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Attachments: HIVE-9193.1.patch, HIVE-9193.2.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Brock Noland (JIRA) at Dec 24, 2014 at 2:34 pm
    [ https://issues.apache.org/jira/browse/HIVE-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Brock Noland updated HIVE-9193:
    -------------------------------
            Resolution: Fixed
         Fix Version/s: 0.15.0
                Status: Resolved (was: Patch Available)

    Thank you [~mohitsabharwal] for your contribution! I have committed this to trunk!
    Fix ordering differences due to Java 8 (Part 3)
    -----------------------------------------------

    Key: HIVE-9193
    URL: https://issues.apache.org/jira/browse/HIVE-9193
    Project: Hive
    Issue Type: Sub-task
    Components: Tests
    Reporter: Mohit Sabharwal
    Assignee: Mohit Sabharwal
    Fix For: 0.15.0

    Attachments: HIVE-9193.1.patch, HIVE-9193.2.patch, HIVE-9193.patch


    This patch fixes following q-test failures in Java 8:
    (1) avro_* q-tests with map data type.
    Select operator uses {{LazySimpleSerDe}}/{{StandMapObjectInspector}}, which is used all over for serializing results back to the end user for queries with maps. To avoid adding the additional memory cost associated with {{LinkedHashMap}}, we generate java version specific out files for these tests.
    (2) plan_json.q, join0.q, input4.q, authorization_explain.q
    {{EXPLAIN FORMATTED}} outputs string representation of {{JSONObject}}, which internally is a {{HashMap}}. Again, we generate java version specific out files for these tests.
    (3) explain_dependency.q
    {{EXPLAIN DEPENDENCY}} outputs string representation of {{ReadEntity.parents}}. Changed that to an ordered map.
    (4) list_bucket_dml_6.q
    {{DESC FORMATTED}} calls {{StorageDescriptor.getSkewedInfo()}} HMS API, which returns a thrift (unordered) map. Generate java version specific out file for this test.


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieshive, hadoop
postedDec 22, '14 at 9:30p
activeDec 24, '14 at 2:34p
posts13
users1
websitehive.apache.org

1 user in discussion

Brock Noland (JIRA): 13 posts

People

Translate

site design / logo © 2021 Grokbase