Grokbase Groups Hive dev June 2011
FAQ
[ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050511#comment-13050511 ]

jiraposter@reviews.apache.org commented on HIVE-306:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/926/
-----------------------------------------------------------

Review request for hive.


Summary
-------

New feature to allow INSERT INTO a table or partition


This addresses bug HIVE-306.
https://issues.apache.org/jira/browse/HIVE-306


Diffs
-----

trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

Diff: https://reviews.apache.org/r/926/diff


Testing
-------


Thanks,

Franklin


Support "INSERT [INTO] destination"
-----------------------------------

Key: HIVE-306
URL: https://issues.apache.org/jira/browse/HIVE-306
Project: Hive
Issue Type: New Feature
Reporter: Zheng Shao
Assignee: Franklin Hu
Attachments: hive-306.1.patch


Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Search Discussions

  • Franklin Hu (JIRA) at Jun 16, 2011 at 3:56 pm
    [ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050512#comment-13050512 ]

    Franklin Hu commented on HIVE-306:
    ----------------------------------

    Submitted to review board

    https://reviews.apache.org/r/926/diff/
    Support "INSERT [INTO] destination"
    -----------------------------------

    Key: HIVE-306
    URL: https://issues.apache.org/jira/browse/HIVE-306
    Project: Hive
    Issue Type: New Feature
    Reporter: Zheng Shao
    Assignee: Franklin Hu
    Attachments: hive-306.1.patch


    Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
    --
    This message is automatically generated by JIRA.
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • jiraposter@reviews.apache.org (JIRA) at Jun 16, 2011 at 6:10 pm
    [ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050614#comment-13050614 ]

    jiraposter@reviews.apache.org commented on HIVE-306:
    ----------------------------------------------------


    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/#review852
    -----------------------------------------------------------



    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
    <https://reviews.apache.org/r/926/#comment1861>

    Is that difficult to extend it with INSERT INTO DIRECTORY?


    - Ning


    On 2011-06-16 15:53:03, Franklin Hu wrote:
    bq.
    bq. -----------------------------------------------------------
    bq. This is an automatically generated e-mail. To reply, visit:
    bq. https://reviews.apache.org/r/926/
    bq. -----------------------------------------------------------
    bq.
    bq. (Updated 2011-06-16 15:53:03)
    bq.
    bq.
    bq. Review request for hive.
    bq.
    bq.
    bq. Summary
    bq. -------
    bq.
    bq. New feature to allow INSERT INTO a table or partition
    bq.
    bq.
    bq. This addresses bug HIVE-306.
    bq. https://issues.apache.org/jira/browse/HIVE-306
    bq.
    bq.
    bq. Diffs
    bq. -----
    bq.
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
    bq. trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION
    bq.
    bq. Diff: https://reviews.apache.org/r/926/diff
    bq.
    bq.
    bq. Testing
    bq. -------
    bq.
    bq.
    bq. Thanks,
    bq.
    bq. Franklin
    bq.
    bq.


    Support "INSERT [INTO] destination"
    -----------------------------------

    Key: HIVE-306
    URL: https://issues.apache.org/jira/browse/HIVE-306
    Project: Hive
    Issue Type: New Feature
    Reporter: Zheng Shao
    Assignee: Franklin Hu
    Attachments: hive-306.1.patch


    Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
    --
    This message is automatically generated by JIRA.
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • jiraposter@reviews.apache.org (JIRA) at Jun 21, 2011 at 6:06 pm
    [ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052725#comment-13052725 ]

    jiraposter@reviews.apache.org commented on HIVE-306:
    ----------------------------------------------------



    bq. On 2011-06-16 18:08:03, Ning Zhang wrote:
    bq. > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g, line 1397
    bq. > <https://reviews.apache.org/r/926/diff/1/?file=21218#file21218line1397>
    bq. >
    bq. > Is that difficult to extend it with INSERT INTO DIRECTORY?

    We were not sure how widely it would be used so decided not to support it initially.


    - Franklin


    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/#review852
    -----------------------------------------------------------


    On 2011-06-16 15:53:03, Franklin Hu wrote:
    bq.
    bq. -----------------------------------------------------------
    bq. This is an automatically generated e-mail. To reply, visit:
    bq. https://reviews.apache.org/r/926/
    bq. -----------------------------------------------------------
    bq.
    bq. (Updated 2011-06-16 15:53:03)
    bq.
    bq.
    bq. Review request for hive.
    bq.
    bq.
    bq. Summary
    bq. -------
    bq.
    bq. New feature to allow INSERT INTO a table or partition
    bq.
    bq.
    bq. This addresses bug HIVE-306.
    bq. https://issues.apache.org/jira/browse/HIVE-306
    bq.
    bq.
    bq. Diffs
    bq. -----
    bq.
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
    bq. trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION
    bq.
    bq. Diff: https://reviews.apache.org/r/926/diff
    bq.
    bq.
    bq. Testing
    bq. -------
    bq.
    bq.
    bq. Thanks,
    bq.
    bq. Franklin
    bq.
    bq.


    Support "INSERT [INTO] destination"
    -----------------------------------

    Key: HIVE-306
    URL: https://issues.apache.org/jira/browse/HIVE-306
    Project: Hive
    Issue Type: New Feature
    Reporter: Zheng Shao
    Assignee: Franklin Hu
    Attachments: hive-306.1.patch


    Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
    --
    This message is automatically generated by JIRA.
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • jiraposter@reviews.apache.org (JIRA) at Jun 28, 2011 at 2:54 am
    [ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056262#comment-13056262 ]

    jiraposter@reviews.apache.org commented on HIVE-306:
    ----------------------------------------------------


    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/#review925
    -----------------------------------------------------------



    trunk/ql/src/test/queries/clientnegative/insert_into3.q
    <https://reviews.apache.org/r/926/#comment1988>

    Isn't it supposed to succeed instead of failing?

    What we need is a test that the lock is on partition level.



    trunk/ql/src/test/queries/clientpositive/insert_into6.q
    <https://reviews.apache.org/r/926/#comment1989>

    we need to add a test for dynamic partitioning that the partitions are not empty when you insert into. Also, some partitions inserted is empty and some are not.


    - Siying


    On 2011-06-16 15:53:03, Franklin Hu wrote:
    bq.
    bq. -----------------------------------------------------------
    bq. This is an automatically generated e-mail. To reply, visit:
    bq. https://reviews.apache.org/r/926/
    bq. -----------------------------------------------------------
    bq.
    bq. (Updated 2011-06-16 15:53:03)
    bq.
    bq.
    bq. Review request for hive.
    bq.
    bq.
    bq. Summary
    bq. -------
    bq.
    bq. New feature to allow INSERT INTO a table or partition
    bq.
    bq.
    bq. This addresses bug HIVE-306.
    bq. https://issues.apache.org/jira/browse/HIVE-306
    bq.
    bq.
    bq. Diffs
    bq. -----
    bq.
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
    bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
    bq. trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    bq. trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    bq. trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION
    bq.
    bq. Diff: https://reviews.apache.org/r/926/diff
    bq.
    bq.
    bq. Testing
    bq. -------
    bq.
    bq.
    bq. Thanks,
    bq.
    bq. Franklin
    bq.
    bq.


    Support "INSERT [INTO] destination"
    -----------------------------------

    Key: HIVE-306
    URL: https://issues.apache.org/jira/browse/HIVE-306
    Project: Hive
    Issue Type: New Feature
    Reporter: Zheng Shao
    Assignee: Franklin Hu
    Attachments: hive-306.1.patch


    Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
    --
    This message is automatically generated by JIRA.
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • jiraposter@reviews.apache.org (JIRA) at Jun 30, 2011 at 12:31 am
    [ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057567#comment-13057567 ]

    jiraposter@reviews.apache.org commented on HIVE-306:
    ----------------------------------------------------


    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-06-30 00:29:55.111687)


    Review request for hive.


    Changes
    -------

    remove bad concurrency test, add to positive insert_into2.q to check inserting into an existing partition works


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs (updated)
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1141339
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin


    Support "INSERT [INTO] destination"
    -----------------------------------

    Key: HIVE-306
    URL: https://issues.apache.org/jira/browse/HIVE-306
    Project: Hive
    Issue Type: New Feature
    Reporter: Zheng Shao
    Assignee: Franklin Hu
    Attachments: hive-306.1.patch, hive-306.2.patch


    Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
    --
    This message is automatically generated by JIRA.
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Siying Dong (JIRA) at Jun 30, 2011 at 11:57 pm
    [ https://issues.apache.org/jira/browse/HIVE-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058140#comment-13058140 ]

    Siying Dong commented on HIVE-306:
    ----------------------------------

    +1. Looks good to me for now. I'm running tests. If it is committed, please open a follow-up JIRA for making moving files more efficient and compacting smaller files smarter for it.
    Support "INSERT [INTO] destination"
    -----------------------------------

    Key: HIVE-306
    URL: https://issues.apache.org/jira/browse/HIVE-306
    Project: Hive
    Issue Type: New Feature
    Reporter: Zheng Shao
    Assignee: Franklin Hu
    Attachments: hive-306.1.patch, hive-306.2.patch


    Currently hive only supports "INSERT OVERWRITE destination". We should support "INSERT [INTO] destination".
    --
    This message is automatically generated by JIRA.
    For more information on JIRA, see: http://www.atlassian.com/software/jira

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieshive, hadoop
postedJun 16, '11 at 3:54p
activeJun 30, '11 at 11:57p
posts7
users1
websitehive.apache.org

1 user in discussion

Siying Dong (JIRA): 7 posts

People

Translate

site design / logo © 2021 Grokbase