Grokbase Groups Hive dev June 2011
FAQ
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/926/
-----------------------------------------------------------

Review request for hive.


Summary
-------

New feature to allow INSERT INTO a table or partition


This addresses bug HIVE-306.
https://issues.apache.org/jira/browse/HIVE-306


Diffs
-----

trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

Diff: https://reviews.apache.org/r/926/diff


Testing
-------


Thanks,

Franklin

Search Discussions

  • Ning Zhang at Jun 16, 2011 at 6:08 pm
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/#review852
    -----------------------------------------------------------



    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
    <https://reviews.apache.org/r/926/#comment1861>

    Is that difficult to extend it with INSERT INTO DIRECTORY?


    - Ning

    On 2011-06-16 15:53:03, Franklin Hu wrote:

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-06-16 15:53:03)


    Review request for hive.


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin
  • Franklin Hu at Jun 21, 2011 at 6:03 pm

    On 2011-06-16 18:08:03, Ning Zhang wrote:
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g, line 1397
    <https://reviews.apache.org/r/926/diff/1/?file=21218#file21218line1397>

    Is that difficult to extend it with INSERT INTO DIRECTORY?
    We were not sure how widely it would be used so decided not to support it initially.


    - Franklin


    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/#review852
    -----------------------------------------------------------

    On 2011-06-16 15:53:03, Franklin Hu wrote:

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-06-16 15:53:03)


    Review request for hive.


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin
  • Siying Dong at Jun 28, 2011 at 2:53 am
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/#review925
    -----------------------------------------------------------



    trunk/ql/src/test/queries/clientnegative/insert_into3.q
    <https://reviews.apache.org/r/926/#comment1988>

    Isn't it supposed to succeed instead of failing?

    What we need is a test that the lock is on partition level.



    trunk/ql/src/test/queries/clientpositive/insert_into6.q
    <https://reviews.apache.org/r/926/#comment1989>

    we need to add a test for dynamic partitioning that the partitions are not empty when you insert into. Also, some partitions inserted is empty and some are not.


    - Siying

    On 2011-06-16 15:53:03, Franklin Hu wrote:

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-06-16 15:53:03)


    Review request for hive.


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1133562
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1133562
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin
  • Franklin Hu at Jun 30, 2011 at 12:29 am
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-06-30 00:29:55.111687)


    Review request for hive.


    Changes
    -------

    remove bad concurrency test, add to positive insert_into2.q to check inserting into an existing partition works


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs (updated)
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1141339
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin
  • Franklin Hu at Jul 1, 2011 at 10:40 pm
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-07-01 22:40:24.399513)


    Review request for hive.


    Changes
    -------

    Fix test case errors for TestParseNegative: missing_overwrite.q and TestCliDriver:combine2.q
    Unit tests passed for me


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs (updated)
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1141339
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1141339
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION
    trunk/ql/src/test/results/compiler/errors/missing_overwrite.q.out 1141339

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin
  • Franklin Hu at Jul 11, 2011 at 6:47 pm
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    https://reviews.apache.org/r/926/
    -----------------------------------------------------------

    (Updated 2011-07-11 18:47:53.861068)


    Review request for hive.


    Changes
    -------

    rebase patch


    Summary
    -------

    New feature to allow INSERT INTO a table or partition


    This addresses bug HIVE-306.
    https://issues.apache.org/jira/browse/HIVE-306


    Diffs (updated)
    -----

    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1145273
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1145273
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1145273
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 1145273
    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1145273
    trunk/ql/src/test/queries/clientnegative/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientnegative/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into1.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into2.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into3.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into4.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into5.q PRE-CREATION
    trunk/ql/src/test/queries/clientpositive/insert_into6.q PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientnegative/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into1.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into2.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into3.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into4.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into5.q.out PRE-CREATION
    trunk/ql/src/test/results/clientpositive/insert_into6.q.out PRE-CREATION
    trunk/ql/src/test/results/compiler/errors/missing_overwrite.q.out 1145273

    Diff: https://reviews.apache.org/r/926/diff


    Testing
    -------


    Thanks,

    Franklin

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieshive, hadoop
postedJun 16, '11 at 3:59p
activeJul 11, '11 at 6:47p
posts7
users3
websitehive.apache.org

People

Translate

site design / logo © 2021 Grokbase