FAQ
John Leach created HBASE-13427:
----------------------------------

              Summary: HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
                  Key: HBASE-13427
                  URL: https://issues.apache.org/jira/browse/HBASE-13427
              Project: HBase
           Issue Type: Bug
             Reporter: John Leach


Please see attached graph...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Search Discussions

  • John Leach (JIRA) at Apr 8, 2015 at 4:30 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Attachment: SetFromMap.add_Runnable.tiff

    Graph of addChangedReaderObserver
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Attachments: SetFromMap.add_Runnable.tiff


    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 4:30 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach reassigned HBASE-13427:
    ----------------------------------

         Assignee: John Leach
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: SetFromMap.add_Runnable.tiff


    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 4:30 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Remaining Estimate: 2h
          Original Estimate: 2h
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 6:03 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Work on HBASE-13427 started by John Leach.
    ------------------------------------------
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 6:04 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Attachment: HBASE-13427.patch

    Attached patch
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 6:04 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Status: Patch Available (was: In Progress)
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Ted Yu (JIRA) at Apr 8, 2015 at 6:23 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485718#comment-14485718 ]

    Ted Yu commented on HBASE-13427:
    --------------------------------

    lgtm

    nit:
    {code}
    878 if (obj != null)
    879 return ((StoreScanner) obj).storeScannerID == this.storeScannerID;
    {code}
    Please enclose the return statement in curly braces.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 7:57 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Status: Open (was: Patch Available)

    Cancel patch, adding curly...
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 7:57 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Attachment: HBASE-13427_CURLY_BRACES.patch

    Adding Curly Braces
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 7:57 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Work on HBASE-13427 started by John Leach.
    ------------------------------------------
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 7:57 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Status: Patch Available (was: In Progress)

    New Patch with curly braces
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 8, 2015 at 7:58 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485902#comment-14485902 ]

    John Leach commented on HBASE-13427:
    ------------------------------------

    nits make the world go around... Love em...
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Ted Yu (JIRA) at Apr 8, 2015 at 8:32 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485953#comment-14485953 ]

    Ted Yu commented on HBASE-13427:
    --------------------------------

    Looks like git repo is not accessible:
    {code}
    FATAL: Failed to fetch from https://git-wip-us.apache.org/repos/asf/hbase.git
    hudson.plugins.git.GitException: Failed to fetch from https://git-wip-us.apache.org/repos/asf/hbase.git
      at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:647)
      at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:889)
    {code}
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hadoop QA (JIRA) at Apr 8, 2015 at 11:18 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486298#comment-14486298 ]

    Hadoop QA commented on HBASE-13427:
    -----------------------------------

    {color:red}-1 overall{color}. Here are the results of testing the latest attachment
       http://issues.apache.org/jira/secure/attachment/12723997/HBASE-13427_CURLY_BRACES.patch
       against master branch at commit cbc53a0ba58f32de54614cdfaa8acc0c1b92786a.
       ATTACHMENT ID: 12723997

         {color:green}+1 @author{color}. The patch does not contain any @author tags.

         {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
                             Please justify why no new tests are needed for this patch.
                             Also please list what manual steps were performed to verify this patch.

         {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

         {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.

         {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings.

         {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.

                     {color:red}-1 checkstyle{color}. The applied patch generated 1923 checkstyle errors (more than the master's current 1921 errors).

         {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

         {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.

         {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100

       {color:green}+1 site{color}. The mvn site goal succeeds with this patch.

         {color:green}+1 core tests{color}. The patch passed unit tests in .

          {color:red}-1 core zombie tests{color}. There are 5 zombie test(s): at org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders.testSeekingOnSample(TestDataBlockEncoders.java:204)
      at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testStoreFileCacheOnWriteInternals(TestCacheOnWrite.java:270)
      at org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testStoreFileCacheOnWrite(TestCacheOnWrite.java:486)
      at org.apache.hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder.testEnsureSpaceForKey(TestBufferedDataBlockEncoder.java:36)
      at org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers.testEncodedSeeker(TestEncodedSeekers.java:121)

    Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13627//testReport/
    Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13627//artifact/patchprocess/newFindbugsWarnings.html
    Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13627//artifact/patchprocess/checkstyle-aggregate.html

                     Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13627//console

    This message is automatically generated.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 9, 2015 at 2:03 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Status: Open (was: Patch Available)

    Fixing checkstyle.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 9, 2015 at 2:04 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Attachment: HBASE-13427_V3.patch

    Attaching file with checkstyle error fixes.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 9, 2015 at 2:04 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-13427:
    -------------------------------
         Status: Patch Available (was: Open)

    Patch Submitted
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Remaining Estimate: 2h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Apr 9, 2015 at 2:08 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?focusedWorklogId=21104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-21104 ]

    John Leach logged work on HBASE-13427:
    --------------------------------------

                     Author: John Leach
                 Created on: 09/Apr/15 15:08
                 Start Date: 09/Apr/15 15:08
         Worklog Time Spent: 2h

    Issue Time Tracking
    -------------------

                 Worklog Id: (was: 21104)
                 Time Spent: 2h
         Remaining Estimate: 0h (was: 2h)
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Ted Yu (JIRA) at Apr 9, 2015 at 3:46 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487547#comment-14487547 ]

    Ted Yu commented on HBASE-13427:
    --------------------------------

    +1
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Elliott Clark (JIRA) at Apr 9, 2015 at 4:09 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487588#comment-14487588 ]

    Elliott Clark commented on HBASE-13427:
    ---------------------------------------

    Probably better to check the type of obj rather than just assume it. Equals is supposed to be throw free.
    storeScannerSequence should be final.
    storeScannerID should also be final too.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hadoop QA (JIRA) at Apr 9, 2015 at 4:29 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487616#comment-14487616 ]

    Hadoop QA commented on HBASE-13427:
    -----------------------------------

    {color:red}-1 overall{color}. Here are the results of testing the latest attachment
       http://issues.apache.org/jira/secure/attachment/12724220/HBASE-13427_V3.patch
       against master branch at commit 80dbf06651e527ec0421ce51e4712ffb2f1d078b.
       ATTACHMENT ID: 12724220

         {color:green}+1 @author{color}. The patch does not contain any @author tags.

         {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
                             Please justify why no new tests are needed for this patch.
                             Also please list what manual steps were performed to verify this patch.

         {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

         {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.

         {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings.

         {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.

         {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors

         {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

         {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.

         {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100

       {color:green}+1 site{color}. The mvn site goal succeeds with this patch.

         {color:green}+1 core tests{color}. The patch passed unit tests in .

    Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13647//testReport/
    Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13647//artifact/patchprocess/newFindbugsWarnings.html
    Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13647//artifact/patchprocess/checkstyle-aggregate.html

       Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13647//console

    This message is automatically generated.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Ted Yu (JIRA) at Apr 10, 2015 at 2:18 am
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488765#comment-14488765 ]

    Ted Yu commented on HBASE-13427:
    --------------------------------

    [~eclark]:
    See if patch v4 is better.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Ted Yu (JIRA) at Apr 10, 2015 at 2:19 am
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Ted Yu updated HBASE-13427:
    ---------------------------
         Attachment: 13427-v4.txt
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hadoop QA (JIRA) at Apr 10, 2015 at 6:13 am
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489012#comment-14489012 ]

    Hadoop QA commented on HBASE-13427:
    -----------------------------------

    {color:red}-1 overall{color}. Here are the results of testing the latest attachment
       http://issues.apache.org/jira/secure/attachment/12724433/13427-v4.txt
       against master branch at commit 3cd929eea253afd632b6def7c24df434872a2d7d.
       ATTACHMENT ID: 12724433

         {color:green}+1 @author{color}. The patch does not contain any @author tags.

         {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
                             Please justify why no new tests are needed for this patch.
                             Also please list what manual steps were performed to verify this patch.

         {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

         {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.

         {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings.

         {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.

         {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors

         {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

         {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.

         {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100

       {color:green}+1 site{color}. The mvn site goal succeeds with this patch.

         {color:green}+1 core tests{color}. The patch passed unit tests in .

    Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13657//testReport/
    Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13657//artifact/patchprocess/newFindbugsWarnings.html
    Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13657//artifact/patchprocess/checkstyle-aggregate.html

       Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13657//console

    This message is automatically generated.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Elliott Clark (JIRA) at Apr 10, 2015 at 3:49 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489832#comment-14489832 ]

    Elliott Clark commented on HBASE-13427:
    ---------------------------------------

    We should probably micro-benchmark this patch just to make sure that
    [~yuzhihong@gmail.com] Patch 4 looks fine. Though I don't think that it was necessary to make it yourself. John seems very capable.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • stack (JIRA) at Apr 13, 2015 at 11:15 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493248#comment-14493248 ]

    stack commented on HBASE-13427:
    -------------------------------

    [~jleach] Did you see improvement when you applied your patch?

    I tried it in a little test (attached) and with the patch, we slow down. If no hash nor equals, we'll do Object hash and equals which will be pretty cheap as I read it: http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/lang/Object.java#Object.hashCode%28%29 Thanks.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • stack (JIRA) at Apr 13, 2015 at 11:17 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HBASE-13427:
    --------------------------
         Attachment: perftest.hstore.changedReadObserver.txt

    Maybe I ran the test wrong. What sort of loading were you doing and I can try and repro.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff, perftest.hstore.changedReadObserver.txt

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Hadoop QA (JIRA) at Apr 14, 2015 at 1:01 am
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493387#comment-14493387 ]

    Hadoop QA commented on HBASE-13427:
    -----------------------------------

    {color:red}-1 overall{color}. Here are the results of testing the latest attachment
       http://issues.apache.org/jira/secure/attachment/12725085/perftest.hstore.changedReadObserver.txt
       against master branch at commit e9da064ccd8dd3c64d99e0863e36cdc1236779f1.
       ATTACHMENT ID: 12725085

         {color:green}+1 @author{color}. The patch does not contain any @author tags.

         {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.

         {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

         {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.

         {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings.

         {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.

         {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors

         {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

         {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.

         {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100

       {color:green}+1 site{color}. The mvn site goal succeeds with this patch.

          {color:red}-1 core tests{color}. The patch failed these unit tests:


          {color:red}-1 core zombie tests{color}. There are 2 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:242)
      at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanEmptyToAPP(TestMultiTableInputFormat.java:187)

    Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13685//testReport/
    Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13685//artifact/patchprocess/newFindbugsWarnings.html
    Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13685//artifact/patchprocess/checkstyle-aggregate.html

       Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13685//console

    This message is automatically generated.
    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff, perftest.hstore.changedReadObserver.txt

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Andrew Purtell (JIRA) at Apr 30, 2015 at 5:45 pm
    [ https://issues.apache.org/jira/browse/HBASE-13427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrew Purtell updated HBASE-13427:
    -----------------------------------
         Status: Open (was: Patch Available)

    Cancelling patch. There are pending questions for the reporter.

    HStore#addChangedReaderObserver hotspots due to missing hashCode and equals on StoreScanner
    -------------------------------------------------------------------------------------------

    Key: HBASE-13427
    URL: https://issues.apache.org/jira/browse/HBASE-13427
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Attachments: 13427-v4.txt, HBASE-13427.patch, HBASE-13427_CURLY_BRACES.patch, HBASE-13427_V3.patch, SetFromMap.add_Runnable.tiff, perftest.hstore.changedReadObserver.txt

    Original Estimate: 2h
    Time Spent: 2h
    Remaining Estimate: 0h

    Please see attached graph...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupissues @
categorieshbase, hadoop
postedApr 8, '15 at 4:29p
activeApr 30, '15 at 5:45p
posts30
users1
websitehbase.apache.org

1 user in discussion

Andrew Purtell (JIRA): 30 posts

People

Translate

site design / logo © 2021 Grokbase