FAQ
John Leach created HBASE-12912:
----------------------------------

              Summary: StoreScanner calls Configuration for Boolean Check on each initialization
                  Key: HBASE-12912
                  URL: https://issues.apache.org/jira/browse/HBASE-12912
              Project: HBase
           Issue Type: Bug
             Reporter: John Leach
          Attachments: StoreScannerStall.tiff

There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....


Code Snippet...

if (store != null && ((HStore)store).getHRegion() != null
         && store.getStorefilesCount() > 1) {
       RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
       if (rsService == null || !rsService.getConfiguration().getBoolean(
             STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
       isParallelSeekEnabled = true;
       executor = rsService.getExecutorService();
     }

Will attach profile...




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Search Discussions

  • John Leach (JIRA) at Jan 23, 2015 at 9:46 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    John Leach updated HBASE-12912:
    -------------------------------
         Attachment: StoreScannerStall.tiff

    A picture of the CPU effect of the boolean check...
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Andrew Purtell (JIRA) at Jan 23, 2015 at 9:51 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrew Purtell reassigned HBASE-12912:
    --------------------------------------

         Assignee: Andrew Purtell
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: Andrew Purtell
    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Andrew Purtell (JIRA) at Jan 23, 2015 at 9:52 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrew Purtell updated HBASE-12912:
    -----------------------------------
         Fix Version/s: 1.1.0
                        0.98.10
                        2.0.0
                        1.0.0

    Thanks, let me look into it. If one of your guys has a patch [~jleach], I'll be happy to reassign.
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: Andrew Purtell
    Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0

    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • John Leach (JIRA) at Jan 23, 2015 at 9:59 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290064#comment-14290064 ]

    John Leach commented on HBASE-12912:
    ------------------------------------

    Assign to me in the near term, and I will have someone fix.
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: Andrew Purtell
    Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0

    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Andrew Purtell (JIRA) at Jan 23, 2015 at 10:03 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrew Purtell updated HBASE-12912:
    -----------------------------------
         Assignee: John Leach (was: Andrew Purtell)

    Reassigned as requested, thanks!
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0

    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Lars Hofhansl (JIRA) at Jan 23, 2015 at 11:00 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290178#comment-14290178 ]

    Lars Hofhansl commented on HBASE-12912:
    ---------------------------------------

    I see two calls to getBoolean in there:

    This one:
    {code}
    if (rsService == null || !rsService.getConfiguration().getBoolean(
                 STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    {code}
    and this (which I added recently):
    {code}
    this.scanUsePread = conf.getBoolean("hbase.storescanner.use.pread", scan.isSmall());
    {code}

    We can remove the latter one as far as I am concerned. I added that mostly for experimentation until we have HDFS-6735 (which has now been committed).

    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0

    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Andrew Purtell (JIRA) at Jan 25, 2015 at 5:08 pm
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrew Purtell updated HBASE-12912:
    -----------------------------------
         Fix Version/s: (was: 0.98.10)
                        0.98.11
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Fix For: 1.0.0, 2.0.0, 1.1.0, 0.98.11

    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)
  • Enis Soztutar (JIRA) at Jan 26, 2015 at 12:19 am
    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Enis Soztutar updated HBASE-12912:
    ----------------------------------
         Fix Version/s: (was: 1.0.0)
                        1.0.1
    StoreScanner calls Configuration for Boolean Check on each initialization
    -------------------------------------------------------------------------

    Key: HBASE-12912
    URL: https://issues.apache.org/jira/browse/HBASE-12912
    Project: HBase
    Issue Type: Bug
    Reporter: John Leach
    Assignee: John Leach
    Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11

    Attachments: StoreScannerStall.tiff

    Original Estimate: 1h
    Remaining Estimate: 1h

    There is a clear CPU drain and iterator creation when creating store scanners under high load. Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
    Code Snippet...
    if (store != null && ((HStore)store).getHRegion() != null
    && store.getStorefilesCount() > 1) {
    RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
    if (rsService == null || !rsService.getConfiguration().getBoolean(
    STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
    isParallelSeekEnabled = true;
    executor = rsService.getExecutorService();
    }
    Will attach profile...


    --
    This message was sent by Atlassian JIRA
    (v6.3.4#6332)

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupissues @
categorieshbase, hadoop
postedJan 23, '15 at 9:46p
activeJan 26, '15 at 12:19a
posts9
users1
websitehbase.apache.org

1 user in discussion

Enis Soztutar (JIRA): 9 posts

People

Translate

site design / logo © 2021 Grokbase