FAQ
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1181/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Removes the +1, -1 madness that I described in the jira and adds a unit test for log cleaning.


This addresses bug HBASE-3198.
http://issues.apache.org/jira/browse/HBASE-3198


Diffs
-----

/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1031797
/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1031797

Diff: http://review.cloudera.org/r/1181/diff


Testing
-------


Thanks,

Jean-Daniel

Search Discussions

  • Stack at Nov 5, 2010 at 9:51 pm
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://review.cloudera.org/r/1181/#review1825
    -----------------------------------------------------------

    Ship it!


    Looks good to me (after chatting more with j-d)


    /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
    <http://review.cloudera.org/r/1181/#comment5902>

    This is not your comment but I don't understand what its trying to say... can you fix?


    - stack

    On 2010-11-05 14:23:30, Jean-Daniel Cryans wrote:

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://review.cloudera.org/r/1181/
    -----------------------------------------------------------

    (Updated 2010-11-05 14:23:30)


    Review request for hbase.


    Summary
    -------

    Removes the +1, -1 madness that I described in the jira and adds a unit test for log cleaning.


    This addresses bug HBASE-3198.
    http://issues.apache.org/jira/browse/HBASE-3198


    Diffs
    -----

    /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1031797
    /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1031797

    Diff: http://review.cloudera.org/r/1181/diff


    Testing
    -------


    Thanks,

    Jean-Daniel

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieshbase, hadoop
postedNov 5, '10 at 9:51p
activeNov 5, '10 at 10:20p
posts2
users2
websitehbase.apache.org

2 users in discussion

Stack: 1 post Jean-Daniel Cryans: 1 post

People

Translate

site design / logo © 2022 Grokbase