FAQ
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/977/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Return 404 when an attempt is made to create a scanner on a nonexistent table.


This addresses bug HBASE-2907.
http://issues.apache.org/jira/browse/HBASE-2907


Diffs
-----

src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java 6ee7230
src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java bc9fb8b

Diff: http://review.cloudera.org/r/977/diff


Testing
-------

New unit test, passes.


Thanks,

Andrew

Search Discussions

  • Jonathan Gray at Oct 6, 2010 at 10:08 pm
    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://review.cloudera.org/r/977/#review1459
    -----------------------------------------------------------

    Ship it!


    Looks good to me. I think in other parts of code we'll do something like: if (e instanceof SomeExceptionType) but I guess these two ways are basically equivalent? Or the instanceof way would cover more generic stuff like seeing if something is an IOE but would work even if the actual constructed class was something else but that extended IOE.

    - Jonathan

    On 2010-10-06 15:00:19, Andrew Purtell wrote:

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://review.cloudera.org/r/977/
    -----------------------------------------------------------

    (Updated 2010-10-06 15:00:19)


    Review request for hbase.


    Summary
    -------

    Return 404 when an attempt is made to create a scanner on a nonexistent table.


    This addresses bug HBASE-2907.
    http://issues.apache.org/jira/browse/HBASE-2907


    Diffs
    -----

    src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java 6ee7230
    src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java bc9fb8b

    Diff: http://review.cloudera.org/r/977/diff


    Testing
    -------

    New unit test, passes.


    Thanks,

    Andrew
  • Andrew Purtell at Oct 6, 2010 at 10:13 pm

    On 2010-10-06 15:08:23, Jonathan Gray wrote:
    Looks good to me. I think in other parts of code we'll do something like: if (e instanceof SomeExceptionType) but I guess these two ways are basically equivalent? Or the instanceof way would cover more generic stuff like seeing if something is an IOE but would work even if the actual constructed class was something else but that extended IOE.
    Right, I was thinking of using Class.isAssignableFrom but forget if that reads left-to-right or right-to-left so I gave up. instanceof is better than equality, I'll use it.


    - Andrew


    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://review.cloudera.org/r/977/#review1459
    -----------------------------------------------------------

    On 2010-10-06 15:00:19, Andrew Purtell wrote:

    -----------------------------------------------------------
    This is an automatically generated e-mail. To reply, visit:
    http://review.cloudera.org/r/977/
    -----------------------------------------------------------

    (Updated 2010-10-06 15:00:19)


    Review request for hbase.


    Summary
    -------

    Return 404 when an attempt is made to create a scanner on a nonexistent table.


    This addresses bug HBASE-2907.
    http://issues.apache.org/jira/browse/HBASE-2907


    Diffs
    -----

    src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java 6ee7230
    src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java bc9fb8b

    Diff: http://review.cloudera.org/r/977/diff


    Testing
    -------

    New unit test, passes.


    Thanks,

    Andrew

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categorieshbase, hadoop
postedOct 6, '10 at 10:00p
activeOct 6, '10 at 10:13p
posts3
users2
websitehbase.apache.org

2 users in discussion

Andrew Purtell: 2 posts Jonathan Gray: 1 post

People

Translate

site design / logo © 2022 Grokbase