[HBase-dev] [jira] Created: (HBASE-1701) Set status for rowcounter

[ https://issues.apache.org/jira/browse/HBASE-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735096#action_12735096 ]

stack commented on HBASE-1701:
------------------------------

Our rowcounter mapreduce job currently shows no progress and does not set status. Shouldn't be too hard having it guess progress made doing rough BigDecimal on region start/end.

I did this which at least adds some status but I think it might have slowed rowcounter -- check:

{code}
Index: src/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java
===================================================================
--- src/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java (revision 797250)
+++ src/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java (working copy)
@@ -47,8 +47,11 @@
static class RowCounterMapper
extends TableMapper<ImmutableBytesWritable, Result> {

- /** Counter enumeration to count the actual rows. */
+ /* Counter enumeration to count the actual rows. */
private static enum Counters { ROWS }
+
+ /* Local counter for this map. */
+ private long counter = 0;

/**
* Maps the data.
@@ -67,6 +70,7 @@
for (KeyValue value: values.list()) {
if (value.getValue().length > 0) {
context.getCounter(Counters.ROWS).increment(1);
+ context.setStatus("" + counter++);
break;
}
}
{code}

[ https://issues.apache.org/jira/browse/HBASE-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1701.
--------------------------

Resolution: Invalid

This issue is too dumb to have a life. As jdcryans points out, lets just fix this all properly by addiing to TIF progress (we already have an issue for this).