[HBase-dev] [jira] Created: (HBASE-1272) Unreadable log messages -- "... to the only server localhost_1237525439599_56094" <- You'd have to be perverse to recognize that as a hostname, startcode, and port number.

[ https://issues.apache.org/jira/browse/HBASE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683789#action_12683789 ]

stack commented on HBASE-1272:
------------------------------

This seems more reasonable to me:

{code}
Index: src/java/org/apache/hadoop/hbase/HServerInfo.java
===================================================================
--- src/java/org/apache/hadoop/hbase/HServerInfo.java (revision 755875)
+++ src/java/org/apache/hadoop/hbase/HServerInfo.java (working copy)
@@ -198,10 +198,10 @@

private static String getServerName(String hostName, int port, long startCode) {
StringBuilder name = new StringBuilder(hostName);
- name.append("_");
+ name.append(":");
+ name.append(port);
+ name.append(",");
name.append(startCode);
- name.append("_");
- name.append(port);
return name.toString();
}
}
{code}

[ https://issues.apache.org/jira/browse/HBASE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1272:
-------------------------

Fix Version/s: 0.20.0

[ https://issues.apache.org/jira/browse/HBASE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1272.
--------------------------

Resolution: Fixed

Committed below:

{code}
Index: src/java/org/apache/hadoop/hbase/HServerInfo.java
===================================================================
--- src/java/org/apache/hadoop/hbase/HServerInfo.java (revision 777167)
+++ src/java/org/apache/hadoop/hbase/HServerInfo.java (working copy)
@@ -245,10 +245,10 @@

private static String getServerName(String hostName, int port, long startCode) {
StringBuilder name = new StringBuilder(hostName);
- name.append("_");
+ name.append(",");
+ name.append(port);
+ name.append(",");
name.append(startCode);
- name.append("_");
- name.append(port);
return name.toString();
}
}
{code}