[HBase-dev] [jira] Created: (HBASE-1235) Add table enabled status to shell and UI

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678309#action_12678309 ]

Jean-Daniel Cryans commented on HBASE-1235:
-------------------------------------------

I think it's a good idea since now the commands are fixed in 0.19.1 and trunk.

But, in the UI, I would rather see that in the details of a table (when you click on the link on the name of the table) since getting this info can take 1-6 seconds. Add to this more than 1 table and you get very slow main page.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678333#action_12678333 ]

Lars George commented on HBASE-1235:
------------------------------------

Thanks JD, good to know. Will do that then.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678382#action_12678382 ]

stack commented on HBASE-1235:
------------------------------

This'd be a nice improvement lars.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars George updated HBASE-1235:
-------------------------------

Attachment: 1235.patch

Patch for the table.jsp to display the table attributes and for the shell to display the enabled status in the describe call. Michael, due to the current issues I have with trunk and Zookeeper I was not able to see the output of the shell command. It seemed to call the right function but the output is untested. Please test on your end if you can or help me getting the shell working with my test mini cluster which runs locally. Much appreciated.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1235.
--------------------------

Resolution: Fixed
Fix Version/s: 0.20.0

Thanks for the patch Lars. Committed to TRUNK.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679952#action_12679952 ]

stack commented on HBASE-1235:
------------------------------

Feel free to improve on what I committed Lars; e.g. the names of columns and fixing column widths.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars George updated HBASE-1235:
-------------------------------

Attachment: 1235-2.patch

I attached another patch for the shell functionality only, I added the ability to hand in a percentage based width to the formatter. I set the width of the first column to 80% for the describe table. I also changed the column name to DESCRIPTION (as it prints out the same info found in the description column in the master.jsp table of tables).

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars George reopened HBASE-1235:
--------------------------------


Please apply second patch.

[ https://issues.apache.org/jira/browse/HBASE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1235.
--------------------------

Resolution: Fixed

Committed. Thanks for the patch Lars (What was there before was ugly).