[HBase-dev] [jira] Commented: (HBASE-23) UI listing regions should be sorted by address and show additional region state

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596152#action_12596152 ]

stack commented on HBASE-23:
----------------------------

Above its suggested that we add encoded region name to region listings. We should also list is region is online or offline and if it has daughter regions if a split.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596154#action_12596154 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

I'll have a look into it.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596161#action_12596161 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

I see that the jsp code is really HQL-coupled (ShowCommand, TableFormatter, ReturnMsg, etc). Should it stay like this for the moment?

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596171#action_12596171 ]

stack commented on HBASE-23:
----------------------------

Ugh. Yes, for the moment.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596189#action_12596189 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

For the hostname, does it replace the address or not? Also, I've checked in ISA and the hostname is a property

For the load average, I've searched a bit and I can't find the information. Any ideas?

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596196#action_12596196 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

{quote}
We should also list is region is online or offline and if it has daughter regions if a split.
{quote}

For the moment shown regions are only those which are online. So you suggest having 2 tables or 1 with an extra column?

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596204#action_12596204 ]

stack commented on HBASE-23:
----------------------------

Yeah, I suppose showing offlined regions would be a bit tough unless you read the .META. Leave this one off the list. Its possible to figure what you need using shell and only fellas debugging will want the info (though if easy enough, you could print out whether a region has 'references' -- this would demark the regions that still hold references to parent region).

On hostname, it is available? If so, great. I'd say replace the IP w/ hostname. Thats what most would prefer.

Regards load, there is ServerManager.getAverageLoad(). You could print this out in UI as one of the cluster properties (load and average). Otherwise, I there is the loadToServers map which I think we're already reading.

Good stuff Jean-Daniel.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596221#action_12596221 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

{quote}
Yeah, I suppose showing offlined regions would be a bit tough unless you read the .META. Leave this one off the list
{quote}

Funny how there is a onlineRegions attribute in HRegionServer but no offlineRegions. At first glance it seems logic that the two exists but it isn't. Bit misleading.

{quote}
On hostname, it is available? If so, great. I'd say replace the IP w/ hostname. Thats what most would prefer.
{quote}

Yeah in ISA. This is the same as in the dfshealth.jsp page in hadoop ui. I added a getHostname method in HServerAddress just like getPort or getBindAddress to get it in master.jsp

{quote}
Regards load, there is ServerManager.getAverageLoad(). You could print this out in UI as one of the cluster properties (load and average).
{quote}

Ok.

{quote}
Otherwise, I there is the loadToServers map which I think we're already reading.
{quote}

Indeed, this is why I was wondering why that average load by server was nowhere to be found.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596229#action_12596229 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

Oh and one more thing, look at the code which generates the tables table :

{code}
<h2>Tables</h2>
<% ReturnMsg msg = show.execute(conf); %>
<p><%=msg %></p>
{code}

Here comes the HQL coupling to decouple a bit, I guess.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596232#action_12596232 ]

stack commented on HBASE-23:
----------------------------

Yeah. HQL has been configured to output xhtml so you can just toString the result of the execute.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596641#action_12596641 ]

stack commented on HBASE-23:
----------------------------

FYI, leave out the CHANGES.txt changes. Your patch will fail if someone has made a commit ahead of yours.

I tried the patch. Looks really good. I love that we're now showing server names and thanks for renaming catalog tables section.

Would suggest that no reason catalog tables shouldn't be clickable as user tables are. Usually will be one region only but even so, the new Table page shows where that region is located and gives a never-before available quick-path to the hosting region server.

The Is Split column in the table will probably never be true especially when we are doing this:
{code}
+ if (info.isOffline() || info.isSplit()) {
+ continue;
+ }
{code}

Would suggest you remove it (Sorry - -my fault for suggesting it in the first place)

Would you mind fixing the requests calcuation? Its kinda weird at the moment. Its requests per hbase.regionsserver.msginterval (default 3 seconds). It should be showing requests per second. Thats what people expect.

On the code, FYI, the hadoop convention is two-spaces for tabs.

Regards your TODO, that you've duplicated code until we add MetaTable, thats fine.

Was wondering if the .META. table was made of multiple regions and your scanner had to cross from one to the other, do you handle that case?

Otherwise, the patch is great.

[ https://issues.apache.org/jira/browse/HBASE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596765#action_12596765 ]

Jean-Daniel Cryans commented on HBASE-23:
-----------------------------------------

bq. Was wondering if the .META. table was made of multiple regions and your scanner had to cross from one to the other, do you handle that case?

It think so. The first loop scans over each region of .META.

Regards the calculations, I searched "hbase.regionserver.msginterval" in the whole source and it doesn't seem to be used, only referred to in the text so I think I will just remove it. Correct me if I'm wrong.

bq. Would suggest that no reason catalog tables shouldn't be clickable as user tables are.

So that means that they are clickable? I'm confused.