FAQ
Configuration no longer sets all keys in a deprecated key list.
---------------------------------------------------------------

Key: HADOOP-8172
URL: https://issues.apache.org/jira/browse/HADOOP-8172
Project: Hadoop Common
Issue Type: Bug
Components: conf
Affects Versions: 0.24.0, 0.23.3
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Blocker


I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)

{code}
if(!deprecated(key)) {
set(key, value);
} else {
for(String newKey: depricatedKeyMap.get(key)) {
set(newKey, value);
}
}
{code}

to be

{code}
set(key, value);
if(depricatedKeyMap.contains(key)) {
set(deprecatedKeyMap.get(key)[0], value);
} else if(reverseKeyMap.contains(key)) {
set(reverseKeyMap.get(key), value);
}
{code}

If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Search Discussions

  • Robert Joseph Evans (JIRA) at May 1, 2012 at 9:49 pm
    [ https://issues.apache.org/jira/browse/HADOOP-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Joseph Evans resolved HADOOP-8172.
    -----------------------------------------

    Resolution: Fixed
    Fix Version/s: 3.0.0
    2.0.0

    Thanks Anupam,

    I put this into trunk and branch-2. +1
    Configuration no longer sets all keys in a deprecated key list.
    ---------------------------------------------------------------

    Key: HADOOP-8172
    URL: https://issues.apache.org/jira/browse/HADOOP-8172
    Project: Hadoop Common
    Issue Type: Bug
    Components: conf
    Affects Versions: 0.23.3, 0.24.0
    Reporter: Robert Joseph Evans
    Assignee: Anupam Seth
    Priority: Critical
    Fix For: 2.0.0, 3.0.0

    Attachments: HADOOP-8172-branch-2.patch, HADOOP-8172-branch-2.patch


    I did not look at the patch for HADOOP-8167 previously, but I did in response to a recent test failure. The patch appears to have changed the following code (I am just paraphrasing the code)
    {code}
    if(!deprecated(key)) {
    set(key, value);
    } else {
    for(String newKey: depricatedKeyMap.get(key)) {
    set(newKey, value);
    }
    }
    {code}
    to be
    {code}
    set(key, value);
    if(depricatedKeyMap.contains(key)) {
    set(deprecatedKeyMap.get(key)[0], value);
    } else if(reverseKeyMap.contains(key)) {
    set(reverseKeyMap.get(key), value);
    }
    {code}
    If a key is deprecated and is mapped to more then one new key value only the first one in the list will be set, where as previously all of them would be set.
    --
    This message is automatically generated by JIRA.
    If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
    For more information on JIRA, see: http://www.atlassian.com/software/jira

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedMar 15, '12 at 3:08p
activeMay 1, '12 at 9:49p
posts2
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Robert Joseph Evans (JIRA): 2 posts

People

Translate

site design / logo © 2022 Grokbase