Bug in login error handling in org.apache.hadoop.fs.ftp.FTPFileSystem

Key: HADOOP-7127
URL: https://issues.apache.org/jira/browse/HADOOP-7127
Project: Hadoop Common
Issue Type: Bug
Components: fs
Reporter: Niels Basjes

I was playing around with PMD, just to see what kind of messages it gives on hadoop.
I noticed a message about "Dead code" in org.apache.hadoop.fs.ftp.FTPFileSystem

Starting at about line 80:

String userAndPassword = uri.getUserInfo();
if (userAndPassword == null) {
userAndPassword = (conf.get("fs.ftp.user." + host, null) + ":" + conf
.get("fs.ftp.password." + host, null));
if (userAndPassword == null) {
throw new IOException("Invalid user/passsword specified");

The last "if" block is the dead code as the string will always contain at least the text ":" or "null:null"

This means that the error handling fails to work as intended.
It will probably fail a bit later when really trying to login with a wrong uid/password.

P.S. Fix the silly typo "passsword" in the exception message too.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
postedJan 29, '11 at 11:17p
activeJan 29, '11 at 11:17p

1 user in discussion

Niels Basjes (JIRA): 1 post



site design / logo © 2022 Grokbase