FAQ
getUserToGroupsMappingService is not thread safe
------------------------------------------------

Key: HADOOP-7033
URL: https://issues.apache.org/jira/browse/HADOOP-7033
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 0.22.0
Reporter: Eli Collins
Fix For: 0.22.0


test-patch on trunk reports the following findbugs warning:

{noformat}
Incorrect lazy initialization of static field org.apache.hadoop.security.Groups.GROUPS in org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
Bug type LI_LAZY_INIT_STATIC (click for details)
In class org.apache.hadoop.security.Groups
In method org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
On field org.apache.hadoop.security.Groups.GROUPS
At Groups.java:[lines 138-142]
{noformat}

The relevant code:

{noformat}
public static Groups getUserToGroupsMappingService(Configuration conf) {
if(GROUPS == null) {
if(LOG.isDebugEnabled()) {
LOG.debug(" Creating new Groups object");
}
GROUPS = new Groups(conf);
}
return GROUPS;
}
{noformat}

This is problematic if getUserToGroupsMappingService can accessed simultaneously by multiple threads.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Konstantin Shvachko (JIRA) at Jan 24, 2011 at 10:06 pm
    [ https://issues.apache.org/jira/browse/HADOOP-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Konstantin Shvachko resolved HADOOP-7033.
    -----------------------------------------

    Resolution: Duplicate
    Fix Version/s: 0.22.0

    Closing as duplicate of HADOOP-7046.
    getUserToGroupsMappingService is not thread safe
    ------------------------------------------------

    Key: HADOOP-7033
    URL: https://issues.apache.org/jira/browse/HADOOP-7033
    Project: Hadoop Common
    Issue Type: Bug
    Components: security
    Affects Versions: 0.22.0
    Reporter: Eli Collins
    Assignee: Po Cheung
    Fix For: 0.22.0


    test-patch on trunk reports the following findbugs warning:
    {noformat}
    Incorrect lazy initialization of static field org.apache.hadoop.security.Groups.GROUPS in org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
    Bug type LI_LAZY_INIT_STATIC (click for details)
    In class org.apache.hadoop.security.Groups
    In method org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
    On field org.apache.hadoop.security.Groups.GROUPS
    At Groups.java:[lines 138-142]
    {noformat}
    The relevant code:
    {noformat}
    public static Groups getUserToGroupsMappingService(Configuration conf) {
    if(GROUPS == null) {
    if(LOG.isDebugEnabled()) {
    LOG.debug(" Creating new Groups object");
    }
    GROUPS = new Groups(conf);
    }
    return GROUPS;
    }
    {noformat}
    This is problematic if getUserToGroupsMappingService can accessed simultaneously by multiple threads.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Aaron T. Myers (JIRA) at Jan 25, 2011 at 12:05 am
    [ https://issues.apache.org/jira/browse/HADOOP-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Aaron T. Myers reopened HADOOP-7033:
    ------------------------------------


    Though HADOOP-7046 may address the findbugs warning, the underlying synchronization issue remains, and should be addressed. I think we should leave this open until it is.
    getUserToGroupsMappingService is not thread safe
    ------------------------------------------------

    Key: HADOOP-7033
    URL: https://issues.apache.org/jira/browse/HADOOP-7033
    Project: Hadoop Common
    Issue Type: Bug
    Components: security
    Affects Versions: 0.22.0
    Reporter: Eli Collins
    Assignee: Po Cheung
    Fix For: 0.22.0


    test-patch on trunk reports the following findbugs warning:
    {noformat}
    Incorrect lazy initialization of static field org.apache.hadoop.security.Groups.GROUPS in org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
    Bug type LI_LAZY_INIT_STATIC (click for details)
    In class org.apache.hadoop.security.Groups
    In method org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
    On field org.apache.hadoop.security.Groups.GROUPS
    At Groups.java:[lines 138-142]
    {noformat}
    The relevant code:
    {noformat}
    public static Groups getUserToGroupsMappingService(Configuration conf) {
    if(GROUPS == null) {
    if(LOG.isDebugEnabled()) {
    LOG.debug(" Creating new Groups object");
    }
    GROUPS = new Groups(conf);
    }
    return GROUPS;
    }
    {noformat}
    This is problematic if getUserToGroupsMappingService can accessed simultaneously by multiple threads.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Aaron T. Myers (JIRA) at Jan 25, 2011 at 11:20 pm
    [ https://issues.apache.org/jira/browse/HADOOP-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Aaron T. Myers resolved HADOOP-7033.
    ------------------------------------

    Resolution: Duplicate

    Ah yes, I see my confusion. This bug was indeed addressed, though not by HADOOP-7046, but rather by HADOOP-6864.

    Re-resolving as a duplicate.
    getUserToGroupsMappingService is not thread safe
    ------------------------------------------------

    Key: HADOOP-7033
    URL: https://issues.apache.org/jira/browse/HADOOP-7033
    Project: Hadoop Common
    Issue Type: Bug
    Components: security
    Affects Versions: 0.22.0
    Reporter: Eli Collins
    Assignee: Po Cheung
    Fix For: 0.22.0


    test-patch on trunk reports the following findbugs warning:
    {noformat}
    Incorrect lazy initialization of static field org.apache.hadoop.security.Groups.GROUPS in org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
    Bug type LI_LAZY_INIT_STATIC (click for details)
    In class org.apache.hadoop.security.Groups
    In method org.apache.hadoop.security.Groups.getUserToGroupsMappingService(Configuration)
    On field org.apache.hadoop.security.Groups.GROUPS
    At Groups.java:[lines 138-142]
    {noformat}
    The relevant code:
    {noformat}
    public static Groups getUserToGroupsMappingService(Configuration conf) {
    if(GROUPS == null) {
    if(LOG.isDebugEnabled()) {
    LOG.debug(" Creating new Groups object");
    }
    GROUPS = new Groups(conf);
    }
    return GROUPS;
    }
    {noformat}
    This is problematic if getUserToGroupsMappingService can accessed simultaneously by multiple threads.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedNov 14, '10 at 6:52a
activeJan 25, '11 at 11:20p
posts4
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Aaron T. Myers (JIRA): 4 posts

People

Translate

site design / logo © 2022 Grokbase