FAQ
Remove the dependency of GenericOptionsParser on Option.withArgPattern
----------------------------------------------------------------------

Key: HADOOP-5896
URL: https://issues.apache.org/jira/browse/HADOOP-5896
Project: Hadoop Core
Issue Type: Improvement
Reporter: Sharad Agarwal


commons-cli released version does not have Option.withArgPattern API

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Sharad Agarwal (JIRA) at May 22, 2009 at 9:04 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Sharad Agarwal updated HADOOP-5896:
    -----------------------------------

    Attachment: 5896.patch
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Attachments: 5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Sharad Agarwal (JIRA) at May 22, 2009 at 9:04 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Sharad Agarwal updated HADOOP-5896:
    -----------------------------------

    Status: Patch Available (was: Open)
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Attachments: 5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jothi Padmanabhan (JIRA) at May 25, 2009 at 6:24 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712648#action_12712648 ]

    Jothi Padmanabhan commented on HADOOP-5896:
    -------------------------------------------

    The following test is not running with the patch.
    {noformat}
    bin/hadoop jar build/hadoop-0.21.0-dev-test.jar loadgen -Dtest.randomtextwrite.bytes_per_map=10 -Dtest.randomtextwrite.total_bytes=20 -Dmapred.compress.map.output=false -r 1 -outKey org.apache.hadoop.io.Text -outValue org.apache.hadoop.io.Text -outFormat org.apache.hadoop.mapred.lib.NullOutputFormat -outdir fakeout
    {noformat}

    After talking to Sharad offline, this looks like it is primarily to do with the version of cli jar not able to handle multiple -D options.
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Attachments: 5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jothi Padmanabhan (JIRA) at May 25, 2009 at 6:25 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jothi Padmanabhan updated HADOOP-5896:
    --------------------------------------

    Assignee: Sharad Agarwal
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at May 25, 2009 at 8:52 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712792#action_12712792 ]

    Hadoop QA commented on HADOOP-5896:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12408786/5896.patch
    against trunk revision 778388.

    +1 @author. The patch does not contain any @author tags.

    -1 tests included. The patch doesn't appear to include any new or modified tests.
    Please justify why no tests are needed for this patch.

    +1 javadoc. The javadoc tool did not generate any warning messages.

    +1 javac. The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs. The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit. The applied patch does not increase the total number of release audit warnings.

    -1 core tests. The patch failed core unit tests.

    -1 contrib tests. The patch failed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/397/console

    This message is automatically generated.
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Giridharan Kesavan (JIRA) at May 26, 2009 at 3:41 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Giridharan Kesavan updated HADOOP-5896:
    ---------------------------------------

    Status: In Progress (was: Patch Available)
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Giridharan Kesavan (JIRA) at May 26, 2009 at 3:42 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Giridharan Kesavan updated HADOOP-5896:
    ---------------------------------------

    Attachment: HADOOP-5896.patch

    this patch resolves commons-cli for hadoop and commons-cli2 for streaming through ivy.
    tnx!
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Giridharan Kesavan (JIRA) at May 26, 2009 at 3:44 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712843#action_12712843 ]

    Giridharan Kesavan commented on HADOOP-5896:
    --------------------------------------------

    we need to test this patch by removing lib/commons-cli-2.0-SNAPSHOT.jar
    tnx
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Giridharan Kesavan (JIRA) at May 26, 2009 at 8:12 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Giridharan Kesavan updated HADOOP-5896:
    ---------------------------------------

    Attachment: HADOOP-5896.patch

    added the newly added jar's to the eclipse classpath.

    This patch is expected to fail eclipse classpath as hudson will test this patch w/o deleting the lib/commons-cli jar file.
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch, HADOOP-5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Sharad Agarwal (JIRA) at May 27, 2009 at 6:12 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713432#action_12713432 ]

    Sharad Agarwal commented on HADOOP-5896:
    ----------------------------------------

    Tested after removing lib/commons-cli jar, all core tests passed.
    test-patch results:
    -1 overall.
    [exec] +1 @author. The patch does not contain any @author tags.
    [exec] +1 tests included. The patch appears to include 4 new or modified tests.
    [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
    [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
    [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
    [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
    [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

    eclipse classpath is expected to fail as mentioned in previous comment.
    Should we commit this ?

    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch, HADOOP-5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Tom White (JIRA) at May 27, 2009 at 10:18 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713515#action_12713515 ]

    Tom White commented on HADOOP-5896:
    -----------------------------------

    Out of interest, how did you fix the problem of specifying multiple -D options?
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch, HADOOP-5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Sharad Agarwal (JIRA) at May 27, 2009 at 11:16 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713536#action_12713536 ]

    Sharad Agarwal commented on HADOOP-5896:
    ----------------------------------------

    The current patch does fix the multiple -D options.
    The code changes don't work with the current lib/commons-cli-2.0-SNAPSHOT.jar. However it works with commons-cli-1.2.jar as specified in the ivy file in the patch.
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Attachments: 5896.patch, HADOOP-5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Sharad Agarwal (JIRA) at May 29, 2009 at 8:38 am
    [ https://issues.apache.org/jira/browse/HADOOP-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Sharad Agarwal resolved HADOOP-5896.
    ------------------------------------

    Resolution: Fixed
    Fix Version/s: 0.21.0

    I just committed this. Thanks Giri!
    Remove the dependency of GenericOptionsParser on Option.withArgPattern
    ----------------------------------------------------------------------

    Key: HADOOP-5896
    URL: https://issues.apache.org/jira/browse/HADOOP-5896
    Project: Hadoop Core
    Issue Type: Improvement
    Reporter: Sharad Agarwal
    Assignee: Sharad Agarwal
    Fix For: 0.21.0

    Attachments: 5896.patch, HADOOP-5896.patch, HADOOP-5896.patch


    commons-cli released version does not have Option.withArgPattern API
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedMay 22, '09 at 8:42a
activeMay 29, '09 at 8:38a
posts14
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Sharad Agarwal (JIRA): 14 posts

People

Translate

site design / logo © 2022 Grokbase