FAQ
DistCp.sameFile(..) should return true if src fs does not support checksum
--------------------------------------------------------------------------

Key: HADOOP-5671
URL: https://issues.apache.org/jira/browse/HADOOP-5671
Project: Hadoop Core
Issue Type: Bug
Components: tools/distcp
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE


In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Tsz Wo (Nicholas), SZE (JIRA) at Apr 14, 2009 at 8:48 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Tsz Wo (Nicholas), SZE updated HADOOP-5671:
    -------------------------------------------

    Attachment: 5671_20090414.patch

    5671_20090414.patch: If src fs does not support file checksum, it may throw a FileNotFoundException. In such case, we should return true.
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Attachments: 5671_20090414.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Tsz Wo (Nicholas), SZE (JIRA) at Apr 14, 2009 at 11:44 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698984#action_12698984 ]

    Tsz Wo (Nicholas), SZE commented on HADOOP-5671:
    ------------------------------------------------

    {noformat}
    [exec] -1 overall.
    [exec]
    [exec] +1 @author. The patch does not contain any @author tags.
    [exec]
    [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
    [exec] Please justify why no tests are needed for this patch.
    [exec]
    [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
    [exec]
    [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
    [exec]
    [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
    [exec]
    [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
    [exec]
    [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
    {noformat}
    Tested manually, no new tests added.
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Attachments: 5671_20090414.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Tsz Wo (Nicholas), SZE (JIRA) at Apr 15, 2009 at 12:33 am
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Tsz Wo (Nicholas), SZE updated HADOOP-5671:
    -------------------------------------------

    Status: Patch Available (was: Open)
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Attachments: 5671_20090414.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Suresh Srinivas (JIRA) at Apr 15, 2009 at 9:12 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699389#action_12699389 ]

    Suresh Srinivas commented on HADOOP-5671:
    -----------------------------------------

    Based on the documentation of the method {{FileSystem.getFileChecksum()}}, not supporting checksum is indicated by {{null}} return and *not* by throwing exception. So should we ensure the classes extending {{FileSystem}} honor this?
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Tsz Wo (Nicholas), SZE (JIRA) at Apr 15, 2009 at 9:13 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Tsz Wo (Nicholas), SZE updated HADOOP-5671:
    -------------------------------------------

    Attachment: 5671_20090415.patch
    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    More details of the problem:
    Some previous versions HftpFileSystem do not support file checksum and throw FileNotFoundException since the request url is not found. In such case, DistCp.sameFile(..) should return true.

    5671_20090415.patch: rewritten the comments, no code changes.
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Douglas (JIRA) at Apr 15, 2009 at 11:35 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699449#action_12699449 ]

    Chris Douglas commented on HADOOP-5671:
    ---------------------------------------

    +1
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Douglas (JIRA) at Apr 15, 2009 at 11:39 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Douglas updated HADOOP-5671:
    ----------------------------------

    Resolution: Fixed
    Fix Version/s: 0.21.0
    Hadoop Flags: [Reviewed]
    Status: Resolved (was: Patch Available)

    I committed this. Thanks, Nicholas
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Fix For: 0.21.0

    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Koji Noguchi (JIRA) at Apr 16, 2009 at 12:02 am
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699455#action_12699455 ]

    Koji Noguchi commented on HADOOP-5671:
    --------------------------------------

    Thanks Nicholas, Chris, Suresh!

    Since this is sort of a regression for 0.19, can we also commit it to 0.19.* and 0.20.1 ?
    (-update option won't work without this patch when pulling from 0.18 cluster or earlier versions)
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Fix For: 0.21.0

    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • dhruba borthakur (JIRA) at Apr 17, 2009 at 6:40 am
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700029#action_12700029 ]

    dhruba borthakur commented on HADOOP-5671:
    ------------------------------------------

    Really appreciate it if we can commit it to 0.19 and earlier releases.
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Fix For: 0.21.0

    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Apr 20, 2009 at 9:43 am
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700721#action_12700721 ]

    Hudson commented on HADOOP-5671:
    --------------------------------

    Integrated in Hadoop-trunk #811 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/])

    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Fix For: 0.21.0

    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Douglas (JIRA) at Apr 22, 2009 at 8:10 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Douglas updated HADOOP-5671:
    ----------------------------------

    Fix Version/s: (was: 0.21.0)
    0.19.2

    Committed to 0.19.2 and 0.20.1 as well
    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Fix For: 0.19.2

    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Apr 23, 2009 at 8:00 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702077#action_12702077 ]

    Hudson commented on HADOOP-5671:
    --------------------------------

    Integrated in Hadoop-trunk #815 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/815/])
    Move from 0.21 to 0.19.2

    DistCp.sameFile(..) should return true if src fs does not support checksum
    --------------------------------------------------------------------------

    Key: HADOOP-5671
    URL: https://issues.apache.org/jira/browse/HADOOP-5671
    Project: Hadoop Core
    Issue Type: Bug
    Components: tools/distcp
    Reporter: Tsz Wo (Nicholas), SZE
    Assignee: Tsz Wo (Nicholas), SZE
    Fix For: 0.19.2

    Attachments: 5671_20090414.patch, 5671_20090415.patch


    In DistCp.sameFile(..), if src FileSystem does not support file checksum, it should return true.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedApr 14, '09 at 8:23p
activeApr 23, '09 at 8:00p
posts13
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Hudson (JIRA): 13 posts

People

Translate

site design / logo © 2022 Grokbase