[Hadoop-common-dev] [jira] Created: (HADOOP-5308) In case of exception in any FileTailingAdaptor the tailer will exit his main loop

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerome Boulon updated HADOOP-5308:
----------------------------------

Attachment: HADOOP-5308.patch

- remove unused import
- move try/catch block inside the loop

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jerome Boulon updated HADOOP-5308:
----------------------------------

Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676194#action_12676194 ]

Hadoop QA commented on HADOOP-5308:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400779/HADOOP-5308.patch
against trunk revision 747169.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3906/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3906/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3906/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3906/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676844#action_12676844 ]

Ari Rabkin commented on HADOOP-5308:
------------------------------------

Not quite sure I understand what this patch does. What's the benefit of introducing this new isRunning variable that's never set? Why do we both log exceptions, and print the stack trace to stderr? This seems redundant.

Probably at some point we should have a policy about when to use printStackTrace().

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677174#action_12677174 ]

Jerome Boulon commented on HADOOP-5308:
---------------------------------------

If an adaptor throws any exception the tailer will exit from the while loop and therefore will stop producing new chunks.
This patch add a try/catch inside the loop to avoid this problem.

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677538#action_12677538 ]

Eric Yang commented on HADOOP-5308:
-----------------------------------

+1 Looks good.

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated HADOOP-5308:
------------------------------

Resolution: Fixed
Release Note:
What is new in HADOOP-5308:

- Improved exception handling of chukwa file tailing adaptor.

Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)

[ https://issues.apache.org/jira/browse/HADOOP-5308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681771#action_12681771 ]

Hudson commented on HADOOP-5308:
--------------------------------

Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])