FAQ
Variable FileTailingAdaptor adaptor in TerminatorThread should not be static
-----------------------------------------------------------------------------

Key: HADOOP-5313
URL: https://issues.apache.org/jira/browse/HADOOP-5313
Project: Hadoop Core
Issue Type: Bug
Components: contrib/chukwa
Reporter: Jerome Boulon
Assignee: Jerome Boulon


The adaptor field in TerminatorThread should not be static. Each TerminatorThread should work on his own private log file via the adaptor.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Jerome Boulon (JIRA) at Feb 23, 2009 at 11:02 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jerome Boulon updated HADOOP-5313:
    ----------------------------------

    Status: Patch Available (was: Open)
    Variable FileTailingAdaptor adaptor in TerminatorThread should not be static
    -----------------------------------------------------------------------------

    Key: HADOOP-5313
    URL: https://issues.apache.org/jira/browse/HADOOP-5313
    Project: Hadoop Core
    Issue Type: Bug
    Components: contrib/chukwa
    Reporter: Jerome Boulon
    Assignee: Jerome Boulon
    Attachments: HADOOP-5313.patch


    The adaptor field in TerminatorThread should not be static. Each TerminatorThread should work on his own private log file via the adaptor.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jerome Boulon (JIRA) at Feb 23, 2009 at 11:02 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jerome Boulon updated HADOOP-5313:
    ----------------------------------

    Attachment: HADOOP-5313.patch

    - Remove static for adaptor
    - Remove static for ChunkReceiver
    - Remove log(" ") from the busy loop
    - Add debug log

    Also since no one is tracking any TerminatorThread, I've put a time limit on the while loop.

    Variable FileTailingAdaptor adaptor in TerminatorThread should not be static
    -----------------------------------------------------------------------------

    Key: HADOOP-5313
    URL: https://issues.apache.org/jira/browse/HADOOP-5313
    Project: Hadoop Core
    Issue Type: Bug
    Components: contrib/chukwa
    Reporter: Jerome Boulon
    Assignee: Jerome Boulon
    Attachments: HADOOP-5313.patch


    The adaptor field in TerminatorThread should not be static. Each TerminatorThread should work on his own private log file via the adaptor.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Ari Rabkin (JIRA) at Feb 26, 2009 at 1:57 am
    [ https://issues.apache.org/jira/browse/HADOOP-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676847#action_12676847 ]

    Ari Rabkin commented on HADOOP-5313:
    ------------------------------------

    +1.

    At some point we should probably comment that code; I had to think for a minute to remember what problem TerminatorThread solves.
    Variable FileTailingAdaptor adaptor in TerminatorThread should not be static
    -----------------------------------------------------------------------------

    Key: HADOOP-5313
    URL: https://issues.apache.org/jira/browse/HADOOP-5313
    Project: Hadoop Core
    Issue Type: Bug
    Components: contrib/chukwa
    Reporter: Jerome Boulon
    Assignee: Jerome Boulon
    Attachments: HADOOP-5313.patch


    The adaptor field in TerminatorThread should not be static. Each TerminatorThread should work on his own private log file via the adaptor.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Eric Yang (JIRA) at Feb 27, 2009 at 12:18 am
    [ https://issues.apache.org/jira/browse/HADOOP-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Eric Yang updated HADOOP-5313:
    ------------------------------

    Resolution: Fixed
    Release Note:
    What is new in HADOOP-5313:

    - Added 10 minutes time limit for stopping terminator thread
    - Improved logging
    - Changed adaptor to become non-static
    Status: Resolved (was: Patch Available)

    I just committed this. Thanks Jerome.
    Variable FileTailingAdaptor adaptor in TerminatorThread should not be static
    -----------------------------------------------------------------------------

    Key: HADOOP-5313
    URL: https://issues.apache.org/jira/browse/HADOOP-5313
    Project: Hadoop Core
    Issue Type: Bug
    Components: contrib/chukwa
    Reporter: Jerome Boulon
    Assignee: Jerome Boulon
    Attachments: HADOOP-5313.patch


    The adaptor field in TerminatorThread should not be static. Each TerminatorThread should work on his own private log file via the adaptor.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Feb 27, 2009 at 4:03 pm
    [ https://issues.apache.org/jira/browse/HADOOP-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677399#action_12677399 ]

    Hudson commented on HADOOP-5313:
    --------------------------------

    Integrated in Hadoop-trunk #767 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/767/])
    . Added 10 minutes limit for terminator thread to finish.
    Removed static for adaptor.
    Removed static for ChunkReceiver.
    Removed log(" ") from the busy loop.
    Add debug logging.
    (Contribute by Jerome Boulon via eyang)

    Variable FileTailingAdaptor adaptor in TerminatorThread should not be static
    -----------------------------------------------------------------------------

    Key: HADOOP-5313
    URL: https://issues.apache.org/jira/browse/HADOOP-5313
    Project: Hadoop Core
    Issue Type: Bug
    Components: contrib/chukwa
    Reporter: Jerome Boulon
    Assignee: Jerome Boulon
    Attachments: HADOOP-5313.patch


    The adaptor field in TerminatorThread should not be static. Each TerminatorThread should work on his own private log file via the adaptor.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedFeb 23, '09 at 9:04p
activeFeb 27, '09 at 4:03p
posts6
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Hudson (JIRA): 6 posts

People

Translate

site design / logo © 2022 Grokbase