[Hadoop-common-dev] [jira] Created: (HADOOP-5097) Remove static variable JspHelper.fsn

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Attachment: 5097_20090121.patch

5097_20090121.patch:
- change JspHelper.fsn from "static" to "private final"
- change a few non-static methods in JspHelper to static

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Attachment: 5097_20090126.patch

5097_20090126.patch: added javadoc and re-organized some methods.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667890#action_12667890 ]

Konstantin Shvachko commented on HADOOP-5097:
---------------------------------------------

# Remove comment in FSNamesystem
/** NameNode RPC address */
# I do not very much like that you add JspHelper as a NameNode members. I understand the intention is not to instantiate objects on the web UI, but may be we should rather consider making most of the methods / fields of JspHelper static instead of constructing the object. In any case it is better not to introduce helper variables in NamNode and DataNode.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Attachment: 5097_20090127.patch

5097_20090127.patch: changed all JspHelp methods to static and removed /** NameNode RPC address */

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Attachment: 5097_20090127b.patch

5097_20090127b.patch: UnixUserGroupInformation.saveToConf() should be done in static. Thank Suresh for catching this.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Assignee: Tsz Wo (Nicholas), SZE
Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667989#action_12667989 ]

Hadoop QA commented on HADOOP-5097:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12398867/5097_20090127b.patch
against trunk revision 738329.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs. The patch appears to cause Findbugs to fail.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3764/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3764/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3764/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668105#action_12668105 ]

Suresh Srinivas commented on HADOOP-5097:
-----------------------------------------

+1 for the patch if findbugs and test failures are fixed.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Status: Open (was: Patch Available)

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Attachment: 5097_20090128.patch

There were no new findbugs warnings. The problem is that hdfsproxy cannot be compiled after the changes. I guess test-patch was confused.

5097_20090128.patch: fixed the problem with hdfsproxy.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)

Passed all tests locally.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668655#action_12668655 ]

Hadoop QA commented on HADOOP-5097:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12398958/5097_20090128.patch
against trunk revision 738931.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3775/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3775/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3775/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3775/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Status: Open (was: Patch Available)

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Attachment: 5097_20090129.patch

5097_20090129.patch: revert some changes in FileDataServlet so that it won't affect hdfsproxy.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668687#action_12668687 ]

Suresh Srinivas commented on HADOOP-5097:
-----------------------------------------

+1. New patch looks good

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Fix Version/s: 0.21.0
Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669189#action_12669189 ]

Hadoop QA commented on HADOOP-5097:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12399072/5097_20090129.patch
against trunk revision 739416.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3780/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3780/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3780/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3780/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5097:
-------------------------------------------

Resolution: Fixed
Status: Resolved (was: Patch Available)

The failed Chukwa tests are not related to the changes here.

I just committed this.

[ https://issues.apache.org/jira/browse/HADOOP-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673979#action_12673979 ]

Hudson commented on HADOOP-5097:
--------------------------------

Integrated in Hadoop-trunk #756 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/])