FAQ
Use the full path when move files to .Trash/Current
---------------------------------------------------

Key: HADOOP-4970
URL: https://issues.apache.org/jira/browse/HADOOP-4970
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Affects Versions: 0.19.0
Reporter: Prasad Chakka
Assignee: Prasad Chakka


When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Doug Cutting (JIRA) at Jan 5, 2009 at 6:44 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660850#action_12660850 ]

    Doug Cutting commented on HADOOP-4970:
    --------------------------------------

    This sounds reasonable to me.
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka

    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • dhruba borthakur (JIRA) at Jan 5, 2009 at 6:58 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660856#action_12660856 ]

    dhruba borthakur commented on HADOOP-4970:
    ------------------------------------------

    +1 on this one.

    There could be some confusion when there are multiple paths to the same file (e.g. hard links), but since hdfs does not have hard-links, we can ignore that issue.
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka

    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Prasad Chakka (JIRA) at Jan 6, 2009 at 8:24 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Prasad Chakka updated HADOOP-4970:
    ----------------------------------

    Attachment: hadoop-4970.patch
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • dhruba borthakur (JIRA) at Jan 6, 2009 at 11:36 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661374#action_12661374 ]

    dhruba borthakur commented on HADOOP-4970:
    ------------------------------------------

    +1 The code changes look good to me.
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Prasad Chakka (JIRA) at Jan 7, 2009 at 2:04 am
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Prasad Chakka updated HADOOP-4970:
    ----------------------------------

    Release Note: Absolute path of the deleted file will be used while moving to trash to make undelete possible.
    Status: Patch Available (was: Open)
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Prasad Chakka (JIRA) at Jan 9, 2009 at 5:52 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662445#action_12662445 ]

    Prasad Chakka commented on HADOOP-4970:
    ---------------------------------------

    I ran 'ant -Djava5.home=/usr/local/jdk1.5.0_07 -Dforrest.home=/home/dhruba/forrest -Dfindbugs.home=/home/dhruba/findbugs test-patch -Dpatch.file=../hadoopcore/hadoop-4970.patch' and the output is below

    [exec] ======================================================================
    [exec] ======================================================================
    [exec] Running Eclipse classpath verification.
    [exec] ======================================================================
    [exec] ======================================================================
    [exec]
    [exec]
    [exec]
    [exec]
    [exec]
    [exec]
    [exec] +1 overall.
    [exec]
    [exec] +1 @author. The patch does not contain any @author tags.
    [exec]
    [exec] +1 tests included. The patch appears to include 3 new or modified tests.
    [exec]
    [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
    [exec]
    [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
    [exec]
    [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
    [exec]
    [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
    [exec]
    [exec]
    [exec]
    [exec]
    [exec] ======================================================================
    [exec] ======================================================================
    [exec] Finished build.
    [exec] ======================================================================
    [exec] ======================================================================

    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • dhruba borthakur (JIRA) at Jan 23, 2009 at 4:46 am
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666369#action_12666369 ]

    dhruba borthakur commented on HADOOP-4970:
    ------------------------------------------

    I am going to commit this to trunk only. I would not pull this into 0.19 or 0.20 because it is kinda change in semantics.
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Prasad Chakka (JIRA) at Jan 23, 2009 at 4:50 am
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666372#action_12666372 ]

    Prasad Chakka commented on HADOOP-4970:
    ---------------------------------------

    since 0.20 is not already released, it would be nice if you can put this in 0.20.
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • dhruba borthakur (JIRA) at Jan 28, 2009 at 7:06 am
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    dhruba borthakur updated HADOOP-4970:
    -------------------------------------

    Fix Version/s: 0.20.0
    Status: Open (was: Patch Available)

    Hi Prasad, can you pl upload a new patch? The current patch does not apply to trunk anymore. Sorry!
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Fix For: 0.20.0

    Attachments: hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Prasad Chakka (JIRA) at Jan 28, 2009 at 7:15 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Prasad Chakka updated HADOOP-4970:
    ----------------------------------

    Attachment: hadoop-4970.2.patch

    ported to latest
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Fix For: 0.20.0

    Attachments: hadoop-4970.2.patch, hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Prasad Chakka (JIRA) at Jan 28, 2009 at 7:15 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Prasad Chakka updated HADOOP-4970:
    ----------------------------------

    Status: Patch Available (was: Open)
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Fix For: 0.20.0

    Attachments: hadoop-4970.2.patch, hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • dhruba borthakur (JIRA) at Jan 28, 2009 at 8:21 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    dhruba borthakur updated HADOOP-4970:
    -------------------------------------

    Resolution: Fixed
    Hadoop Flags: [Incompatible change, Reviewed]
    Status: Resolved (was: Patch Available)

    I just committed this. Thanks Prasad!
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Fix For: 0.20.0

    Attachments: hadoop-4970.2.patch, hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Feb 16, 2009 at 5:05 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673996#action_12673996 ]

    Hudson commented on HADOOP-4970:
    --------------------------------

    Integrated in Hadoop-trunk #756 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/])

    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Fix For: 0.20.0

    Attachments: hadoop-4970.2.patch, hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Chansler (JIRA) at Mar 3, 2009 at 6:43 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Chansler updated HADOOP-4970:
    ------------------------------------

    Release Note: Changed trash facility to use absolute path of the deleted file. (was: Absolute path of the deleted file will be used while moving to trash to make undelete possible.)
    Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])

    Edit release note for publication.
    Use the full path when move files to .Trash/Current
    ---------------------------------------------------

    Key: HADOOP-4970
    URL: https://issues.apache.org/jira/browse/HADOOP-4970
    Project: Hadoop Core
    Issue Type: Improvement
    Components: dfs
    Affects Versions: 0.19.0
    Reporter: Prasad Chakka
    Assignee: Prasad Chakka
    Fix For: 0.20.0

    Attachments: hadoop-4970.2.patch, hadoop-4970.patch


    When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedDec 31, '08 at 8:02p
activeMar 3, '09 at 6:43p
posts15
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Robert Chansler (JIRA): 15 posts

People

Translate

site design / logo © 2022 Grokbase