Grokbase › Groups › Hadoop › common-dev › December 2008
FAQ
static initializers for default config files duplicate code
-----------------------------------------------------------

Key: HADOOP-4905
URL: https://issues.apache.org/jira/browse/HADOOP-4905
Project: Hadoop Core
Issue Type: Improvement
Components: conf
Affects Versions: 0.20.0
Reporter: Doug Cutting
Assignee: Doug Cutting
Priority: Minor


The default config files are loaded by static initializers. The code in these initializers is two lines that contains string literals. This is fragile and duplicated code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Doug Cutting (JIRA) at Dec 17, 2008 at 5:24 pm ⇧
    [ https://issues.apache.org/jira/browse/HADOOP-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657454#action_12657454 ]

    Doug Cutting commented on HADOOP-4905:
    --------------------------------------

    We should replace code like the following
    {code}
    static {
    Configuration.addDefaultResource("hdfs-default.xml");
    Configuration.addDefaultResource("hdfs-site.xml");
    }
    {code}
    with something like:
    {code}
    static { HdfsConfig.initialize(); }
    {code}

    static initializers for default config files duplicate code
    -----------------------------------------------------------

    Key: HADOOP-4905
    URL: https://issues.apache.org/jira/browse/HADOOP-4905
    Project: Hadoop Core
    Issue Type: Improvement
    Components: conf
    Affects Versions: 0.20.0
    Reporter: Doug Cutting
    Assignee: Doug Cutting
    Priority: Minor

    The default config files are loaded by static initializers. The code in these initializers is two lines that contains string literals. This is fragile and duplicated code.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Raghu Angadi (JIRA) at Dec 17, 2008 at 5:30 pm ⇧
    [ https://issues.apache.org/jira/browse/HADOOP-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657457#action_12657457 ]

    Raghu Angadi commented on HADOOP-4905:
    --------------------------------------

    +1. I was thinking on these lines when I attached patch for HADOOP-4896.
    static initializers for default config files duplicate code
    -----------------------------------------------------------

    Key: HADOOP-4905
    URL: https://issues.apache.org/jira/browse/HADOOP-4905
    Project: Hadoop Core
    Issue Type: Improvement
    Components: conf
    Affects Versions: 0.20.0
    Reporter: Doug Cutting
    Assignee: Doug Cutting
    Priority: Minor

    The default config files are loaded by static initializers. The code in these initializers is two lines that contains string literals. This is fragile and duplicated code.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedDec 17, '08 at 5:24p
activeDec 17, '08 at 5:30p
posts3
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Raghu Angadi (JIRA): 3 posts

Content

People

Support

Translate

site design / logo © 2022 Grokbase