[Hadoop-common-dev] [jira] Created: (HADOOP-4737) Job end notification should give status as "KILLED" when job gets killed.

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated HADOOP-4737:
---------------------------------------

Fix Version/s: 0.20.0

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4737:
--------------------------------------------

Attachment: patch-4737.txt

Patch fixing JobEndNotifier. Updated NotificationTestcase to test FAILED and KILLED jobs.
Fixed LocalJobRunner to set state as KILLED when a job is KILLED.

{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}

All core and contrib tests passed on my machine

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4737:
--------------------------------------------

Assignee: Amareshwari Sriramadasu
Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654368#action_12654368 ]

Alejandro Abdelnur commented on HADOOP-4737:
--------------------------------------------

it looks good

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654991#action_12654991 ]

Hadoop QA commented on HADOOP-4737:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395413/patch-4737.txt
against trunk revision 724578.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3696/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4737:
--------------------------------------------

Status: Open (was: Patch Available)

TestLocalMRNotification passes on machine.
[junit] Running org.apache.hadoop.mapred.TestLocalMRNotification
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 10.097 sec
trying hudson again.

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4737:
--------------------------------------------

Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4737:
--------------------------------------------

Attachment: patch-4737-1.txt

Fixed a bug in LocalJobRunner from the earlier patch to set the state KILLED.

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655132#action_12655132 ]

Amareshwari Sriramadasu commented on HADOOP-4737:
-------------------------------------------------

test-patch result had no warnings. All core and contrib unit tests passed on my machine

[ https://issues.apache.org/jira/browse/HADOOP-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-4737:
--------------------------------

Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)

I just committed this. Thanks, Amareshwari!