[Hadoop-common-dev] [jira] Created: (HADOOP-4690) fuse-dfs - create source file/function + utils + config + main source files

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-4690:
---------------------------------

Attachment: HADOOP-4690.txt

this is a cut at it. I broke every fuse implementation into its own file and created various utility files. This will make things more modular and allow more than one diff to happen at a time since all won't be in one file.

I wasn't sure about TestFuseDFS since there's a bunch of setup required to start the minicluster and then mount fuse and should we create separate tests. I guess it could be a bunch of classes - one for each test that testfusedfs could call.

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-4690:
---------------------------------

Fix Version/s: 0.20.0
Assignee: Pete Wyckoff

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-4690:
---------------------------------

Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650783#action_12650783 ]

dhruba borthakur commented on HADOOP-4690:
------------------------------------------

+1. Code looks good.

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650880#action_12650880 ]

Hadoop QA commented on HADOOP-4690:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394472/HADOOP-4690.txt
against trunk revision 720698.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651119#action_12651119 ]

Pete Wyckoff commented on HADOOP-4690:
--------------------------------------

ready to commit - testjobtrackerrestart caused the failure which is not related to this patch as this patch doesn't introduce any changes outside of fuse-dfs.

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-4690:
---------------------------------

Attachment: HADOOP-4690.txt

updated to reflect hadoop 4635 change to TestFuseDFS.

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652476#action_12652476 ]

Mahadev konar commented on HADOOP-4690:
---------------------------------------

the patch uploaded is empty :)... can you upload the right patch?

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pete Wyckoff updated HADOOP-4690:
---------------------------------

Attachment: HADOOP-4690.txt

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-4690:
----------------------------------

Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)

I just committed this. Thanks pete.

[ https://issues.apache.org/jira/browse/HADOOP-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654075#action_12654075 ]

Hudson commented on HADOOP-4690:
--------------------------------

Integrated in Hadoop-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/])