FAQ
FsAction operations shouldn't create new Objects
------------------------------------------------

Key: HADOOP-4408
URL: https://issues.apache.org/jira/browse/HADOOP-4408
Project: Hadoop Core
Issue Type: Bug
Components: fs
Affects Versions: 0.16.0
Reporter: Chris Douglas
Priority: Minor
Fix For: 0.20.0


FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Chris Douglas (JIRA) at Oct 14, 2008 at 1:48 am
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Douglas updated HADOOP-4408:
    ----------------------------------

    Status: Patch Available (was: Open)
    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Douglas (JIRA) at Oct 14, 2008 at 1:48 am
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Douglas updated HADOOP-4408:
    ----------------------------------

    Attachment: 4408-0.patch
    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Tsz Wo (Nicholas), SZE (JIRA) at Oct 14, 2008 at 1:50 am
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639274#action_12639274 ]

    Tsz Wo (Nicholas), SZE commented on HADOOP-4408:
    ------------------------------------------------

    +1 patch looks good.
    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Oct 14, 2008 at 5:18 am
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639308#action_12639308 ]

    Hadoop QA commented on HADOOP-4408:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12392054/4408-0.patch
    against trunk revision 704261.

    +1 @author. The patch does not contain any @author tags.

    -1 tests included. The patch doesn't appear to include any new or modified tests.
    Please justify why no tests are needed for this patch.

    +1 javadoc. The javadoc tool did not generate any warning messages.

    +1 javac. The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs. The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 core tests. The patch failed core unit tests.

    +1 contrib tests. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3454/console

    This message is automatically generated.
    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Douglas (JIRA) at Oct 16, 2008 at 2:33 am
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Douglas updated HADOOP-4408:
    ----------------------------------

    Resolution: Fixed
    Hadoop Flags: [Reviewed]
    Status: Resolved (was: Patch Available)

    I just committed this.
    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Douglas (JIRA) at Oct 16, 2008 at 4:41 am
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Chris Douglas reassigned HADOOP-4408:
    -------------------------------------

    Assignee: Chris Douglas
    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Assignee: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Oct 16, 2008 at 3:58 pm
    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640194#action_12640194 ]

    Hudson commented on HADOOP-4408:
    --------------------------------

    Integrated in Hadoop-trunk #635 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/635/])
    . FsAction functions need not create new objects.

    FsAction operations shouldn't create new Objects
    ------------------------------------------------

    Key: HADOOP-4408
    URL: https://issues.apache.org/jira/browse/HADOOP-4408
    Project: Hadoop Core
    Issue Type: Bug
    Components: fs
    Affects Versions: 0.16.0
    Reporter: Chris Douglas
    Assignee: Chris Douglas
    Priority: Minor
    Fix For: 0.20.0

    Attachments: 4408-0.patch


    FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedOct 14, '08 at 1:46a
activeOct 16, '08 at 3:58p
posts8
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Hudson (JIRA): 8 posts

People

Translate

site design / logo © 2022 Grokbase