[Hadoop-common-dev] [jira] Created: (HADOOP-3696) Dependency cycle: Submitter and TaskTracker

[ https://issues.apache.org/jira/browse/HADOOP-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill de hOra updated HADOOP-3696:
---------------------------------

Attachment: HADOOP-3696.patch

patch for issue

all Submitter does for TaskTracker is wrap a call to JobConf, which is fielded on TaskTracker anyway; letting TaskTracker call its own field directly breaks the dependency cycle between the packages

[ https://issues.apache.org/jira/browse/HADOOP-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611785#action_12611785 ]

Tom White commented on HADOOP-3696:
-----------------------------------

It's a pity that the configuration property name gets pulled into TaskTracker, but then again, this will be fixed by HADOOP-3583 hopefully, so maybe it's not too bad.

[ https://issues.apache.org/jira/browse/HADOOP-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-3696:
------------------------------

Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611902#action_12611902 ]

Hadoop QA commented on HADOOP-3696:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385337/HADOOP-3696.patch
against trunk revision 675078.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2825/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2825/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2825/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2825/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-3696:
----------------------------------

Status: Open (was: Patch Available)

Overall, I agree with goals of this jira.

The fact that the TaskTracker (logically) depends on Hadoop Pipes (even after the programmatic dependency is broken by Bill's patch) still bothers me.

I'd like to propose we add a new config parameter: *mapred.task.debug.extra.opts* which are tacked to the end of the command line for the debug script. Hadoop Pipes (or others like Hadoop Streaming) can then use this seamlessly. Thoughts?

----

PS: I've opened HADOOP-3803 for further cleanup of handling the way task debugging is done...

[ https://issues.apache.org/jira/browse/HADOOP-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy reassigned HADOOP-3696:
-------------------------------------

Assignee: Bill de hOra