[Hadoop-common-dev] [jira] Created: (HADOOP-3541) Namespace recovery from the secondary image should be documented.

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3541:
----------------------------------------

Attachment: SecondaryDoc.patch

Here is the documentation.

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607658#action_12607658 ]

Lohit Vijayarenu commented on HADOOP-3541:
------------------------------------------

+1 Looks good
- Can we describe <i>create an empty storage directory</i>, to be more explicit saying we should not have name/current directory
- Would it be good idea to document about <i>fs.checkpoint.period</i> and <i>fs.checkpoint.size</i>.

PS: Shouldnt the patch contain only .xml file changes?

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607658#action_12607658 ]

lohit edited comment on HADOOP-3541 at 6/24/08 9:19 AM:
-------------------------------------------------------------------

+1 Looks good
- Can we describe _create an empty storage directory_, to be more explicit saying we should not have name/current directory
- Would it be good idea to document about _fs.checkpoint.period_ and _fs.checkpoint.size_.

PS: Shouldnt the patch contain only .xml file changes?

was (Author: lohit):
+1 Looks good
- Can we describe <i>create an empty storage directory</i>, to be more explicit saying we should not have name/current directory
- Would it be good idea to document about <i>fs.checkpoint.period</i> and <i>fs.checkpoint.size</i>.

PS: Shouldnt the patch contain only .xml file changes?

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-3541:
----------------------------------------

Attachment: SecondaryDoc.patch

It is a good idea to document fs.checkpoint.period and .size properties. I did that.
By saying "create empty directory" I actually mean creating an empty directory that is the one that does not
contain anything inside. Don' know how to clarify it better.
Yes you are right that the implementation checks only that the directory does not contain a legal image,
but I think the documentation should say empty directory, that way there will be no confusion if we ever
change any thing in the internal directory structure.
I thought we commit xml files as well as the generated by forrest html and pdf files. So my patch contains all three.
Please let me know if this is wrong.

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3541:
-------------------------------------

Hadoop Flags: [Reviewed]

+1 Looks good.

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko resolved HADOOP-3541.
-----------------------------------------

Resolution: Fixed

I just committed this.

[ https://issues.apache.org/jira/browse/HADOOP-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608020#action_12608020 ]

Hudson commented on HADOOP-3541:
--------------------------------

Integrated in Hadoop-trunk #529 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/529/])