[Hadoop-common-dev] [jira] Created: (HADOOP-3488) the rsync command in hadoop-daemon.sh also rsync the logs folder from the master, what deletes the datanode / tasktracker log files.

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Groschupf updated HADOOP-3488:
-------------------------------------

Attachment: exclude_logs_folder.patch

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602468#action_12602468 ]

Doug Cutting commented on HADOOP-3488:
--------------------------------------

This won't work if someone has set HADOOP_LOG_DIR, will it? But perhaps it won't harm things either...

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602482#action_12602482 ]

Stefan Groschupf commented on HADOOP-3488:
------------------------------------------

Right, it wont work for that. But in case someone sets HADOOP_LOG_DIR this new folder is properly out side the rsync'ed folders anyhow.
At least we should not delete all logs by default.

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616294#action_12616294 ]

Stefan Groschupf commented on HADOOP-3488:
------------------------------------------

Any updates here? Are we still rsync all logfiles around all nodes?

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-3488:
------------------------------------

Component/s: dfs

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Macdonald updated HADOOP-3488:
------------------------------------

Attachment: hadoop3488.v2.patch

Updated patch. This excludes the Hadoop logs and the HOD logs from being rsynced.

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Macdonald updated HADOOP-3488:
------------------------------------

Affects Version/s: (was: 0.16.1)
0.17.1
Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Macdonald updated HADOOP-3488:
------------------------------------

Component/s: (was: dfs)
scripts

Changed component to scripts.

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622024#action_12622024 ]

Hadoop QA commented on HADOOP-3488:
-----------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387874/hadoop3488.v2.patch
against trunk revision 685227.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3044/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3044/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3044/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3044/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622180#action_12622180 ]

Craig Macdonald commented on HADOOP-3488:
-----------------------------------------

* No new tests because it's a change to the rsync part in hadoop-daemon
* Core test failures are unrelated to this patch (actually hdfs).

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3488:
----------------------------------

Resolution: Fixed
Fix Version/s: 0.19.0
Assignee: Craig Macdonald
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)

I just committed this. Thanks, Stefan and Craig!

[ https://issues.apache.org/jira/browse/HADOOP-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627485#action_12627485 ]

Hudson commented on HADOOP-3488:
--------------------------------

Integrated in Hadoop-trunk #589 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/589/])