[Hadoop-common-dev] [jira] Created: (HADOOP-3099) Need new options in distcp for preserving ower, group and permission

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582494#action_12582494 ]

Tsz Wo (Nicholas), SZE commented on HADOOP-3099:
------------------------------------------------

I suggest changing -p to -p[rbugp]:
r: replication#
b: block size
u: user
g: group
p: permission

-p along means -prb for backward compatibility.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582494#action_12582494 ]

szetszwo edited comment on HADOOP-3099 at 3/26/08 5:51 PM:
-------------------------------------------------------------------------

I suggest changing -p to -p[rbugp]:
r: replication#
b: block size
u: user
g: group
p: permission

-p alone means -prb for backward compatibility.

was (Author: szetszwo):
I suggest changing -p to -p[rbugp]:
r: replication#
b: block size
u: user
g: group
p: permission

-p along means -prb for backward compatibility.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582519#action_12582519 ]

Sameer Paranjpye commented on HADOOP-3099:
------------------------------------------

+1

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582653#action_12582653 ]

Allen Wittenauer commented on HADOOP-3099:
------------------------------------------

-p should include ugp by default. Pretty much EVERY standard UNIX command uses -p == permissions (tar, pax, cp, scp, ... ). This is going to be expected behavior. Anything less is going to be extremely confusing and cause endless issues.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582720#action_12582720 ]

Doug Cutting commented on HADOOP-3099:
--------------------------------------
+1 This is a change from current behaviour, but I'd argue it's a bugfix rather than an incompatibility and I'd be very surprised if it creates any problems.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE reassigned HADOOP-3099:
----------------------------------------------

Assignee: Konstantin Shvachko (was: Tsz Wo (Nicholas), SZE)

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Attachment: 3099_20080327.patch

Here is the codes I got. Konstantin will continue work on it.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE reassigned HADOOP-3099:
----------------------------------------------

Assignee: Tsz Wo (Nicholas), SZE (was: Konstantin Shvachko)

messed up the issues

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Attachment: (was: 3099_20080327.patch)

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Comment: was deleted

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-3099:
--------------------------------

Fix Version/s: (was: 0.16.2)

Not going to make 0.16.2. Moving this 0.17. Could backport to 0.16.3 if there is one.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-3099:
------------------------------------

Priority: Blocker (was: Major)

0.17? Yes!

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Attachment: 3099_20080402b.patch

3099_20080402b.patch:
{noformat}
-p[rbugp] Preserve status
r: replication number
b: block size
u: user
g: group
p: permission
-p alone is equivalent to -prbugp
{noformat}

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585116#action_12585116 ]

Hadoop QA commented on HADOOP-3099:
-----------------------------------

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379223/3099_20080402b.patch
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 6 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2138/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2138/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2138/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585274#action_12585274 ]

Chris Douglas commented on HADOOP-3099:
---------------------------------------

+1 Looks good.

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3099:
----------------------------------

Hadoop Flags: [Reviewed]

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3099:
----------------------------------

Resolution: Fixed
Status: Resolved (was: Patch Available)

I just committed this. Thanks, Nicholas!

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585981#action_12585981 ]

Hudson commented on HADOOP-3099:
--------------------------------

Integrated in Hadoop-trunk #451 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/451/])

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Attachment: 3099_20080402b_0.16.patch

3099_20080402b_0.16.patch: for 0.16

[ https://issues.apache.org/jira/browse/HADOOP-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3099:
-------------------------------------------

Release Note:
Added a new option -p to distcp for preserving file/directory status.
-p[rbugp] Preserve status
r: replication number
b: block size
u: user
g: group
p: permission
-p alone is equivalent to -prbugp