FAQ
FileSplit.getFile(), LineRecordReader. readLine() need to be removed
--------------------------------------------------------------------

Key: HADOOP-2826
URL: https://issues.apache.org/jira/browse/HADOOP-2826
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Amareshwari Sri Ramadasu
Fix For: 0.17.0


The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Robert Chansler (JIRA) at Mar 25, 2008 at 3:07 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Chansler updated HADOOP-2826:
    ------------------------------------

    Fix Version/s: (was: 0.17.0)
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu

    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Sameer Paranjpye (JIRA) at Mar 28, 2008 at 5:42 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Sameer Paranjpye updated HADOOP-2826:
    -------------------------------------

    Fix Version/s: 0.17.0
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Fix For: 0.17.0


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Mar 31, 2008 at 10:54 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Attachment: patch-2826.txt

    Here is patch removing FileSplit.getFile() and LineRecordReader.readLine()
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Mar 31, 2008 at 10:54 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Assignee: Amareshwari Sriramadasu
    Status: Patch Available (was: Open)
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Mar 31, 2008 at 11:04 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583634#action_12583634 ]

    Hadoop QA commented on HADOOP-2826:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12378944/patch-2826.txt
    against trunk revision 619744.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 6 new or modified tests.

    patch -1. The patch command could not apply the patch.

    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2102/console

    This message is automatically generated.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mahadev konar (JIRA) at Mar 31, 2008 at 6:48 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583793#action_12583793 ]

    Mahadev konar commented on HADOOP-2826:
    ---------------------------------------

    instead of public static byte [] readLine(LineReader lineReader)

    why not pass a text object ?

    public static readLine(LineReader lineReader, Text t)

    read into t
    }

    the call would be something like ....
    t.clear()
    call readline(reader, t)

    that would save creating object Text for each readline invocation?


    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 1, 2008 at 5:42 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Status: Open (was: Patch Available)

    Canceling patch to address Mahadev's comment.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 2, 2008 at 5:01 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Attachment: patch-2826.txt

    Here is patch addressing Mahadev's suggestion.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 2, 2008 at 5:03 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Status: Patch Available (was: Open)
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Apr 2, 2008 at 6:25 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584422#action_12584422 ]

    Hadoop QA commented on HADOOP-2826:
    -----------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12379102/patch-2826.txt
    against trunk revision 643282.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 6 new or modified tests.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2119/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2119/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2119/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2119/console

    This message is automatically generated.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 2, 2008 at 11:40 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Status: Open (was: Patch Available)

    Cancelling the patch, because In the patch pipemapred does a arrayCopy to get byteArray of the Text's length. But Text is doing a arrayCopy for readLine. This involves two array copies for each readline call of streaming.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 2, 2008 at 11:46 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Attachment: patch-2826.txt

    This patch removes the arrayCopy added in earlier patch and byte array is passed along with its for the split method. This solution should be
    better than the earlier since we are avoiding the additional arraycopy.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 2, 2008 at 11:48 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Status: Patch Available (was: Open)
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Apr 2, 2008 at 1:15 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584560#action_12584560 ]

    Hadoop QA commented on HADOOP-2826:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12379123/patch-2826.txt
    against trunk revision 643282.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 6 new or modified tests.

    javadoc -1. The javadoc tool appears to have generated 1 warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2122/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2122/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2122/console

    This message is automatically generated.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mahadev konar (JIRA) at Apr 2, 2008 at 5:54 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584694#action_12584694 ]

    Mahadev konar commented on HADOOP-2826:
    ---------------------------------------

    +1 . code looks good.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 3, 2008 at 4:25 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Status: Open (was: Patch Available)
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 3, 2008 at 4:26 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Release Note: Changes the signature of UTF8ByteArrayUtils.readLIne(InputStream) to UTF8ByteArrayUtils.readLIne(LineReader, Text)
    Hadoop Flags: [Incompatible change]
    Status: Patch Available (was: Open)
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 3, 2008 at 4:27 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Attachment: patch-2826.txt

    Removed javadoc warning.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Apr 3, 2008 at 6:19 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585220#action_12585220 ]

    Hadoop QA commented on HADOOP-2826:
    -----------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12379229/patch-2826.txt
    against trunk revision 643282.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 6 new or modified tests.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2141/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2141/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2141/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2141/console

    This message is automatically generated.
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Devaraj Das (JIRA) at Apr 4, 2008 at 3:54 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Devaraj Das updated HADOOP-2826:
    --------------------------------

    Resolution: Fixed
    Release Note:
    Changes the signature of UTF8ByteArrayUtils.readLIne(InputStream) to UTF8ByteArrayUtils.readLIne(LineReader, Text)


    was:Changes the signature of UTF8ByteArrayUtils.readLIne(InputStream) to UTF8ByteArrayUtils.readLIne(LineReader, Text)

    Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change])
    Status: Resolved (was: Patch Available)

    I just committed this. Thanks, Amareshwari!
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Apr 5, 2008 at 12:16 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585974#action_12585974 ]

    Hudson commented on HADOOP-2826:
    --------------------------------

    Integrated in Hadoop-trunk #451 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/451/])
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Joydeep Sen Sarma (JIRA) at Apr 14, 2008 at 10:58 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588835#action_12588835 ]

    Joydeep Sen Sarma commented on HADOOP-2826:
    -------------------------------------------

    i was pulling these changes into our production environment. quick comment:

    we copy over an entire line (from readLine) and then we break it into two strings by splitting on tab. So there is an extra scan of the input data and an extra copy based on splitting by tab.

    instead if we generalized LineReader to instead read until it hits a delimiter - then we can do it with one less scan and copy. Something like:

    byte [] tabDelimiter = new byte [1]; tabDelimiter[0] = '\t';
    byte [] newlineDelimiter = new byte[2]; newlineDelimiter[0] = '\n'; newlineDelimiter[1] = '\r';

    while() {
    lineReader.setDelimiter(tabDelimiter);
    lineReader.readLine(key);
    lineReader.setDelimiter(newlineDelimiter);
    lineReader.readLine(value);
    }

    getting rid of one copy and scan would be pretty big!

    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Amareshwari Sriramadasu (JIRA) at Apr 17, 2008 at 9:04 am
    [ https://issues.apache.org/jira/browse/HADOOP-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Amareshwari Sriramadasu updated HADOOP-2826:
    --------------------------------------------

    Release Note:
    The deprecated methods, public File org.apache.hadoop.mapred.FileSplit.getFile() and
    public static long org.apache.hadoop.mapred.LineRecordReader.readLine(InputStream in, OutputStream out)
    are removed.
    The constructor org.apache.hadoop.mapred.LineRecordReader.LineReader(InputStream in, Configuration conf) 's visibility is made public.
    The signature of the public org.apache.hadoop.streaming.UTF8ByteArrayUtils.readLIne(InputStream) method is changed to UTF8ByteArrayUtils.readLIne(LineReader, Text). Since the old signature is not deprecated, any code using the old method must be changed to use the new method.

    was:
    Changes the signature of UTF8ByteArrayUtils.readLIne(InputStream) to UTF8ByteArrayUtils.readLIne(LineReader, Text)


    Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])
    FileSplit.getFile(), LineRecordReader. readLine() need to be removed
    --------------------------------------------------------------------

    Key: HADOOP-2826
    URL: https://issues.apache.org/jira/browse/HADOOP-2826
    Project: Hadoop Core
    Issue Type: Bug
    Components: mapred
    Reporter: Amareshwari Sriramadasu
    Assignee: Amareshwari Sriramadasu
    Fix For: 0.17.0

    Attachments: patch-2826.txt, patch-2826.txt, patch-2826.txt, patch-2826.txt


    The methods FileSplit.getFile(), LineRecordReader. readLine() need to be removed as they are deprecated.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedFeb 14, '08 at 5:55a
activeApr 17, '08 at 9:04a
posts24
users1
websitehadoop.apache.org...
irc#hadoop

People

Translate

site design / logo © 2022 Grokbase