FAQ
[ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567685#action_12567685 ]

Tsz Wo (Nicholas), SZE commented on HADOOP-2683:
------------------------------------------------

Note that the running time of TestNNThroughputBenchmark drops from 14.281 sec to 4.937 sec in my machine.
Provide a way to specifiy login out side an RPC
-----------------------------------------------

Key: HADOOP-2683
URL: https://issues.apache.org/jira/browse/HADOOP-2683
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.16.0
Reporter: Raghu Angadi
Assignee: Tsz Wo (Nicholas), SZE
Priority: Blocker
Fix For: 0.16.1

Attachments: 2683_20080211.patch


Requirements AFIK :
It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
Please include any other Jira's that depend on this.
Proposed fix:
- UserGroupInformation becomes an abstract class
- public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
- public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
- all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Raghu Angadi (JIRA) at Feb 11, 2008 at 4:42 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567697#action_12567697 ]

    Raghu Angadi commented on HADOOP-2683:
    --------------------------------------

    A few comments:

    # Isn't this a security hole to get super user privileges? All client needs to do is to send NULL for ticket, right? I think Server.getUserInfo() should only return ticket associated with the RPC.
    # Minor: Could you remove debug in setCurrentUGI()? It is run for evey RPC.
    # unrelated warning fixes in Server.java. It will conflict with HADOOP-2789.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Raghu Angadi (JIRA) at Feb 11, 2008 at 4:46 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567701#action_12567701 ]

    Raghu Angadi commented on HADOOP-2683:
    --------------------------------------

    Note that (1) above can happen even with a programming error, need not be deliberate.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Raghu Angadi (JIRA) at Feb 11, 2008 at 5:32 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567719#action_12567719 ]

    Raghu Angadi commented on HADOOP-2683:
    --------------------------------------

    After an RPC is done, UGI is not reset. I would implement Server.java changes like this:

    - Server.java does not call {{UserGroupInformation.setCurrentUGI()}}
    - {{Server.getUserInfo()}} looks like this: {code}
    public static UserGroupInformation getUserInfo() {
    Call call = CurCall.get();
    if (call != null) { // inside an RPC
    return call.connection.ticket;
    }
    return UserGroupInformation.getCurrentUGI();
    } {code}
    - Otherwise, there is no need to have {{Server.getUserInfo()}} at all.


    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Feb 11, 2008 at 5:50 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567724#action_12567724 ]

    Hadoop QA commented on HADOOP-2683:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12375247/2683_20080211.patch
    against trunk revision 619744.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 3 new or modified tests.

    javadoc -1. The javadoc tool appears to have generated 1 warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests -1. The patch failed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1772/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1772/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1772/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1772/console

    This message is automatically generated.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Raghu Angadi (JIRA) at Feb 11, 2008 at 6:46 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567746#action_12567746 ]

    Raghu Angadi commented on HADOOP-2683:
    --------------------------------------

    +1.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Feb 11, 2008 at 8:50 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567813#action_12567813 ]

    Hadoop QA commented on HADOOP-2683:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12375257/2683_20080211b.patch
    against trunk revision 619744.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 3 new or modified tests.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests -1. The patch failed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1774/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1774/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1774/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1774/console

    This message is automatically generated.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Feb 12, 2008 at 7:03 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568296#action_12568296 ]

    Hadoop QA commented on HADOOP-2683:
    -----------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12375398/2683_20080212.patch
    against trunk revision 619744.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 3 new or modified tests.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1783/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1783/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1783/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1783/console

    This message is automatically generated.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Konstantin Shvachko (JIRA) at Feb 13, 2008 at 8:09 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568697#action_12568697 ]

    Konstantin Shvachko commented on HADOOP-2683:
    ---------------------------------------------

    I'd prefer if we could get rid of Server.getUserInfo().
    Current code and the proposed patch need to call Server.getUserInfo() even if there is no RPC and therefore no Server.
    Instead the Server should set UserGroupInformation.currentUGI before executing the call.
    The name-node will call UserGroupInformation.getCurrentUGI() instead Server.getUserInfo().
    If currentUGI = null the PermissionChecker should throw AccessControlException.
    I think we should not automatically assume super privileges currentUGI is null.
    In case of non-RPC calls to name-node methods the caller should explicitly invoke UserGroupInformation.setCurrentUGI(..).
    It could be done once per thread and should not make calls inefficient.

    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Raghu Angadi (JIRA) at Feb 13, 2008 at 8:47 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568712#action_12568712 ]

    Raghu Angadi commented on HADOOP-2683:
    --------------------------------------

    bq. I'd prefer if we could get rid of Server.getUserInfo().
    Current code and the proposed patch need to call Server.getUserInfo() even if there is no RPC and therefore no Server.

    +0.5 :). It is required to call this only if caller expects to be in an RPC. But getting rid of it sounds just as good.

    bq. I think we should not automatically assume super privileges currentUGI is null.
    +1.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Konstantin Shvachko (JIRA) at Feb 13, 2008 at 10:59 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568739#action_12568739 ]

    Konstantin Shvachko commented on HADOOP-2683:
    ---------------------------------------------

    +1
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch, 2683_20080213.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Feb 14, 2008 at 3:37 am
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568790#action_12568790 ]

    Hadoop QA commented on HADOOP-2683:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12375531/2683_20080213.patch
    against trunk revision 619744.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 9 new or modified tests.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac -1. The applied patch generated 604 javac compiler warnings (more than the trunk's current 603 warnings).

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1795/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1795/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1795/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1795/console

    This message is automatically generated.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch, 2683_20080213.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Feb 14, 2008 at 6:57 am
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568818#action_12568818 ]

    Hadoop QA commented on HADOOP-2683:
    -----------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12375548/2683_20080213b.patch
    against trunk revision 619744.

    @author +1. The patch does not contain any @author tags.

    tests included +1. The patch appears to include 9 new or modified tests.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new javac compiler warnings.

    release audit +1. The applied patch does not generate any new release audit warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1798/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1798/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1798/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1798/console

    This message is automatically generated.
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch, 2683_20080213.patch, 2683_20080213b.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Feb 15, 2008 at 12:24 pm
    [ https://issues.apache.org/jira/browse/HADOOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569249#action_12569249 ]

    Hudson commented on HADOOP-2683:
    --------------------------------

    Integrated in Hadoop-trunk #401 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/401/])
    Provide a way to specifiy login out side an RPC
    -----------------------------------------------

    Key: HADOOP-2683
    URL: https://issues.apache.org/jira/browse/HADOOP-2683
    Project: Hadoop Core
    Issue Type: Bug
    Components: dfs
    Affects Versions: 0.16.0
    Reporter: Raghu Angadi
    Assignee: Tsz Wo (Nicholas), SZE
    Priority: Blocker
    Fix For: 0.16.1

    Attachments: 2683_20080211.patch, 2683_20080211b.patch, 2683_20080212.patch, 2683_20080213.patch, 2683_20080213b.patch


    Requirements AFIK :
    It is required in some special cases (benchmarks etc) to invoke NameNode functionality without an RPC. For this users should be able to set user information that is otherwise available only an RPC.
    Patch for HADOOP-1298 includes a change to Server.java so that {{Server.getUserInfo()}} does not need to in an RPC. This probably will be replaced by patch here.
    Please include any other Jira's that depend on this.
    Proposed fix:
    - UserGroupInformation becomes an abstract class
    - public static UserGroupInformation.getUserInfo() is added. which usually just returns Server.getUserInfo();
    - public static UserGroupInformation.setUserInfo(UserGroupInformation) sets a thread local that will returned if Server.getUserInfo() returns null.
    - all invocations of Server.getUserInfo() will be replaced by UserGroupInformation.getUserInfo().
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedFeb 11, '08 at 4:28p
activeFeb 15, '08 at 12:24p
posts14
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Hudson (JIRA): 14 posts

People

Translate

site design / logo © 2022 Grokbase