[Hadoop-common-dev] [jira] Created: (HADOOP-2726) Remove dead code block in JobInProgress.completedTask

Remove dead code block in JobInProgress.completedTask
------------------------------------------------------

Key: HADOOP-2726
URL: https://issues.apache.org/jira/browse/HADOOP-2726
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Affects Versions: 0.15.0
Reporter: Arun C Murthy
Fix For: 0.17.0


Since the taskCommitThread ensures that one and only one task of a given TIP is marked as SUCCEEDED, we don't need the code block in JobInProgress.completedTask which checks if the TIP is complete and then just marks the task as complete:
{noformat}
// Sanity check: is the TIP already complete?
if (tip.isComplete()) {
// Mark this task as KILLED
tip.alreadyCompletedTask(taskid);
// Let the JobTracker cleanup this taskid if the job isn't running
if (this.status.getRunState() != JobStatus.RUNNING) {
jobtracker.markCompletedTaskAttempt(status.getTaskTracker(), taskid);
}
return false;
}
{noformat}

Remove dead code block in JobInProgress.completedTask
------------------------------------------------------

Key: HADOOP-2726
URL: https://issues.apache.org/jira/browse/HADOOP-2726
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Affects Versions: 0.15.0
Reporter: Arun C Murthy
Fix For: 0.17.0


Since the taskCommitThread ensures that one and only one task of a given TIP is marked as SUCCEEDED, we don't need the code block in JobInProgress.completedTask which checks if the TIP is complete and then just marks the task as complete:
{noformat}
// Sanity check: is the TIP already complete?
if (tip.isComplete()) {
// Mark this task as KILLED
tip.alreadyCompletedTask(taskid);
// Let the JobTracker cleanup this taskid if the job isn't running
if (this.status.getRunState() != JobStatus.RUNNING) {
jobtracker.markCompletedTaskAttempt(status.getTaskTracker(), taskid);
}
return false;
}
{noformat}

Remove dead code block in JobInProgress.completedTask
------------------------------------------------------

Key: HADOOP-2726
URL: https://issues.apache.org/jira/browse/HADOOP-2726
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Affects Versions: 0.15.0
Reporter: Arun C Murthy

Since the taskCommitThread ensures that one and only one task of a given TIP is marked as SUCCEEDED, we don't need the code block in JobInProgress.completedTask which checks if the TIP is complete and then just marks the task as complete:
{noformat}
// Sanity check: is the TIP already complete?
if (tip.isComplete()) {
// Mark this task as KILLED
tip.alreadyCompletedTask(taskid);
// Let the JobTracker cleanup this taskid if the job isn't running
if (this.status.getRunState() != JobStatus.RUNNING) {
jobtracker.markCompletedTaskAttempt(status.getTaskTracker(), taskid);
}
return false;
}
{noformat}