[Hadoop-common-dev] [jira] Created: (HADOOP-2298) ant target without source and docs

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546310 ]

Doug Cutting commented on HADOOP-2298:
--------------------------------------

The conventional way to do this is to generate separate source and binary distribution files, including both in releases.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546311 ]

Owen O'Malley commented on HADOOP-2298:
---------------------------------------

I'm not wild about this. I find it _very_ useful to be able to look at the actual sources someone is running on a cluster.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547099 ]

Gautam Kowshik commented on HADOOP-2298:
----------------------------------------

sorry i didn't mention this before. This is with regards to Hadoop On Demand. Hod offers a tarball option that copies the tarball to all nodes in a cluster, installs it there, sets up paths and brings up the hadoop daemons. For large allocations (excess of 500 nodes), we see considerable improvements in turnaround times for bringing up the cluster with a binary-only tarball. This would be a good (added) option for other people writing provisioning software over hadoop. Those who setup static clusters, for whom this is a one time overhead, can use the default build that puts in the docs and sources.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547258 ]

Doug Cutting commented on HADOOP-2298:
--------------------------------------

We could provide an ant target that builds a binary tarball, but still release the compound tarball. Folks could then run the binary-only target from within a release if they want to build a binary-only tarball. Might that suffice?

Producing only a single file per release simplifies things. But we don't want users to have to recompile releases, and writing a binary-only tarball target that doesn't recompile might be tricky. I don't yet have a strong sense about the best way to proceed...

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547793 ]

Gautam Kowshik commented on HADOOP-2298:
----------------------------------------

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2298:
-------------------------------

Attachment: 2298.patch.1

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557596#action_12557596 ]

Hrishikesh commented on HADOOP-2298:
------------------------------------

No one has mentioned any specific name for the target and "minimal" tarfile.
So I have named that target as slimtar and the tar file as ${final.name}-slim.tar.gz

Try out the attached patch 2298.patch.1

Execute
{quote}
ant slimtar
{quote}

Awaiting comments/feedback

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557709#action_12557709 ]

Doug Cutting commented on HADOOP-2298:
--------------------------------------

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557832#action_12557832 ]

Nigel Daley commented on HADOOP-2298:
-------------------------------------

+1 for a target name of "binary" and tar file name of ${final.name}-bin.tar.gz.

Other than that simple change, the patch looks good to me.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557855#action_12557855 ]

Owen O'Malley commented on HADOOP-2298:
---------------------------------------

+1 on "binary" target and "bin" filename extension.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh reassigned HADOOP-2298:
----------------------------------

Assignee: Hrishikesh

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2298:
-------------------------------

Status: Patch Available (was: Open)

Apply patch 2298.patch.2

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558278#action_12558278 ]

Hrishikesh commented on HADOOP-2298:
------------------------------------

Thanks for the comments.
Added attachment 2298.patch.2 with the required changes

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2298:
-------------------------------

Attachment: 2298.patch.2

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558322#action_12558322 ]

Hadoop QA commented on HADOOP-2298:
-----------------------------------

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373033/2298.patch.2
against trunk revision r611488.

@author +1. The patch does not contain any @author tags.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new compiler warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1563/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1563/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1563/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1563/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2298:
-------------------------------

Resolution: Fixed
Status: Resolved (was: Patch Available)

Added a target named binary to generate the tar file without src and docs
usage
{quote}
ant binary
{quote}

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley reopened HADOOP-2298:
---------------------------------


Thanks for the patch Hrishikesh. The issue should be left in "Patch Available" state until a committer commits the patch at which time they will mark it "Fixed".

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2298:
--------------------------------

Fix Version/s: 0.16.0
Status: Patch Available (was: Reopened)

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559436#action_12559436 ]

Hrishikesh commented on HADOOP-2298:
------------------------------------

Ok :)

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559786#action_12559786 ]

Nigel Daley commented on HADOOP-2298:
-------------------------------------

Please update patch for trunk.

[ https://issues.apache.org/jira/browse/HADOOP-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2298:
--------------------------------

Resolution: Fixed
Status: Resolved (was: Patch Available)

I updated the patch and committed it. Thanks Hrishikesh!