[Hadoop-common-dev] [jira] Created: (HADOOP-1772) Hadoop does not run in Cygwin in Windows

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-1772:
-------------------------------------------

Attachment: 1772-20070823.patch

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-1772:
-------------------------------------------

Status: Patch Available (was: Open)

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522296 ]

Hadoop QA commented on HADOOP-1772:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12364454/1772-20070823.patch applied and successfully tested against trunk revision r569063.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/606/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/606/console

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522305 ]

Raghu Angadi commented on HADOOP-1772:
--------------------------------------

If HOSTNAME is not set (for any reason), Hadoop should probably set it to `hostname`.

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522585 ]

Doug Cutting commented on HADOOP-1772:
--------------------------------------

I think bash always sets HOSTNAME, so I don't think that's a concern.

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522609 ]

Tsz Wo (Nicholas), SZE commented on HADOOP-1772:
------------------------------------------------

Correct me if I am wrong: $HOSTNAME is a standard environment variable like $USER, so we can safely use it.

If we don't want to assume $HOSTNAME is set properly, we probably should not assume some commands like hostname are always there.

On the other hand, if $HOSTNAME is not set (say, is "") then the script still works in both Linux and Cygwin. However, it won't work in Cygwin if we use `hostname`.

The problem actually is that `hostname` in Cygwin has an extra <eol>. Is there any standard method to remove it? I tried sed but cannot fix it.

Of course, we can write a Java program to return information like username, hostname, etc. . Then, we don't have to assume anything.

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522611 ]

Raghu Angadi commented on HADOOP-1772:
--------------------------------------

Yes, I do think $HOSTNAME is fine and probably an improvement. Nothing wrong with that. Also this is used only for log file name. These scripts are executed with /bin/sh and not with bash. Of course sh == bash on linux and cygwing, but not on solaris (at least on one solaris machine I could login to). I guess what I am saying is that we are probably replacing one problem with another. I could be fixed if hostname could be used if $HOSTNAME is not defined.

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522612 ]

Doug Cutting commented on HADOOP-1772:
--------------------------------------
Since HADOOP-1689, all scripts specify bash.

[ https://issues.apache.org/jira/browse/HADOOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1772:
---------------------------------

Resolution: Fixed
Fix Version/s: 0.15.0
Status: Resolved (was: Patch Available)

I just committed this. Thanks, Nicholas!