FAQ
[hbase] Make HColumnDescriptor data publically members settable
----------------------------------------------------------------

Key: HADOOP-1737
URL: https://issues.apache.org/jira/browse/HADOOP-1737
Project: Hadoop
Issue Type: Bug
Components: contrib/hbase
Reporter: stack
Assignee: stack
Priority: Minor


On the list Inchol Song made the following reasonable request:

Inchul Song wrote:
I am making changes to Hbase Shell to add support for
the new CREATE TABLE syntax. (See issue HADOOP-1720.)

But there are only two useful constructors in class HColumnDescriptor
for column creation, one with an argument specifying a column name,
the other with a number of arguments specifying all the options
for the column such as a compression method, max length, and so on,

In a CREATE TABLE statement, when a user specifies only
some of the available options, I'd like to fill in the remaining options
with their default values. I expected to access those default values as
public static fields of the HColumnDescriptor class, but those values
were hidden in the class as private fields. So I had to look into
the source code of the HColumnDescriptor class to find out
which default values are used in its single argument constructor.

I think it would be useful to make the default option values
in the HColumnDescriptor class as public static fields.

Is there any reason not to make them public static fields?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • stack (JIRA) at Aug 20, 2007 at 7:47 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HADOOP-1737:
    --------------------------

    Attachment: hadoop-1737.patch

    Here's a first attempt.

    HADOOP-1737 Make HColumnDescriptor data publically members settable

    M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
    Use new HColumnDescriptor accessors rather than make direct accesses
    M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
    (COMPRESSION_NONE, COMPRESSION_RECORD, COMPRESSION_BLOCK): Removed.
    Use enum ordinals instead. Removed mapping between these defines and
    enum equivalents. Made data members private and added accessors.
    (DEFAULT_IN_MEMORY, DEFAULT_COMPRESSION_TYPE,
    DEFAULT_BLOOM_FILTER_DESCRIPTOR, DEFAULT_MAX_VALUE_LENGTH): Added.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Attachments: hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • stack (JIRA) at Aug 20, 2007 at 10:53 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HADOOP-1737:
    --------------------------

    Fix Version/s: 0.15.0
    Status: Patch Available (was: Open)

    Builds locally. Trying against hudson.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jim Kellerman (JIRA) at Aug 20, 2007 at 11:01 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521268 ]

    Jim Kellerman commented on HADOOP-1737:
    ---------------------------------------

    Note that once the column is created, you cannot change the column attributes.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Aug 21, 2007 at 3:30 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521503 ]

    Hadoop QA commented on HADOOP-1737:
    -----------------------------------

    -1, build or testing failed

    2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12364181/hadoop-1737.patch against trunk revision r567877.

    Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/580/testReport/
    Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/580/console

    Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • stack (JIRA) at Aug 21, 2007 at 7:07 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HADOOP-1737:
    --------------------------

    Status: In Progress (was: Patch Available)
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737-v2.patch, hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • stack (JIRA) at Aug 21, 2007 at 7:07 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HADOOP-1737:
    --------------------------

    Attachment: hadoop-1737-v2.patch

    Hudson failed first patch because the hbase TestMasterAdmin test failed but its just passed twice w/o hbase changes.

    I did find a problem though in my first patch that would cause the hbase TestToString to fail so retrying with a fix in this version 2.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737-v2.patch, hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • stack (JIRA) at Aug 21, 2007 at 7:09 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HADOOP-1737:
    --------------------------

    Status: Patch Available (was: In Progress)

    Trying v2.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737-v2.patch, hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Aug 21, 2007 at 8:16 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521571 ]

    Hadoop QA commented on HADOOP-1737:
    -----------------------------------

    +1

    http://issues.apache.org/jira/secure/attachment/12364247/hadoop-1737-v2.patch applied and successfully tested against trunk revision r567877.

    Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/584/testReport/
    Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/584/console
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737-v2.patch, hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • stack (JIRA) at Aug 21, 2007 at 8:54 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    stack updated HADOOP-1737:
    --------------------------

    Resolution: Fixed
    Status: Resolved (was: Patch Available)

    Committed patch. Resolving.
    [hbase] Make HColumnDescriptor data publically members settable
    ----------------------------------------------------------------

    Key: HADOOP-1737
    URL: https://issues.apache.org/jira/browse/HADOOP-1737
    Project: Hadoop
    Issue Type: Bug
    Components: contrib/hbase
    Reporter: stack
    Assignee: stack
    Priority: Minor
    Fix For: 0.15.0

    Attachments: hadoop-1737-v2.patch, hadoop-1737.patch


    On the list Inchol Song made the following reasonable request:
    Inchul Song wrote:
    I am making changes to Hbase Shell to add support for
    the new CREATE TABLE syntax. (See issue HADOOP-1720.)

    But there are only two useful constructors in class HColumnDescriptor
    for column creation, one with an argument specifying a column name,
    the other with a number of arguments specifying all the options
    for the column such as a compression method, max length, and so on,

    In a CREATE TABLE statement, when a user specifies only
    some of the available options, I'd like to fill in the remaining options
    with their default values. I expected to access those default values as
    public static fields of the HColumnDescriptor class, but those values
    were hidden in the class as private fields. So I had to look into
    the source code of the HColumnDescriptor class to find out
    which default values are used in its single argument constructor.

    I think it would be useful to make the default option values
    in the HColumnDescriptor class as public static fields.

    Is there any reason not to make them public static fields?
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedAug 19, '07 at 3:57p
activeAug 21, '07 at 8:54p
posts10
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

stack (JIRA): 10 posts

People

Translate

site design / logo © 2022 Grokbase