FAQ
Configuration XML bug: empty values
-----------------------------------

Key: HADOOP-1347
URL: https://issues.apache.org/jira/browse/HADOOP-1347
Project: Hadoop
Issue Type: Bug
Components: conf
Affects Versions: 0.12.2
Reporter: Eelco Lempsink
Priority: Critical


The configuration parser doesn't handle empty values well:

if ("value".equals(field.getTagName()) && field.hasChildNodes())

This logic makes it impossible to 'unset' a field when loading multiple configurations.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Rajagopal Natarajan (JIRA) at Oct 29, 2007 at 12:22 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Affects Version/s: (was: 0.12.2)
    Status: Patch Available (was: Open)

    Added a case to check if the value was previously set, to be unset, in the case where the new configuration has an empty value for the field.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical

    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Oct 29, 2007 at 12:24 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Comment: was deleted
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical
    Attachments: 1347.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Oct 29, 2007 at 12:24 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Attachment: 1347.patch

    Added a case to check if the value was previously set, to be unset, in the case where the new configuration has an empty value for the field.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical
    Attachments: 1347.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Oct 29, 2007 at 12:28 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Attachment: (was: 1347.patch)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical

    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Oct 29, 2007 at 12:28 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Comment: was deleted
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical

    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Oct 29, 2007 at 12:48 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538483 ]

    Hadoop QA commented on HADOOP-1347:
    -----------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org
    against trunk revision r589576.

    @author +1. The patch does not contain any @author tags.

    patch -1. The patch command could not apply the patch.

    Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1021/console

    This message is automatically generated.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical

    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Arun C Murthy (JIRA) at Oct 30, 2007 at 3:34 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Arun C Murthy updated HADOOP-1347:
    ----------------------------------

    Status: Open (was: Patch Available)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical

    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 14, 2007 at 6:42 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Status: Patch Available (was: Open)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 14, 2007 at 6:42 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Attachment: unset.patch

    If the value field is empty,
    Check if the property corresponding to the empty value already exists in the properties list.
    If it exists, unset it(remove the property from the list)

    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 14, 2007 at 6:42 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan reassigned HADOOP-1347:
    -------------------------------------------

    Assignee: Rajagopal Natarajan
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 14, 2007 at 2:35 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Status: Open (was: Patch Available)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 14, 2007 at 2:37 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Status: Patch Available (was: Open)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Nov 15, 2007 at 6:04 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542679 ]

    Hadoop QA commented on HADOOP-1347:
    -----------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12369478/unset.patch
    against trunk revision r594715.

    @author +1. The patch does not contain any @author tags.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new compiler warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1097/testReport/
    Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1097/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1097/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1097/console

    This message is automatically generated.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Arun C Murthy (JIRA) at Nov 19, 2007 at 8:55 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Arun C Murthy updated HADOOP-1347:
    ----------------------------------

    Status: Open (was: Patch Available)

    Rajagopal, some review comments:

    1. Looks like there are some indentation changes, could you please fix them?
    2. I'm not sure what the use case for 'unset' is, I'm open to a debate about its merits. At the very least you should check if the property had been marked *final* before the unset.
    3. Could you also enhance TestConfiguration and add a test-case for this?

    Thanks!
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 21, 2007 at 3:15 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Status: Patch Available (was: Open)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 21, 2007 at 3:15 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Attachment: unset_with_tests.patch

    Hi Arun,
    Thanks for the comments.
    1. Indentation had been changed.
    2. Say, there is an optional parameter that has been set in the default configuration or site configuration, and the user wants to remove that, unset could be useful instead of leaving the property name in properties list and having a null there. By the default conf reading logic used in the program, if either attr or value were null while reading initially, the property isn't added to properties. Similarly, if at a later point, the value would be null, it sounds logical for me to remove the property. Please correct me if I'm wrong.
    3. A Test Case has been added.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 21, 2007 at 3:19 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Attachment: unset_with_tests.patch

    Somehow a TAB had come into the previous patch. corrected in this patch.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 21, 2007 at 3:19 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Status: Open (was: Patch Available)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Rajagopal Natarajan (JIRA) at Nov 21, 2007 at 3:22 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Rajagopal Natarajan updated HADOOP-1347:
    ----------------------------------------

    Status: Patch Available (was: Open)
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Nov 21, 2007 at 5:33 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544167 ]

    Hadoop QA commented on HADOOP-1347:
    -----------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12369947/unset_with_tests.patch
    against trunk revision r596835.

    @author +1. The patch does not contain any @author tags.

    javadoc +1. The javadoc tool did not generate any warning messages.

    javac +1. The applied patch does not generate any new compiler warnings.

    findbugs +1. The patch does not introduce any new Findbugs warnings.

    core tests +1. The patch passed core unit tests.

    contrib tests +1. The patch passed contrib unit tests.

    Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1133/testReport/
    Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1133/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1133/artifact/trunk/build/test/checkstyle-errors.html
    Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1133/console

    This message is automatically generated.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Arun C Murthy (JIRA) at Nov 23, 2007 at 10:50 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544976 ]

    Arun C Murthy commented on HADOOP-1347:
    ---------------------------------------

    The patch looks fine, but as I noted before I'm not very sure about the merits of allowing configurations to be 'unset'... what is the use case for this?
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Eelco Lempsink (JIRA) at Nov 23, 2007 at 2:01 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545032 ]

    Eelco Lempsink commented on HADOOP-1347:
    ----------------------------------------

    Arun,

    Unsetting values is useful when loading several configurations. After the default configuration is loaded, a user configuration should be able to unset values. I can't remember exactly, but I ran in to this bug when using Nutch and trying to disable all filters for a certain part of the process.

    Other than that, I don't think it's semantically correct to ignore explicit empty configuration values.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Owen O'Malley (JIRA) at Nov 26, 2007 at 6:58 am
    [ https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Owen O'Malley updated HADOOP-1347:
    ----------------------------------

    Status: Open (was: Patch Available)

    -1

    I think this is a really bad plan. I would much prefer a programatic way of clearing a value. In particular, there are values that have semantics for the empty string that are different from being unset. I also think it would be very counter-intuitive.
    Configuration XML bug: empty values
    -----------------------------------

    Key: HADOOP-1347
    URL: https://issues.apache.org/jira/browse/HADOOP-1347
    Project: Hadoop
    Issue Type: Bug
    Components: conf
    Reporter: Eelco Lempsink
    Assignee: Rajagopal Natarajan
    Priority: Critical
    Attachments: unset.patch, unset_with_tests.patch, unset_with_tests.patch


    The configuration parser doesn't handle empty values well:
    if ("value".equals(field.getTagName()) && field.hasChildNodes())
    This logic makes it impossible to 'unset' a field when loading multiple configurations.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedMay 10, '07 at 9:12p
activeNov 26, '07 at 6:58a
posts24
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Owen O'Malley (JIRA): 24 posts

People

Translate

site design / logo © 2022 Grokbase