FAQ
getReordReader methof of InputFormat class should handle null reporter argument
-------------------------------------------------------------------------------

Key: HADOOP-1010
URL: https://issues.apache.org/jira/browse/HADOOP-1010
Project: Hadoop
Issue Type: Bug
Components: mapred
Reporter: Runping Qi



In some cases, I need to create a record reader object in the config method of mappers.
At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Doug Cutting (JIRA) at Feb 12, 2007 at 8:47 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472409 ]

    Doug Cutting commented on HADOOP-1010:
    --------------------------------------

    Alternately, we could provide a Reprter.NULL constant that could be passed in such cases.

    public static final Reporter NULL = new Reporter() { public void setStatus(String s) {} };
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi

    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Runping Qi (JIRA) at Feb 12, 2007 at 9:07 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Runping Qi reassigned HADOOP-1010:
    ----------------------------------

    Assignee: Runping Qi
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi

    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Runping Qi (JIRA) at Feb 12, 2007 at 9:12 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Runping Qi updated HADOOP-1010:
    -------------------------------

    Attachment: hadoop-1010.patch


    This patch adds a NULL constant to Reporter interface.

    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Runping Qi (JIRA) at Feb 12, 2007 at 9:12 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Runping Qi updated HADOOP-1010:
    -------------------------------

    Status: Patch Available (was: Open)


    Added Reporter.NULL constant.

    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Milind Bhandarkar (JIRA) at Feb 12, 2007 at 9:24 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472421 ]

    Milind Bhandarkar commented on HADOOP-1010:
    -------------------------------------------

    I think the right way to do this is by supplying a reporter in all methods of tasks (configure, map/reduce, close). (See HADOOP-403).
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Feb 12, 2007 at 9:33 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472423 ]

    Hadoop QA commented on HADOOP-1010:
    -----------------------------------

    +1, because http://issues.apache.org/jira/secure/attachment/12350967/hadoop-1010.patch applied and successfully tested against trunk revision r505557.
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Doug Cutting (JIRA) at Feb 12, 2007 at 9:43 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472430 ]

    Doug Cutting commented on HADOOP-1010:
    --------------------------------------
    the right way to do this is by supplying a reporter in all methods of tasks
    I'm not sure exactly how that addresses this issue.

    I think we ought to add a Context parameters to most methods on core interfaces, that we can then effectively add and remove/deprecate parameters from these interfaces without breaking implementations. For example, Owen made this a part of his proposal in HADOOP-904. So, as we next modify each interface, I think we ought to convert to this style. And Reporter could then be added as a getReporter() method to the context parameter used by most interfaces, removing it from the explicit parameter list, and solving this issue. But that's a long-term fix. The short term fix Runping attached is probably a good idea in the meantime, no?
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Milind Bhandarkar (JIRA) at Feb 12, 2007 at 10:01 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472436 ]

    Milind Bhandarkar commented on HADOOP-1010:
    -------------------------------------------

    The way I see it, reporter is just another output stream coming out of the task. It should get a uniform treatment just like other streams. Context is a good abstraction, since we would be able to hang non-Strings (such as the task's stream-set) to it.

    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Owen O'Malley (JIRA) at Feb 12, 2007 at 10:47 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472449 ]

    Owen O'Malley commented on HADOOP-1010:
    ---------------------------------------

    Yeah, I agree with Doug that Runping's fix is the right one for the short term and the context parameter is the right long term solution.
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Doug Cutting (JIRA) at Feb 12, 2007 at 11:45 pm
    [ https://issues.apache.org/jira/browse/HADOOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Doug Cutting updated HADOOP-1010:
    ---------------------------------

    Resolution: Fixed
    Fix Version/s: 0.12.0
    Status: Resolved (was: Patch Available)

    I just committed this. Thanks, Runping!
    getReordReader methof of InputFormat class should handle null reporter argument
    -------------------------------------------------------------------------------

    Key: HADOOP-1010
    URL: https://issues.apache.org/jira/browse/HADOOP-1010
    Project: Hadoop
    Issue Type: Bug
    Components: mapred
    Reporter: Runping Qi
    Assigned To: Runping Qi
    Fix For: 0.12.0

    Attachments: hadoop-1010.patch


    In some cases, I need to create a record reader object in the config method of mappers.
    At that time, reporter is not available yet. And logically, the reporter should not be a required for getRecordReader anyway.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedFeb 12, '07 at 8:40p
activeFeb 12, '07 at 11:45p
posts11
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Doug Cutting (JIRA): 11 posts

People

Translate

site design / logo © 2022 Grokbase