FAQ
TaskTracker passes incorrect file path to DF under cygwin
---------------------------------------------------------

Key: HADOOP-344
URL: http://issues.apache.org/jira/browse/HADOOP-344
Project: Hadoop
Type: Bug

Versions: 0.4.0
Environment: Windows
Reporter: Konstantin Shvachko
Attachments: TaskTrackerDF.patch

The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
I'm attaching a patch that does that.
We might want to change the path parameter for DF. Making it File rather than String should prevent us from
bugs like that in the future.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Search Discussions

  • Konstantin Shvachko (JIRA) at Jul 5, 2006 at 10:15 pm
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=all ]

    Konstantin Shvachko updated HADOOP-344:
    ---------------------------------------

    Attachment: TaskTrackerDF.patch
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Type: Bug
    Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Attachments: TaskTrackerDF.patch

    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators:
    http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see:
    http://www.atlassian.com/software/jira
  • Konstantin Shvachko (JIRA) at Jul 5, 2006 at 10:15 pm
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=all ]

    Konstantin Shvachko reassigned HADOOP-344:
    ------------------------------------------

    Assign To: Konstantin Shvachko
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Type: Bug
    Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assignee: Konstantin Shvachko
    Attachments: TaskTrackerDF.patch

    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators:
    http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see:
    http://www.atlassian.com/software/jira
  • Konstantin Shvachko (JIRA) at Jul 20, 2006 at 8:02 pm
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=comments#action_12422474 ]

    Konstantin Shvachko commented on HADOOP-344:
    --------------------------------------------

    This patch is getting stale.
    Is there any reason for not committing this?
    I'm getting FD related exceptions in my windows nightly build.

    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Attachments: TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Doug Cutting (JIRA) at Jul 21, 2006 at 7:13 am
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=comments#action_12422571 ]

    Doug Cutting commented on HADOOP-344:
    -------------------------------------

    Wouldn't it be better to change DF to do 'new File(path).getCanonicalPath()', rather than change the caller?
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Attachments: TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Konstantin Shvachko (JIRA) at Jul 21, 2006 at 7:49 pm
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=comments#action_12422758 ]

    Konstantin Shvachko commented on HADOOP-344:
    --------------------------------------------

    This would also work. But there are 2 other places that already pass canonical paths.
    So we will have to change these two callers in order to avoid repetitive parsing of already
    canonical paths.
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Attachments: TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Doug Cutting (JIRA) at Jul 24, 2006 at 9:12 am
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=comments#action_12423007 ]

    Doug Cutting commented on HADOOP-344:
    -------------------------------------
    there are 2 other places that already pass canonical paths
    Wouldn't it be better to change these? That would minimize code replication, a good thing.
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Attachments: TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Konstantin Shvachko (JIRA) at Jul 24, 2006 at 10:00 pm
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=all ]

    Konstantin Shvachko updated HADOOP-344:
    ---------------------------------------

    Attachment: DFConstructor.patch

    I did two variants.
    - DFConstructor.patch converts path to the canonical form inside the DF constructor.
    I also changed FSDataset() to just simply return the path without canonicalizing it.
    - DFPath2File.patch changes the path parameter type from String to File.
    I String version constructors are deprecated.
    I like this version better for 2 reasons: it makes it clear for the callers what needs to
    be passed, and it does less File to String conversions.

    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Attachments: DFConstructor.patch, TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Konstantin Shvachko (JIRA) at Jul 24, 2006 at 10:08 pm
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=all ]

    Konstantin Shvachko updated HADOOP-344:
    ---------------------------------------

    Attachment: DFPath2File.patch
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Attachments: DFConstructor.patch, DFPath2File.patch, TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira
  • Doug Cutting (JIRA) at Jul 25, 2006 at 9:02 am
    [ http://issues.apache.org/jira/browse/HADOOP-344?page=all ]

    Doug Cutting resolved HADOOP-344.
    ---------------------------------

    Fix Version/s: 0.5.0
    Resolution: Fixed

    I just committed this. Thanks, Konstantin!
    TaskTracker passes incorrect file path to DF under cygwin
    ---------------------------------------------------------

    Key: HADOOP-344
    URL: http://issues.apache.org/jira/browse/HADOOP-344
    Project: Hadoop
    Issue Type: Bug
    Affects Versions: 0.4.0
    Environment: Windows
    Reporter: Konstantin Shvachko
    Assigned To: Konstantin Shvachko
    Fix For: 0.5.0

    Attachments: DFConstructor.patch, DFPath2File.patch, TaskTrackerDF.patch


    The path that is passed is OS dependent. The File abstraction should be used in order to make it universal.
    I'm attaching a patch that does that.
    We might want to change the path parameter for DF. Making it File rather than String should prevent us from
    bugs like that in the future.
    --
    This message is automatically generated by JIRA.
    -
    If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
    -
    For more information on JIRA, see: http://www.atlassian.com/software/jira

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcommon-dev @
categorieshadoop
postedJul 5, '06 at 10:15p
activeJul 25, '06 at 9:02a
posts10
users1
websitehadoop.apache.org...
irc#hadoop

1 user in discussion

Doug Cutting (JIRA): 10 posts

People

Translate

site design / logo © 2022 Grokbase